Wikidata item needs photo although one is already assigned
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Strubbl
	Feb 9 2025, 1:51 PM

Description

Steps to replicate the issue (include links if applicable):

Go on https://wdlocator.toolforge.org/#map=19/48.09745/11.62142
see the rectangle for wikidata item https://www.wikidata.org/wiki/Q98333746
open it and see it has an image/photo assigned to it

What happens?:
Rectangle on https://wdlocator.toolforge.org/#map=19/48.09745/11.62142 is red (Needs photo)

What should have happened instead?:
i expect it to be green (Has photo) according to the legend

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Strubbl created this task.Feb 9 2025, 1:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 9 2025, 1:51 PM

samwilson opened https://gitlab.wikimedia.org/toolforge-repos/wdlocator/-/merge_requests/33

Also refresh Wikidata entity data when refreshing

samwilson merged https://gitlab.wikimedia.org/toolforge-repos/wdlocator/-/merge_requests/33

Also refresh Wikidata entity data when refreshing

Thanks for reporting this!

I assume you tried the (newish) refresh button and it didn't work? I was confused for a moment, because I thought this was fixed and that refreshing should do it. But I seem to have totally forgotten to actually use the refresh flag when fetching the Wikidata entity data. Fixed now hopefully! Your example above is now green at any rate.

Maintenance_bot removed a project: Patch-For-Review.Feb 9 2025, 2:30 PM

Thank you for the quick fix. Now it works as expected for me. Also for some other examples which i edited more recently.
Yes, i did try the refresh button, but i was not sure what it was supposed to do. Because after clicking the refresh button i did not see a difference. Does this button refresh the cached data from OSM, the OSM tiles or from wikidata or all? I do not know which data is cached in the application.

Yes, i did try the refresh button, but i was not sure what it was supposed to do. Because after clicking the refresh button i did not see a difference. Does this button refresh the cached data from OSM, the OSM tiles or from wikidata or all? I do not know which data is cached in the application.

Yeah the idea is that 'refresh' will re-fetch all the OSM and Wikidata data for the current view. It's all cached, in an attempt to make things work a bit faster. Except, as you found, there was no difference! Glad it's working now.

Wikidata item needs photo although one is already assignedClosed, ResolvedPublicBUG REPORTActions

Description

Event Timeline

Wikidata item needs photo although one is already assigned
Closed, ResolvedPublicBUG REPORT
Actions