Page MenuHomePhabricator
Create Task
Maniphest T386020

Implement design for change propagation when WF function calls change
Closed, ResolvedPublic
Actions

Description

Final design for Recent Changes feed entry:

(diff | hist) . . F {{Wikipedia article page title}} (Function:{{Function name}}); 17:07 . . (0) . . Editor123 (talk | contribs) ({{Our own message: {{Raw edit messgage}}}}) (thank)

image.png (1,824×176 px, 63 KB)

Connect / Disconnect
(diff | hist) . . F Douglas Engelbart (Function:Age); 17:07 . . (0) . . Editor123 (talk | contribs) (Connected Implementation Z12345) (thank)
(diff | hist) . . F Douglas Engelbart (Function:Age); 17:07 . . (0) . . Editor123 (talk | contribs) (Disconnected Implementation Z12345) (thank)

Multi-connect / Multi-disconnect
(diff | hist) . . F Douglas Engelbart (Function:Age); 17:07 . . (0) . . Editor123 (talk | contribs) (Connected Implementation Z12345 and Z12346) (thank)
(diff | hist) . . F Douglas Engelbart (Function:Age); 17:07 . . (0) . . Editor123 (talk | contribs) (Disconnected Implementation Z12345 and Z12346) (thank)

Edit
(diff | hist) . . F Douglas Engelbart (Function:Age); 17:07 . . (0) . . Editor123 (talk | contribs) (Edited Implementation Z12345) (thank)

Edit + raw edit message
(diff | hist) . . F Douglas Engelbart (Function:Age); 17:07 . . (0) . . Editor123 (talk | contribs) (Edited Implementation Z12345: Made it better!) (thank)

image.png (2,178×1,272 px, 370 KB)

Links in the entry:

diff should take the user to the diff of the particular edit on Wikifunctions. For eg: Implementation: https://www.wikifunctions.org/w/index.php?title=Z10220&diff=128598&oldid=104368, test diff: https://www.wikifunctions.org/w/index.php?title=Z10512&diff=55024&oldid=31476

hist would link similarly to their respective history pages. For eg: https://www.wikifunctions.org/wiki/Z10512?action=history&uselang=en

Wikipedia article page title will link to the article

Function:{{Function name}} link to the function page

talk user talk page

contribs user contribution page

thank thanks the user for the edit

Editor123 links to user page - to contributions page when not a logged-in user

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Complete our RecentChanges entry generation and formattingJforrestermediawiki/extensions/WikiLambdawmf/1.44.0-wmf.24+565 -139
Complete our RecentChanges entry generation and formattingJforrestermediawiki/extensions/WikiLambdamaster+565 -139
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Sharvaniharan created this task.Feb 10 2025, 8:27 PM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptFeb 10 2025, 8:27 PM
• Sharvaniharan triaged this task as Medium priority.Feb 10 2025, 8:27 PM
• Sharvaniharan added a parent task: T383156: [25Q3] Provide updates to editors when Wikifunctions calls are changed.
• Sharvaniharan moved this task from Incoming to Ready, Quarterly Work on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.
AAlhazwani-WMF updated the task description. (Show Details)Feb 11 2025, 10:30 AM
DSantamaria removed a subtask: T386089: Pass structured data about what change happened on WF that client wikis should care about, for rendering on RC/etc..Feb 21 2025, 6:10 AM
DSantamaria removed a subtask: T386090: Create the class doing the WF function call change RC log entry rendering on client wikis.
DSantamaria added a subtask: T386089: Pass structured data about what change happened on WF that client wikis should care about, for rendering on RC/etc..Mar 3 2025, 2:09 PM
DSantamaria added a subtask: T386090: Create the class doing the WF function call change RC log entry rendering on client wikis.
Jdforrester-WMF changed the status of subtask T386089: Pass structured data about what change happened on WF that client wikis should care about, for rendering on RC/etc. from Open to In Progress.Mar 6 2025, 3:32 PM
Jdforrester-WMF changed the status of subtask T386090: Create the class doing the WF function call change RC log entry rendering on client wikis from Open to In Progress.
Jdforrester-WMF claimed this task.Apr 2 2025, 3:11 PM
Jdforrester-WMF moved this task from Ready, Quarterly Work to In Engineering on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.
DSantamaria changed the task status from Open to In Progress.Apr 4 2025, 2:00 PM
Jdforrester-WMF closed subtask T386090: Create the class doing the WF function call change RC log entry rendering on client wikis as Resolved.Apr 8 2025, 8:30 PM
Jdforrester-WMF closed subtask T386089: Pass structured data about what change happened on WF that client wikis should care about, for rendering on RC/etc. as Resolved.
gerritbot added a comment.Apr 9 2025, 12:18 AM

Change #1135143 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] [WIP] Fix RecentChanges entry generation and formatting

https://gerrit.wikimedia.org/r/1135143

gerritbot added a project: Patch-For-Review.Apr 9 2025, 12:18 AM
Jdforrester-WMF moved this task from In Engineering to In Code review on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.Apr 10 2025, 1:45 PM
Jdforrester-WMF mentioned this in T391584: Complete the successful deployment of embedded Wikifunctions to testwiki.Apr 10 2025, 1:50 PM
gerritbot added a comment.Apr 14 2025, 12:25 PM

Change #1135143 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Complete our RecentChanges entry generation and formatting

https://gerrit.wikimedia.org/r/1135143

gerritbot added a comment.Apr 14 2025, 12:25 PM

Change #1136368 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@wmf/1.44.0-wmf.24] Complete our RecentChanges entry generation and formatting

https://gerrit.wikimedia.org/r/1136368

Jdforrester-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.Apr 14 2025, 12:54 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.25; 2025-04-15).Apr 14 2025, 1:00 PM
gerritbot added a comment.Apr 14 2025, 6:04 PM

Change #1136368 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@wmf/1.44.0-wmf.24] Complete our RecentChanges entry generation and formatting

https://gerrit.wikimedia.org/r/1136368

Stashbot added a comment.Apr 14 2025, 6:05 PM

Mentioned in SAL (#wikimedia-operations) [2025-04-14T18:05:04Z] <jforrester@deploy1003> Started scap sync-world: Backport for [[gerrit:1136368|Complete our RecentChanges entry generation and formatting (T386020)]], [[gerrit:1136379|Switch test Wikifunctions client deployment from test2wiki to test2iki (T391584)]], [[gerrit:1136380|Document Wikifunctions options, adding wgWikiLambdaClientModeOffline (T391584)]]

Stashbot added a comment.Apr 14 2025, 6:24 PM

Mentioned in SAL (#wikimedia-operations) [2025-04-14T18:24:37Z] <jforrester@deploy1003> jforrester: Backport for [[gerrit:1136368|Complete our RecentChanges entry generation and formatting (T386020)]], [[gerrit:1136379|Switch test Wikifunctions client deployment from test2wiki to test2iki (T391584)]], [[gerrit:1136380|Document Wikifunctions options, adding wgWikiLambdaClientModeOffline (T391584)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Maintenance_bot removed a project: Patch-For-Review.Apr 14 2025, 6:31 PM
Stashbot added a comment.Apr 14 2025, 6:37 PM

Mentioned in SAL (#wikimedia-operations) [2025-04-14T18:37:29Z] <jforrester@deploy1003> Finished scap sync-world: Backport for [[gerrit:1136368|Complete our RecentChanges entry generation and formatting (T386020)]], [[gerrit:1136379|Switch test Wikifunctions client deployment from test2wiki to test2iki (T391584)]], [[gerrit:1136380|Document Wikifunctions options, adding wgWikiLambdaClientModeOffline (T391584)]] (duration: 32m 25s)

ReleaseTaggerBot edited projects, added: MW-1.44-notes (1.44.0-wmf.24; 2025-04-08); removed: MW-1.44-notes (1.44.0-wmf.25; 2025-04-15).Apr 14 2025, 7:00 PM
Jdforrester-WMF closed this task as Resolved.Apr 15 2025, 8:17 PM
Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits