Page MenuHomePhabricator

Upgrade MW's bundled version of Pinia from 2.0.16 to 3.x
Closed, ResolvedPublic1 Estimated Story Points

Description

As a developer I want to use @pinia/testing for testing pinia in unit tests to make sure sure my code is stable

Problem:
MW uses Pinia 2.0.16 on production. But the current @pinia/testing@0.1.7 requires a peer pinia@">=2.2.6".
Pinia 2.3.1 is latest.

Proposed solution:
Is it by any chance possible to periodically update Pinia ? 🍍

Thank you!

See

Details

Related Changes in Gerrit:
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
releases: Add pinia @ 3.0.4 and @pinia/testing @ 1.0.3repos/ci-tools/libup-config!133jforresterT386086main
Customize query in GitLab

Event Timeline

CCiufo-WMF subscribed.

We'll discuss this at our next team meeting

CCiufo-WMF triaged this task as Medium priority.Feb 24 2025, 6:06 PM
CCiufo-WMF set the point value for this task to 1.
CCiufo-WMF moved this task from Needs Refinement to Up Next on the Design-System-Team board.
Jdforrester-WMF renamed this task from Upgrade Pinia in MW to Latest Version to Upgrade MW's bundled version of Pinia from 2.0.16 to 3.x.Jul 7 2025, 5:20 PM
Jdforrester-WMF updated the task description. (Show Details)
Catrope moved this task from Backlog to Upcoming on the Codex board.

Change #1303494 had a related patch set uploaded (by Dillon; author: Dillon):

[mediawiki/core@master] Upgrade bundled Pinia v2.0.16 to v3.0.4

https://gerrit.wikimedia.org/r/1303494

Dillon changed the task status from Open to In Progress.Jun 22 2026, 4:52 PM
Dillon moved this task from Upcoming to Code Review on the Codex board.

Change #1303494 merged by jenkins-bot:

[mediawiki/core@master] Upgrade bundled Pinia v2.0.16 to v3.0.4

https://gerrit.wikimedia.org/r/1303494

Should we configure LibUp to automatically upgrade extensions' test copies of pinia & @pinia/testing accordingly? I made 1303547 for WikiLambda but it could have been trivially done by a bot. Will other repos (pinia, @pinia/testing) be generally as trivial?

Should we configure LibUp to automatically upgrade extensions' test copies of pinia & @pinia/testing accordingly? I made 1303547 for WikiLambda but it could have been trivially done by a bot. Will other repos (pinia, @pinia/testing) be generally as trivial?

Yes, that would be helpful! Both pinia and @pinia/testing packages have little to no breaking changes, so it should be a straightforward upgrade. Although, I recommend pinning @pinia/testing to 1.0.3 instead of ^1.0.3 to align with MW core's package.json.

Change #1305929 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] ResourceLoader: Update wikimedia/minify to 2.11.0

https://gerrit.wikimedia.org/r/1305929

Change #1305929 merged by jenkins-bot:

[mediawiki/core@master] ResourceLoader: Update wikimedia/minify to 2.11.0

https://gerrit.wikimedia.org/r/1305929