Page MenuHomePhabricator

DeletePagesForGood uses a removed method OldLocalFile::selectFields()
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • On a test wiki from MW 1.31 to 1.43, activate the extension DeletePagesForGood
  • Upload a file, then try to "Delete page permanently"

What happens?:

  • There is an error:
    • on MediaWiki 1.31-1.33 (tested on MW 1.33 with extension in REL1_33 2dd3e22) the error displayed to the user is "Cannot use OldLocalFile::selectFields when $wgActorTableSchemaMigrationStage has SCHEMA_COMPAT_READ_NEW"
    • on MediaWiki 1.34-1.43 (tested on MW 1.39 with extension in REL1_39 5f13744): "Call to undefined method OldLocalFile::selectFields()"

What should have happened instead?:

No error, the file should be permanently deleted.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Any version of the extension DeletePagesForGood in its corresponding REL1_XX branch since MediaWiki 1.31. Effectively tested:

  • with MW 1.33 + DeletePagesForGood in REL1_33 2dd3e22,
  • with MW 1.39 + DeletePagesForGood in REL1_39 5f13744.

Other information (browser name/version, screenshots, etc.):

Event Timeline

I am preparing a patch, and this task is linked to T231752 for the "File" specificities.

Change #1118855 had a related patch set uploaded (by Seb35; author: Seb35):

[mediawiki/extensions/DeletePagesForGood@master] Maintenance for the file-related part

https://gerrit.wikimedia.org/r/1118855

Change #1118855 merged by jenkins-bot:

[mediawiki/extensions/DeletePagesForGood@master] Maintenance for the file-related part

https://gerrit.wikimedia.org/r/1118855

Change #1128415 had a related patch set uploaded (by Seb35; author: Seb35):

[mediawiki/extensions/DeletePagesForGood@REL1_43] Maintenance for the file-related part

https://gerrit.wikimedia.org/r/1128415

Change #1128416 had a related patch set uploaded (by Seb35; author: Seb35):

[mediawiki/extensions/DeletePagesForGood@REL1_42] Maintenance for the file-related part

https://gerrit.wikimedia.org/r/1128416

Change #1128416 merged by jenkins-bot:

[mediawiki/extensions/DeletePagesForGood@REL1_42] Maintenance for the file-related part

https://gerrit.wikimedia.org/r/1128416

Change #1128415 merged by jenkins-bot:

[mediawiki/extensions/DeletePagesForGood@REL1_43] Maintenance for the file-related part

https://gerrit.wikimedia.org/r/1128415

Change #1128436 had a related patch set uploaded (by Seb35; author: Seb35):

[mediawiki/extensions/DeletePagesForGood@REL1_39] Maintenance for the file-related part

https://gerrit.wikimedia.org/r/1128436

Change #1128436 merged by jenkins-bot:

[mediawiki/extensions/DeletePagesForGood@REL1_39] Maintenance for the file-related part

https://gerrit.wikimedia.org/r/1128436

Seb35 claimed this task.

Fixed on REL1_39, REL1_42, REL1_43, master (future REL1_44): pages in the namespace Image: can now be deleted (the associated file, its public file history, its MediaWiki-deleted file history, and its thumbnails are permanently deleted).