Page MenuHomePhabricator

Make sure CampaignEvents special pages look reasonably OK on Monobook and Timeless
Open, Needs TriagePublic

Assigned To
None
Authored By
Daimona
Feb 11 2025, 2:45 PM
Referenced Files
F58386392: image.png
Feb 11 2025, 3:34 PM
F58386383: image.png
Feb 11 2025, 3:34 PM
F58386374: image.png
Feb 11 2025, 3:34 PM
F58386366: image.png
Feb 11 2025, 3:34 PM
F58386360: image.png
Feb 11 2025, 3:34 PM
F58386348: image.png
Feb 11 2025, 3:34 PM
F58386336: image.png
Feb 11 2025, 3:34 PM
F58386303: image.png
Feb 11 2025, 3:34 PM
Subscribers

Description

While vector is the target and most thoroughly tested skin, it wouldn't hurt to make sure that the extension special pages look OK on other popular skins as well. For example, Special:AllEvents doesn't look right in MonoBook:

image.png (818×1 px, 93 KB)

Acceptance criteria

  • Make sure that all of the extension's special pages look reasonably well when using the MonoBook and Timeless skins

Event Timeline

I've audited all special pages looking for issues. Here's what I found, not including causes or solutions. Some of these might be upstream bugs.

Monobook

  • There's the issue reported in the task description, due to the icons getting a position: static that probably doesn't work with other rules. Might be a bug in the apex them itself.
  • The event page header is affected by the same bug:
    image.png (219×3 px, 37 KB)
  • Additionally, the "manage registration" menu displayed to participants shows weird truncation of its options. There's plenty of space on either side, so it's unclear why truncation is needed in the first place. Also wondering why all options are truncated to the same length; it looks odd here for the first item, where the ellipsis has the same length as the deleted "ion".
    image.png (300×419 px, 22 KB)
  • In Special:EnableEventRegistration, the "required" marker for the event page field is misplaced:
    image.png (188×1 px, 16 KB)
  • In Special:EventDetails, section icons are too dark and perhaps bigger than in vector:
    image.png (211×731 px, 22 KB)
  • In Special:InvitationList, the lists look quite packed. We really should stop trying to overwrite list styles as we're doing in several places, and just leave it up to the skin.
    image.png (678×348 px, 44 KB)

Timeless

  • In Special:AllEvents there's a colour issue with the tabs:
    image.png (232×621 px, 13 KB)
  • In the "more details" dialog, the section spacing looks off, and it's definitely off for the "location" sub-sections:
    image.png (1×700 px, 102 KB)
  • There also seems to be too much spacing between participants. Refer to my recommendation above that we just stop customizing lists.
    image.png (675×533 px, 45 KB)
  • The font size of the registration footer is too small (10.83px) and not accessible:
    image.png (691×985 px, 106 KB)
  • Section headers in Special:EventDetails are HUGE:
    image.png (444×2 px, 65 KB)
  • In Special:InvitationList, accordion titles aren't bolded. Unsure if this is intentional.
    image.png (177×1 px, 29 KB)

For the SpecialAllEvents one, and potentially other similar issues with icons, they might go away if we switch from OOUI to Codex. Which is something we'll need to do anyway for T385347.

MHorsey-WMF changed the status of subtask T388451: Convert TextWithIconWidget to Codex from In Progress to Stalled.