Page MenuHomePhabricator
Create Task
Maniphest T386108

Make PHP 8.4 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI
Closed, ResolvedPublic
Actions

Description

< T353362 for 8.3 | T411814 for 8.5 >

  • Non-blocking issues in production code (e.g., test skipped for now)
    • None yet!
  • General issues that only (now) affect code not in Wikimedia production (not blockers)
    • None yet!

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Feb 11 2025, 3:39 PM

Change #1118829 merged by jenkins-bot:

[integration/config@master] Zuul: Make PHP 8.4 voting on lib repos where it already passes

https://gerrit.wikimedia.org/r/1118829

Stashbot added a comment.Feb 11 2025, 3:43 PM

Mentioned in SAL (#wikimedia-releng) [2025-02-11T15:43:01Z] <James_F> Zuul: Make PHP 8.4 voting on lib repos where it already passes, for T386108

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Feb 11 2025, 4:14 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 11 2025, 4:30 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Feb 21 2025, 11:17 AM
Reedy moved this task from Backlog to Other on the PHP 8.4 support board.Feb 21 2025, 10:51 PM
Umherirrender subscribed.Feb 28 2025, 10:38 PM

Core would pass when T379587: PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs is fixed (most relevant are pear/net_url2 and thecodingmachine/safe)

gerritbot added a comment.Mar 4 2025, 12:59 AM

Change #1124212 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: Start testing in PHP 8.4 for 'mediawiki-php-library' repos

https://gerrit.wikimedia.org/r/1124212

gerritbot added a project: Patch-For-Review.Mar 4 2025, 12:59 AM
Jdforrester-WMF updated the task description. (Show Details)Mar 4 2025, 1:00 AM
gerritbot added a comment.Mar 4 2025, 1:03 AM

Change #1124212 merged by jenkins-bot:

[integration/config@master] Zuul: Start testing in PHP 8.4 for 'mediawiki-php-library' repos

https://gerrit.wikimedia.org/r/1124212

Stashbot added a comment.Mar 4 2025, 1:03 AM

Mentioned in SAL (#wikimedia-releng) [2025-03-04T01:03:35Z] <James_F> Zuul: Start testing in PHP 8.4 for 'mediawiki-php-library' repos, for T386108

Maintenance_bot removed a project: Patch-For-Review.Mar 4 2025, 1:30 AM
Jdforrester-WMF updated the task description. (Show Details)Mar 7 2025, 8:37 PM
Jdforrester-WMF mentioned this in T388273: Minify's dependency `pear/net_url2` triggers a PHPUnit test failure on PHP 8.4 in vendor.Mar 7 2025, 8:47 PM
Jdforrester-WMF updated the task description. (Show Details)Mar 7 2025, 8:57 PM
Jdforrester-WMF updated the task description. (Show Details)Mar 7 2025, 9:02 PM
Umherirrender unsubscribed.Mar 29 2025, 3:43 PM
Jdforrester-WMF mentioned this in T360995: Migrate Wikimedia production from PHP 8.1 to PHP 8.3.May 15 2025, 1:44 PM
Novem_Linguae subscribed.May 15 2025, 1:46 PM
Michael subscribed.May 15 2025, 1:57 PM
MSantos subscribed.May 15 2025, 3:02 PM
Krinkle updated the task description. (Show Details)Jun 12 2025, 6:03 PM
Krinkle updated the task description. (Show Details)Jun 17 2025, 3:50 PM
gerritbot added a comment.Jul 28 2025, 1:04 PM

Change #1173377 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [integration/docroot] Test in PHP 8.4, now passing

https://gerrit.wikimedia.org/r/1173377

gerritbot added a project: Patch-For-Review.Jul 28 2025, 1:04 PM
gerritbot added a comment.Jul 28 2025, 1:17 PM

Change #1173377 merged by jenkins-bot:

[integration/config@master] Zuul: [integration/docroot] Test in PHP 8.4, now passing

https://gerrit.wikimedia.org/r/1173377

gerritbot added a comment.Jul 28 2025, 1:27 PM

Change #1173392 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [labs/tools/guc] Test in PHP 8.4, now passing

https://gerrit.wikimedia.org/r/1173392

gerritbot added a comment.Jul 28 2025, 1:28 PM

Change #1173392 merged by jenkins-bot:

[integration/config@master] Zuul: [labs/tools/guc] Test in PHP 8.4, now passing

https://gerrit.wikimedia.org/r/1173392

gerritbot added a comment.Jul 28 2025, 1:30 PM

Change #1173393 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [labs/countervandalism/stillalive] Test in PHP 8.4, now passing

https://gerrit.wikimedia.org/r/1173393

gerritbot added a comment.Jul 28 2025, 1:33 PM

Change #1173393 merged by jenkins-bot:

[integration/config@master] Zuul: [labs/countervandalism/stillalive] Test in PHP 8.4, now passing

https://gerrit.wikimedia.org/r/1173393

gerritbot added a comment.Jul 28 2025, 1:33 PM

Change #1173395 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [labs/tools/wikiinfo] Test in PHP 8.4, now passing

https://gerrit.wikimedia.org/r/1173395

gerritbot added a comment.Jul 28 2025, 1:40 PM

Change #1173395 merged by jenkins-bot:

[integration/config@master] Zuul: [labs/tools/wikiinfo] Test in PHP 8.4, now passing

https://gerrit.wikimedia.org/r/1173395

Maintenance_bot removed a project: Patch-For-Review.Jul 28 2025, 2:31 PM
Jdforrester-WMF updated the task description. (Show Details)Aug 28 2025, 6:15 PM
Jdforrester-WMF updated the task description. (Show Details)Dec 4 2025, 7:25 PM
Jdforrester-WMF added a subtask: T409283: Parsoid fails on PHP 8.4+ during MW installation with 'Error: Class "Wikimedia\Parsoid\DOM\HTMLDocument" not found'.Dec 4 2025, 7:33 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF mentioned this in T411814: Make PHP 8.5 voting on development (master) branch of MW ecosystem (core, vendor, extensions, skins, libraries) in CI.Dec 4 2025, 7:43 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.Dec 4 2025, 7:46 PM

Change #1215247 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: [mediawiki/vendor] Start enforcing PHP 8.4 and 8.5 linting at least

https://gerrit.wikimedia.org/r/1215247

gerritbot added a project: Patch-For-Review.Dec 4 2025, 7:46 PM
gerritbot added a comment.Dec 4 2025, 8:03 PM

Change #1215247 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/vendor] Start enforcing PHP 8.4 and 8.5 linting at least

https://gerrit.wikimedia.org/r/1215247

Stashbot added a comment.Dec 4 2025, 8:04 PM

Mentioned in SAL (#wikimedia-releng) [2025-12-04T20:04:29Z] <James_F> Zuul: [mediawiki/vendor] Start enforcing PHP 8.4 and 8.5 linting at least, for T386108

Maintenance_bot removed a project: Patch-For-Review.Dec 4 2025, 8:31 PM
gerritbot added a comment.Dec 16 2025, 10:12 PM

Change #1218845 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/vendor@master] Upgrade pear/pear-core-minimal to v1.10.17

https://gerrit.wikimedia.org/r/1218845

gerritbot added a project: Patch-For-Review.Dec 16 2025, 10:12 PM
gerritbot added a comment.Dec 16 2025, 10:24 PM

Change #1218847 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/vendor@REL1_43] Upgrade pear/pear-core-minimal to v1.10.17

https://gerrit.wikimedia.org/r/1218847

gerritbot added a comment.Dec 16 2025, 10:25 PM

Change #1218848 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/vendor@REL1_44] Upgrade pear/pear-core-minimal to v1.10.17

https://gerrit.wikimedia.org/r/1218848

gerritbot added a comment.Dec 16 2025, 10:25 PM

Change #1218849 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/vendor@REL1_45] Upgrade pear/pear-core-minimal to v1.10.17

https://gerrit.wikimedia.org/r/1218849

gerritbot added a comment.Dec 16 2025, 11:10 PM

Change #1218845 merged by jenkins-bot:

[mediawiki/vendor@master] Upgrade pear/pear-core-minimal to v1.10.17

https://gerrit.wikimedia.org/r/1218845

gerritbot added a comment.Dec 16 2025, 11:18 PM

Change #1218849 merged by Reedy:

[mediawiki/vendor@REL1_45] Upgrade pear/pear-core-minimal to v1.10.17

https://gerrit.wikimedia.org/r/1218849

gerritbot added a comment.Dec 16 2025, 11:18 PM

Change #1218848 merged by Reedy:

[mediawiki/vendor@REL1_44] Upgrade pear/pear-core-minimal to v1.10.17

https://gerrit.wikimedia.org/r/1218848

gerritbot added a comment.Dec 16 2025, 11:19 PM

Change #1218847 merged by Reedy:

[mediawiki/vendor@REL1_43] Upgrade pear/pear-core-minimal to v1.10.17

https://gerrit.wikimedia.org/r/1218847

Maintenance_bot removed a project: Patch-For-Review.Dec 16 2025, 11:31 PM
Krinkle mentioned this in T413223: Migrate Wikimedia production from PHP 8.3 to PHP 8.5.Dec 19 2025, 3:05 PM
A_smart_kitten subscribed.Dec 29 2025, 4:37 PM
A_smart_kitten updated the task description. (Show Details)Dec 29 2025, 9:02 PM
Reedy closed subtask T409283: Parsoid fails on PHP 8.4+ during MW installation with 'Error: Class "Wikimedia\Parsoid\DOM\HTMLDocument" not found' as Resolved.Jan 7 2026, 7:47 PM
A_smart_kitten updated the task description. (Show Details)Jan 7 2026, 9:43 PM
Jdforrester-WMF updated the task description. (Show Details)Jan 8 2026, 4:28 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF added a comment.Jan 8 2026, 4:31 PM

T409283 isn't fixed until the patch is in a release that is pulled through, tested, and confirmed.

A_smart_kitten added a comment.Jan 8 2026, 4:40 PM

Ah, sorry - thank you for correcting me :)

Jdforrester-WMF added a comment.Jan 8 2026, 4:44 PM
In T386108#11504541, @A_smart_kitten wrote:

Ah, sorry - thank you for correcting me :)

Thanks for all your work! It's brilliant.

A_smart_kitten added a comment.Jan 13 2026, 2:09 PM

A PHP 8.4 check experimental build on the mediawiki/core change bumping Parsoid to 0.23.0-a11 has succeeded, so I guess PHP 8.4 CI now passes on MW Core (at least, on its own)?

Noting though that there is at least one WMF-deployed extension that has some of its tests fail for what seems to be a similar reason to T413573: CI failures on PHP 8.4 from some core tests that call Parsoid's `DOMCompat::querySelector` method (which I tagged against MW Core & Parsoid, and was fixed in MW Core). I left a comment re. Parsoid/PHP backwards-compatibility concerns @ T413573#11509656.

gerritbot added a comment.Jan 13 2026, 2:57 PM

Change #1226269 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] Zuul: Make quibble-for-mediawiki-core-vendor-mysql-php84 voting

https://gerrit.wikimedia.org/r/1226269

gerritbot added a project: Patch-For-Review.Jan 13 2026, 2:57 PM
Jdforrester-WMF updated the task description. (Show Details)Jan 13 2026, 3:02 PM
gerritbot added a comment.Jan 13 2026, 3:03 PM

Change #1226269 merged by jenkins-bot:

[integration/config@master] Zuul: Make quibble-for-mediawiki-core-vendor-mysql-php84 voting

https://gerrit.wikimedia.org/r/1226269

Stashbot added a comment.Jan 13 2026, 3:04 PM

Mentioned in SAL (#wikimedia-releng) [2026-01-13T15:04:58Z] <James_F> Zuul: Make quibble-for-mediawiki-core-vendor-mysql-php84 voting, for T386108

Maintenance_bot removed a project: Patch-For-Review.Jan 13 2026, 3:31 PM
Jdforrester-WMF reopened subtask T409283: Parsoid fails on PHP 8.4+ during MW installation with 'Error: Class "Wikimedia\Parsoid\DOM\HTMLDocument" not found' as Open.Jan 16 2026, 8:47 PM
Michael updated the task description. (Show Details)Jan 21 2026, 12:39 PM
A_smart_kitten updated the task description. (Show Details)Jan 24 2026, 3:33 PM
Krinkle added a parent task: T413223: Migrate Wikimedia production from PHP 8.3 to PHP 8.5.Jan 26 2026, 3:08 PM
Jdforrester-WMF created subtask T415955: Ensure that all Wikimedia-deployed code passes PHP 8.4 CI.Jan 29 2026, 9:29 PM
cscott closed subtask T409283: Parsoid fails on PHP 8.4+ during MW installation with 'Error: Class "Wikimedia\Parsoid\DOM\HTMLDocument" not found' as Resolved.Feb 16 2026, 2:04 AM
Jdforrester-WMF updated the task description. (Show Details)Feb 19 2026, 7:09 PM
gerritbot added a comment.Feb 20 2026, 2:28 PM

Change #1240989 had a related patch set uploaded (by Jforrester; author: Jforrester):

[integration/config@master] [DNM] Zuul: Enforce PHP 8.4 in MW extensions and skins for development branch

https://gerrit.wikimedia.org/r/1240989

gerritbot added a project: Patch-For-Review.Feb 20 2026, 2:28 PM
Jdforrester-WMF closed subtask T415955: Ensure that all Wikimedia-deployed code passes PHP 8.4 CI as Resolved.Mar 2 2026, 10:00 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.Mar 2 2026, 10:07 PM

Change #1240989 merged by jenkins-bot:

[integration/config@master] Zuul: Enforce PHP 8.4 in MW extensions and skins for development branch

https://gerrit.wikimedia.org/r/1240989

Jdforrester-WMF closed this task as Resolved.Mar 2 2026, 10:09 PM
Jdforrester-WMF claimed this task.
Stashbot added a comment.Mar 2 2026, 10:13 PM

Mentioned in SAL (#wikimedia-releng) [2026-03-02T22:13:40Z] <James_F> Zuul: Enforce PHP 8.4 in MW extensions and skins for development branch, for T386108

Maintenance_bot removed a project: Patch-For-Review.Mar 2 2026, 10:30 PM
hashar mentioned this in T418981: Various test failures in PHP 8.4 gate and submit job in Wikibase and PropertySuggester.Mar 4 2026, 9:57 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits