Page MenuHomePhabricator

Language selector popup not correctly centered
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
SBisson
Feb 11 2025, 6:16 PM
Referenced Files
F58921366: 2025-03-25_17-52-23.mp4.gif
Mar 26 2025, 1:03 AM
F58921364: 2025-03-25_18-01-06.mp4.gif
Mar 26 2025, 1:03 AM
F58921361: 2025-03-25_18-00-34.mp4.gif
Mar 26 2025, 1:03 AM
F58921357: 2025-03-25_17-59-05.mp4.gif
Mar 26 2025, 1:03 AM
F58613044: Kapture 2025-03-05 at 17.03.22.webm
Mar 5 2025, 4:09 PM
F58482374: 2025-02-24_16-47-37.png
Feb 25 2025, 12:53 AM
F58482370: 2025-02-24_16-47-27.png
Feb 25 2025, 12:53 AM
F58482364: 2025-02-24_16-46-38.png
Feb 25 2025, 12:53 AM

Description

For screen width between 640px and 1024px, the language selector popup is too wide or not correctly centered.

500px - fullscreen ✅640px - popup too wide ❌800px - popup not centered ❌1024 - popup centered ✅
localhost_8080_w_index.php_title=Special_ContentTranslation&unified-dashboard=true&filter-type=collections&filter-id=Sustainability&active-list=suggestions&from=es&to=en.png (1×1 px, 99 KB)
localhost_8080_w_index.php_title=Special_ContentTranslation&unified-dashboard=true&filter-type=collections&filter-id=Sustainability&active-list=suggestions&from=es&to=en (1).png (1×1 px, 215 KB)
localhost_8080_w_index.php_title=Special_ContentTranslation&unified-dashboard=true&filter-type=collections&filter-id=Sustainability&active-list=suggestions&from=es&to=en (2).png (1×1 px, 235 KB)
localhost_8080_w_index.php_title=Special_ContentTranslation&unified-dashboard=true&filter-type=collections&filter-id=Sustainability&active-list=suggestions&from=es&to=en (3).png (1×2 px, 255 KB)

Derived Requirement

  • The language selector popup in the Content Translation dashboard should be properly centered and responsive across different screen widths.
  • For screen widths between 640px and 1024px, the popup should not be too wide or misaligned.
  • The width and position of the popup should dynamically adjust based on the viewport size to maintain a consistent and centered display.
  • Ensure the issue does not affect fullscreen mode at 500px and 1024px, where the alignment is already correct.
Test Steps

Test Case 1: Verify Language Selector Popup Alignment Across Viewports

  1. Open the Content Translation dashboard.
  2. Click on the language selector to open the popup.
  3. ✅❓❌⬜ AC1: At 500px, confirm that the popup is correctly displayed in fullscreen mode.
  4. ✅❓❌⬜ AC2: At 640px, verify that the popup is not too wide and properly centered.
  5. ✅❓❌⬜ AC3: At 800px, verify that the popup is properly centered.
  6. ✅❓❌⬜ AC4: At 1024px, confirm that the popup is correctly displayed and centered.

QA Results - Test Wiki

Event Timeline

ngkountas triaged this task as High priority.
ngkountas moved this task from Backlog to In-progress on the LPL Hypothesis board.

Change #1119110 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] Unified dashboard: Fix language selector dialog position

https://gerrit.wikimedia.org/r/1119110

Change #1119110 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Unified dashboard: Fix language selector dialog position

https://gerrit.wikimedia.org/r/1119110

Change #1120157 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20250217

https://gerrit.wikimedia.org/r/1120157

Change #1120157 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20250217

https://gerrit.wikimedia.org/r/1120157

@ngkountas Language popups are displayed aligned and properly centered, as seen in the screenshots below. I will move this to sign-off. Thanks for all your work!

**Test Result - Test Wiki*

Status: ✅ PASS
Environment: Testwiki
OS: macOS Sonoma 15.3.1
Browser: Chrome 133
Device: MBA
Emulated Devices: Responsive View

Test Artifact(s):

https://test.wikipedia.org/w/index.php?title=Special:ContentTranslation&active-list=suggestions&from=en&to=it&filter-type=collections&filter-id=Sustainability

Test Steps

Test Case 1: Verify Language Selector Popup Alignment Across Viewports

  1. Open the Content Translation dashboard.
  2. Click on the language selector to open the popup.
  3. AC1: At 500px, confirm that the popup is correctly displayed in fullscreen mode.
DesktopMobile
2025-02-24_16-43-57.png (458×499 px, 31 KB)
2025-02-24_16-43-44.png (457×495 px, 26 KB)
  1. AC2: At 640px, verify that the popup is not too wide and properly centered.
DesktopMobile
2025-02-24_16-45-34.png (600×640 px, 85 KB)
2025-02-24_16-45-44.png (596×642 px, 75 KB)
  1. AC3: At 800px, verify that the popup is properly centered.
DesktopMobile
2025-02-24_16-46-50.png (753×794 px, 115 KB)
2025-02-24_16-46-38.png (755×792 px, 102 KB)
  1. AC4: At 1024px, confirm that the popup is correctly displayed and centered.
DesktopMobile
2025-02-24_16-47-27.png (979×1 px, 166 KB)
2025-02-24_16-47-37.png (979×1 px, 155 KB)
GMikesell-WMF updated Other Assignee, removed: GMikesell-WMF.
GMikesell-WMF moved this task from Needs QA to Design Signoff on the LPL Hypothesis board.
Pginer-WMF subscribed.

Accessing the unified dashboard on Albanian Wikipedia at tablet size (1024x768px) I noticed that the language selector is displayed differently in different contexts. Language selection at the suggestions list and the confirmation step shows as a dialog. However, the language selection in the new article step shows in full screen where it was expected to show centered, as in the other cases.

Change #1125115 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] Search for an article: Fix language selector dialog position

https://gerrit.wikimedia.org/r/1125115

Change #1125115 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Search for an article: Fix language selector dialog position

https://gerrit.wikimedia.org/r/1125115

Change #1128494 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 1.0.0+20250317

https://gerrit.wikimedia.org/r/1128494

Change #1128494 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 1.0.0+20250317

https://gerrit.wikimedia.org/r/1128494

Accessing the unified dashboard on Albanian Wikipedia at tablet size (1024x768px) I noticed that the language selector is displayed differently in different contexts. Language selection at the suggestions list and the confirmation step shows as a dialog. However, the language selection in the new article step shows in full screen where it was expected to show centered, as in the other cases.

Thanks for the catch @Pginer-WMF ! I was just basing it on the section of the screenshots but I should have known better than to check those areas too.

5006408001024
2025-03-25_17-59-05.mp4.gif (626×632 px, 843 KB)
2025-03-25_18-00-34.mp4.gif (752×682 px, 1 MB)
2025-03-25_18-01-06.mp4.gif (908×830 px, 1 MB)
2025-03-25_17-52-23.mp4.gif (936×882 px, 1 MB)