Page MenuHomePhabricator

Option to start a "New translation" should not be shown at the confirmation step when expanding a section
Closed, ResolvedPublic

Assigned To
Authored By
Pginer-WMF
Feb 12 2025, 11:40 AM
Referenced Files
F58931930: 2025-03-27_13-51-32.png
Mar 27 2025, 9:15 PM
F58931928: 2025-03-27_13-51-49.png
Mar 27 2025, 9:15 PM
F58931924: 2025-03-27_11-22-53.png
Mar 27 2025, 9:15 PM
F58931920: 2025-03-27_13-48-30.png
Mar 27 2025, 9:15 PM
F58931918: 2025-03-27_13-48-43.png
Mar 27 2025, 9:15 PM
F58931916: 2025-03-27_11-17-57.png
Mar 27 2025, 9:15 PM
F58931946: 2025-03-27_13-44-30.png
Mar 27 2025, 9:15 PM
F58931944: 2025-03-27_13-44-17.png
Mar 27 2025, 9:15 PM

Description

Currently in the Unified Dashboard on desktop, continuing an in-progress section translation shows the "New Translation" option that only makes sense when starting new articles.

This ticket proposes to adjust the Confirm step so that:

  • The "New translation" option does not show when translating a section with a section pre-selected.
  • The "New translation" is still shown when selecting an article to expand with a new section, but no section has been pre-selected.
  • The support to start a new article will remain as it is: the "New translation" options is not shown.

Note that the above applies to all the different entry points that lead to the confirmation step: start a new section translation, continuing an existing one, reaching the step through the url, etc.

Below, you can see a comparison of the current and propose stated. Notice the differences in the actions shown for each case:

Current status:

New articleExpand with sectionsNew pre-selected sectionContinuing a section translation
test.wikipedia.org_w_index.php_title=Special_ContentTranslation&from=en&to=ca&sourcesection=Building&page=Casa%20del%20Pavo&filter-type=automatic&filter-id=previous-edits&active-list=suggestions(Wiki Tablet) (1).png (768×1 px, 454 KB)
test.wikipedia.org_w_index.php_title=Special_ContentTranslation&from=en&to=ca&sourcesection=Building&page=Casa%20del%20Pavo&filter-type=automatic&filter-id=previous-edits&active-list=suggestions(Wiki Tablet).png (768×1 px, 468 KB)
test.wikipedia.org_w_index.php_title=Special_ContentTranslation&page=casa%20del%20Pavo&section=Building&from=en&to=es&sx=true&filter-type=automatic&filter-id=previous-edits&active-list=suggestions(Wiki Tablet).png (768×1 px, 463 KB)
test.wikipedia.org_wiki_Special_ContentTranslation(Wiki Tablet).png (768×1 px, 464 KB)

Proposal:

New article (remains the same)Expand with sections (remains the same)New pre-selected sectionContinuing a section translation
test.wikipedia.org_w_index.php_title=Special_ContentTranslation&from=en&to=ca&sourcesection=Building&page=Casa%20del%20Pavo&filter-type=automatic&filter-id=previous-edits&active-list=suggestions(Wiki Tablet) (1).png (768×1 px, 454 KB)
test.wikipedia.org_w_index.php_title=Special_ContentTranslation&from=en&to=ca&sourcesection=Building&page=Casa%20del%20Pavo&filter-type=automatic&filter-id=previous-edits&active-list=suggestions(Wiki Tablet).png (768×1 px, 468 KB)
test.wikipedia.org_w_index.php_title=Special_ContentTranslation&page=casa%20del%20Pavo&section=Building&from=en&to=es&sx=true&filter-type=automatic&filter-id=previous-edits&active-list=suggestions(Wiki Tablet) (1).png (768×1 px, 460 KB)
test.wikipedia.org_wiki_Special_ContentTranslation(Wiki Tablet) (1).png (768×1 px, 461 KB)

Note that the proposal only affects the cases where a particular section is already selected. In such case the relevant options are to translate it (with action to start or continuing it, depending on the case) or selecting a different section to translate. In this case, the option to start a new translation for the whole article is not relevant and we can remove it.

This issue was found when translating the "Building" section for the "Casa del Pavo" article from English to Catalan on the desktop site of Test Wikipedia (quick link ).

Steps:

  1. Start a translation for a section, add some text and return to dashboard.
  2. Continue the translation,
  3. Observe the "New translation" button in the Confirm step.

CurrentExpected
test.wikipedia.org_wiki_Special_ContentTranslation(Wiki Tablet).png (768×1 px, 464 KB)
test.wikipedia.org_wiki_Special_ContentTranslation(Wiki Tablet) (1).png (768×1 px, 461 KB)

Derived Requirement

Ensure that the "New translation" option is not displayed at the confirmation step when translating a section with a pre-selected section while maintaining its visibility when selecting an article to expand with a new section.

Test Steps

Test Case 1: Ensure "New translation" is not shown when translating a pre-selected section

  1. Start a section translation for an article (e.g., "Casa del Pavo") from English to Catalan.
  2. Add some text and return to the dashboard.
  3. Continue New pre-selected section.
  4. ✅❓❌⬜ AC1: Confirm that the "New translation" option is not displayed at the confirmation step.

Test Case 2: Ensure "New translation" is not shown when translating a Continuing a section translation

  1. Start a section translation for an article (e.g., "Casa del Pavo") from English to Catalan.
  2. Add some text and return to the dashboard.
  3. Continuing a section translation.
  4. ✅❓❌⬜ AC2: Confirm that the "New translation" option is not displayed at the confirmation step.

Test Case 3: Ensure "New translation" behavior remains unchanged for new article translations

  1. Start a new article translation using the Content Translation tool.
  2. Observe the confirmation step before starting the translation.
  3. ✅❓❌⬜ AC3: Confirm that the "New translation" option is not displayed, maintaining the current behavior.

Test Case 4: Ensure "New translation" behavior remains unchanged for Expand with sections

  1. Start a new article translation using the Content Translation tool.
  2. Observe the confirmation step Expand with sections.
  3. ✅❓❌⬜ AC4: Confirm that the "New translation" option is not displayed, maintaining the current behavior.

QA Results - Test Wiki

Event Timeline

ngkountas moved this task from Backlog to Prioritized on the LPL Hypothesis board.

Change #1119748 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/ContentTranslation@master] Confirm step: hide New Translation btn when continuing a section

https://gerrit.wikimedia.org/r/1119748

Change #1119748 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Confirm step: hide New Translation btn when continuing a section

https://gerrit.wikimedia.org/r/1119748

@SBisson For AC4, are the tablet and mobile supposed to have "New Translation" like Desktop?

UPDATE: T386187#10721752

Test Result - testwiki

Status: ✅ PASS
Environment: testwiki
OS: macOS Sequoia 15.4
Browser: Chrome 134
Device: MBA
Emulated Device: NA

Test Artifact(s):
https://test.wikipedia.org/w/index.php?title=Special:ContentTranslation&cx-dashboard=unified&filter-type=collections&filter-id=Climate&active-list=suggestions&from=en&to=es&page=Oceanic%20carbon%20cycle#/sx
https://test.wikipedia.org/w/index.php?title=Special:ContentTranslation&cx-dashboard=unified&filter-type=collections&filter-id=Climate&active-list=suggestions&from=en&to=es&page=Carbon%20cycle#/sx
https://test.wikipedia.org/w/index.php?title=Special:ContentTranslation&cx-dashboard=unified&filter-type=collections&filter-id=Climate&active-list=published&from=es&to=en&section=Primeros%20a%C3%B1os&page=Jessie%20Godderz#/sx
https://test.wikipedia.org/w/index.php?title=Special:ContentTranslation&cx-dashboard=unified&filter-type=collections&filter-id=Climate&active-list=published&from=en&to=it&section=Types%20of%20treatment%20plants&page=Wastewater%20treatment#/sx

Test Steps

Test Case 1: Ensure "New translation" is not shown when translating a pre-selected section

  1. Start a section translation for an article (e.g., "Casa del Pavo") from English to Catalan.
  2. Add some text and return to the dashboard.
  3. Continue New pre-selected section.
  4. AC1: Confirm that the "New translation" option is not displayed at the confirmation step.
TypeDesktopTabletMobile
New article (remains the same)
2025-03-27_11-19-13.png (686×1 px, 240 KB)
2025-03-27_13-43-17.png (936×1 px, 171 KB)
2025-03-27_13-42-46.png (986×1 px, 179 KB)

Test Case 2: Ensure "New translation" is not shown when translating a Continuing a section translation

  1. Start a section translation for an article (e.g., "Casa del Pavo") from English to Catalan.
  2. Add some text and return to the dashboard.
  3. Continuing a section translation.
  4. AC2: Confirm that the "New translation" option is not displayed at the confirmation step.
TypeDesktopTabletMobile
New pre-selected section
2025-03-27_11-20-43.png (662×1 px, 483 KB)
2025-03-27_13-44-17.png (924×1 px, 169 KB)
2025-03-27_13-44-30.png (986×1 px, 186 KB)

Test Case 3: Ensure "New translation" behavior remains unchanged for new article translations

  1. Start a new article translation using the Content Translation tool.
  2. Observe the confirmation step before starting the translation.
  3. AC3: Confirm that the "New translation" option is not displayed, maintaining the current behavior.
TypeDesktopTabletMobile
New article (remains the same)
2025-03-27_11-17-57.png (619×1 px, 204 KB)
2025-03-27_13-48-43.png (966×1 px, 144 KB)
2025-03-27_13-48-30.png (975×1 px, 159 KB)

Test Case 4: Ensure "New translation" behavior remains unchanged for Expand with sections

  1. Start a new article translation using the Content Translation tool.
  2. Observe the confirmation step Expand with sections.
  3. AC4: Confirm that the "New translation" option is not displayed, maintaining the current behavior.

UPDATE: T386187#10721752

Type✅Desktop❌Tablet❌Mobile
Expand with sections (remains the same)
2025-03-27_11-22-53.png (671×1 px, 365 KB)
2025-03-27_13-51-49.png (960×1 px, 236 KB)
2025-03-27_13-51-32.png (975×1 px, 249 KB)

@GMikesell-WMF About AC4, the "New translation" button can only be displayed on desktop. On tablet and mobile, translation is done section by section so the only valid action at this point is to select the section to translate.

@SBisson Got it! Thanks for the information. Ok I'll pass it and move it to sign-off. Thanks for all your work!

GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF moved this task from Needs QA to Design Signoff on the LPL Hypothesis board.

The "New translation" button is not showing where it was not supposed to. So moving to product sign-off.
However, I noticed a glitch in this same area, captured in T391468 in case it is relevant.

Tested and working as expected.