Page MenuHomePhabricator
Create Task
Maniphest T386215

1.44.0-wmf.20 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
hashar
Release Version
1.44.0-wmf.20
Release Date
Mar 10 2025, 12:00 AM

2025 week 11 1.44-wmf.20 Changes wmf/1.44.0-wmf.20

This MediaWiki Train Deployment is scheduled for the week of Monday, March 10th:

Monday March 10thTuesday, March 11thWednesday, March 12thThursday, March 13thFriday
Backports only.Branch wmf.20 and deploy to Group 0 Wikis.Deploy wmf.20 to Group 1 Wikis.Deploy wmf.20 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.20 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.44.0-wmf.19
Next: 1.44.0-wmf.21
Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
group2 to 1.44.0-wmf.20TrainBranchBotoperations/mediawiki-configmaster+348 -348
group1 to 1.44.0-wmf.20TrainBranchBotoperations/mediawiki-configmaster+560 -560
group0 to 1.44.0-wmf.20TrainBranchBotoperations/mediawiki-configmaster+139 -139
testwikis to 1.44.0-wmf.20TrainBranchBotoperations/mediawiki-configmaster+3 -3
Branch commit for wmf/1.44.0-wmf.20TrainBranchBotmediawiki/corewmf/1.44.0-wmf.20+1 K -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

• thcipriani created this task.Feb 12 2025, 3:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2025, 3:29 PM
• thcipriani assigned this task to jeena.Feb 13 2025, 10:10 PM
• thcipriani triaged this task as Medium priority.
• thcipriani updated Other Assignee, added: hashar.
• thcipriani set the point value for this task to 5.
• thcipriani added a project: Release-Engineering-Team (Priority Backlog 📥).
Jdlrobson-WMF mentioned this in T387364: Verify 1.44.0-wmf.20 deployment.Feb 26 2025, 4:34 PM
Reedy added a subtask: T388085: Upcoming production error: Error: Class "Title" not found.Mar 6 2025, 2:04 AM
Daimona closed subtask T388085: Upcoming production error: Error: Class "Title" not found as Resolved.Mar 6 2025, 3:57 PM
ABreault-WMF mentioned this in T388148: CTT tasks week of 2025-03-07.Mar 6 2025, 4:50 PM
Pppery subscribed.Mar 7 2025, 8:56 PM

Just a heads up: some time shortly after the group0 deploy I'm going to run my API bot to convert Flow boards to wikitext with history. This makes a lot of API calls to the Flow and LiquidThreads APIs which are not well-used normally, and has caused several production error tasks in the past (i.e T384627, T386596, T382922). So if you see a spike in Flow- or LQT-related errors, it's probably caused by that not a bug in the new MediaWiki version.

SecurityPatchBot added a subtask: T387691: CVE-2025-32069: Wikitext stored XSS on filepages due to dangerous WBMI serialization.Mar 8 2025, 12:51 AM
SecurityPatchBot mentioned this in T387691: CVE-2025-32069: Wikitext stored XSS on filepages due to dangerous WBMI serialization.
• Hokwelum subscribed.Mar 9 2025, 8:29 PM
Risky Patch! 🚂🔥
Jdlrobson-WMF added a subtask: T388467: TypeError: mtSuggestions.map is not a function.Mar 10 2025, 9:49 PM
Jdlrobson-WMF added a subtask: T388475: [regression, subtask] Table of contents dropdown icons overlapping with text.Mar 11 2025, 12:05 AM
gerritbot added a comment.Mar 11 2025, 2:08 AM

Change #1126207 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.44.0-wmf.20] Branch commit for wmf/1.44.0-wmf.20

https://gerrit.wikimedia.org/r/1126207

gerritbot added a project: Patch-For-Review.Mar 11 2025, 2:08 AM
gerritbot added a comment.Mar 11 2025, 2:19 AM

Change #1126207 merged by jenkins-bot:

[mediawiki/core@wmf/1.44.0-wmf.20] Branch commit for wmf/1.44.0-wmf.20

https://gerrit.wikimedia.org/r/1126207

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2025, 2:30 AM
Krinkle closed subtask T388475: [regression, subtask] Table of contents dropdown icons overlapping with text as Resolved.Mar 11 2025, 2:38 AM
gerritbot added a comment.Mar 11 2025, 3:02 AM

Change #1126208 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis to 1.44.0-wmf.20

https://gerrit.wikimedia.org/r/1126208

gerritbot added a project: Patch-For-Review.Mar 11 2025, 3:02 AM

Change #1126208 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis to 1.44.0-wmf.20

https://gerrit.wikimedia.org/r/1126208

Stashbot added a comment.Mar 11 2025, 3:03 AM

Mentioned in SAL (#wikimedia-operations) [2025-03-11T03:03:27Z] <mwpresync@deploy2002> Started scap sync-world: testwikis to 1.44.0-wmf.20 refs T386215

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2025, 3:31 AM
Stashbot added a comment.Mar 11 2025, 3:52 AM

Mentioned in SAL (#wikimedia-operations) [2025-03-11T03:52:41Z] <mwpresync@deploy2002> Finished scap sync-world: testwikis to 1.44.0-wmf.20 refs T386215 (duration: 49m 13s)

abi_ changed the status of subtask T388467: TypeError: mtSuggestions.map is not a function from Open to In Progress.Mar 11 2025, 4:04 AM
Jdforrester-WMF mentioned this in T388526: MediaViewer broken in wmf.20 due to LESS change: Less_Exception_Compiler: error evaluating function `floor` math functions take numbers as parameters index: 1191 in mmv.ui.metadataPanel.less.Mar 11 2025, 1:08 PM
Jdforrester-WMF reopened subtask T388475: [regression, subtask] Table of contents dropdown icons overlapping with text as Open.Mar 11 2025, 1:13 PM
Lucas_Werkmeister_WMDE removed a subtask: T387691: CVE-2025-32069: Wikitext stored XSS on filepages due to dangerous WBMI serialization.Mar 11 2025, 1:50 PM
• Nikerabbit closed subtask T388467: TypeError: mtSuggestions.map is not a function as Resolved.Mar 11 2025, 3:18 PM
Tgr subscribed.EditedMar 11 2025, 3:26 PM
In T386215#10616703, @Hokwelum wrote:
Risky Patch! 🚂🔥
  • Change: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1119720
  • Summary:
    • This impacts how mathematical expressions are interpreted in css, potentially breaking existing css code that depends on the previous behavior. We have updated all codes that rely on this to use parenthesis for division where applicable.

This has been reverted (in wmf.20 only). It changes how some LESS code is interpreted, needs LESS fixes in some extensions, those were done, but not all were included in wmf.20. (Caused T388475, T388526, would have caused at least one more issue.) Should be fine by next week.

Tgr closed subtask T388526: MediaViewer broken in wmf.20 due to LESS change: Less_Exception_Compiler: error evaluating function `floor` math functions take numbers as parameters index: 1191 in mmv.ui.metadataPanel.less as Resolved.Mar 11 2025, 3:29 PM
Jdlrobson-WMF removed a subtask: T388475: [regression, subtask] Table of contents dropdown icons overlapping with text.Mar 11 2025, 4:50 PM
gerritbot added a comment.Mar 11 2025, 6:11 PM

Change #1126621 had a related patch set uploaded (by TrainBranchBot; author: Jeena Huneidi):

[operations/mediawiki-config@master] group0 to 1.44.0-wmf.20

https://gerrit.wikimedia.org/r/1126621

gerritbot added a project: Patch-For-Review.Mar 11 2025, 6:11 PM

Change #1126621 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 to 1.44.0-wmf.20

https://gerrit.wikimedia.org/r/1126621

Stashbot added a comment.Mar 11 2025, 6:25 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-11T18:25:00Z] <jhuneidi@deploy2002> rebuilt and synchronized wikiversions files: group0 to 1.44.0-wmf.20 refs T386215

Pppery added a comment.EditedMar 11 2025, 6:30 PM
In T386215#10614636, @Pppery wrote:

Just a heads up: some time shortly after the group0 deploy I'm going to run my API bot to convert Flow boards to wikitext with history. This makes a lot of API calls to the Flow and LiquidThreads APIs which are not well-used normally, and has caused several production error tasks in the past (i.e T384627, T386596, T382922). So if you see a spike in Flow- or LQT-related errors, it's probably caused by that not a bug in the new MediaWiki version.

This is running now (as the flow-cleanup tool on Toolforge)

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2025, 6:31 PM
• thcipriani added a comment.Mar 11 2025, 6:55 PM
In T386215#10625723, @Pppery wrote:
In T386215#10614636, @Pppery wrote:

Just a heads up: some time shortly after the group0 deploy I'm going to run my API bot to convert Flow boards to wikitext with history. This makes a lot of API calls to the Flow and LiquidThreads APIs which are not well-used normally, and has caused several production error tasks in the past (i.e T384627, T386596, T382922). So if you see a spike in Flow- or LQT-related errors, it's probably caused by that not a bug in the new MediaWiki version.

This is running now (as the flow-cleanup tool on Toolforge)

Thanks for the heads up! Did notice the errors, moment of panic :)

Jdforrester-WMF mentioned this in T386216: 1.44.0-wmf.21 deployment blockers.Mar 12 2025, 1:39 PM
• thcipriani edited projects, added: Release-Engineering-Team (Doing 😎); removed: Release-Engineering-Team (Priority Backlog 📥).Mar 12 2025, 3:59 PM
gerritbot added a comment.Mar 12 2025, 6:08 PM

Change #1127106 had a related patch set uploaded (by TrainBranchBot; author: Jeena Huneidi):

[operations/mediawiki-config@master] group1 to 1.44.0-wmf.20

https://gerrit.wikimedia.org/r/1127106

gerritbot added a project: Patch-For-Review.Mar 12 2025, 6:08 PM

Change #1127106 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 to 1.44.0-wmf.20

https://gerrit.wikimedia.org/r/1127106

Stashbot added a comment.Mar 12 2025, 6:20 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-12T18:20:02Z] <jhuneidi@deploy2002> rebuilt and synchronized wikiversions files: group1 to 1.44.0-wmf.20 refs T386215

Maintenance_bot removed a project: Patch-For-Review.Mar 12 2025, 6:31 PM
SToyofuku-WMF added a subtask: T388722: Error: No class registered by that key: null.Mar 12 2025, 9:16 PM
DLynch removed a subtask: T388722: Error: No class registered by that key: null.Mar 13 2025, 2:50 PM
gerritbot added a comment.Mar 13 2025, 6:29 PM

Change #1127589 had a related patch set uploaded (by TrainBranchBot; author: Jeena Huneidi):

[operations/mediawiki-config@master] group2 to 1.44.0-wmf.20

https://gerrit.wikimedia.org/r/1127589

gerritbot added a project: Patch-For-Review.Mar 13 2025, 6:29 PM

Change #1127589 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 to 1.44.0-wmf.20

https://gerrit.wikimedia.org/r/1127589

Maintenance_bot removed a project: Patch-For-Review.Mar 13 2025, 6:31 PM
Stashbot added a comment.Mar 13 2025, 6:39 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-13T18:39:16Z] <jhuneidi@deploy2002> rebuilt and synchronized wikiversions files: group2 to 1.44.0-wmf.20 refs T386215

• thcipriani closed this task as Resolved.Mar 13 2025, 11:15 PM
Pppery mentioned this in T389384: Less_Exception_Compiler: error evaluating function `unit` The first argument to unit must be a number. Have you forgotten parenthesis? index: 153 in ext.echo.styles.badge.less on line 6, column 14| @size-icon: 14px;5| @font-s.Mar 19 2025, 3:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits