Page MenuHomePhabricator
Create Task
Maniphest T386222

1.44.0-wmf.27 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease
Actions

Details

Backup Train Conductor
hashar
Release Version
1.44.0-wmf.27
Release Date
Apr 28 2025, 12:00 AM

2025 week 18 1.44-wmf.27 Changes wmf/1.44.0-wmf.27

This MediaWiki Train Deployment is scheduled for the week of Monday, April 28th:

Monday April 28thTuesday, April 29thWednesday, April 30thThursday, May 1stFriday
Backports only.Branch wmf.27 and deploy to Group 0 Wikis.Deploy wmf.27 to Group 1 Wikis.Deploy wmf.27 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.27 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.44.0-wmf.26
Next: 1.44.0-wmf.28
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
group2 to 1.44.0-wmf.27operations/mediawiki-configmaster+348 -348
group1 to 1.44.0-wmf.27operations/mediawiki-configmaster+560 -560
group1 to 1.44.0-wmf.27operations/mediawiki-configmaster+560 -560
group0 to 1.44.0-wmf.27operations/mediawiki-configmaster+560 -560
group1 to 1.44.0-wmf.27operations/mediawiki-configmaster+560 -560
group0 to 1.44.0-wmf.27operations/mediawiki-configmaster+140 -140
testwikis to 1.44.0-wmf.27operations/mediawiki-configmaster+3 -3
Branch commit for wmf/1.44.0-wmf.27mediawiki/corewmf/1.44.0-wmf.27+1 K -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

thcipriani created this task.Feb 12 2025, 3:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2025, 3:29 PM
Jdforrester-WMF subscribed.Apr 16 2025, 6:29 PM

This should instead be 1.45.0-wmf.1, per https://www.mediawiki.org/wiki/MediaWiki_1.44/Roadmap / https://www.mediawiki.org/wiki/MediaWiki_1.45/Roadmap

thcipriani renamed this task from 1.44.0-wmf.27 deployment blockers to 1.45.0-wmf.1 deployment blockers.Apr 17 2025, 12:19 AM
thcipriani assigned this task to hashar.
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: dduvall.
thcipriani added projects: Essential-Work, Release-Engineering-Team (Priority Backlog 📥).
thcipriani changed Release Version from 1.44.0-wmf.27 to 1.45.0-wmf.1.
thcipriani set the point value for this task to 5.
hashar added a comment.Apr 17 2025, 5:34 PM

I think we have missed May 1st is an holiday: labor day :)

Jdforrester-WMF added a comment.Apr 17 2025, 5:50 PM
In T386222#10749404, @Jdforrester-WMF wrote:

This should instead be 1.45.0-wmf.1, per https://www.mediawiki.org/wiki/MediaWiki_1.44/Roadmap / https://www.mediawiki.org/wiki/MediaWiki_1.45/Roadmap

… and now back to wmf.27, and wmf.28 too, with the post-Hackathon branch being wmf.1.

thcipriani renamed this task from 1.45.0-wmf.1 deployment blockers to 1.44.0-wmf.27 deployment blockers.Apr 17 2025, 6:00 PM
thcipriani changed Release Version from 1.45.0-wmf.1 to 1.44.0-wmf.27.
Jdlrobson-WMF mentioned this in T392454: Verify 1.44.0-wmf.27 deployment (and 26).Apr 23 2025, 7:48 AM
SecurityPatchBot added a subtask: T386826: Placing unexpected data in MediaWiki:GrowthMentors.json causes internal errors.Apr 26 2025, 11:57 PM
SecurityPatchBot mentioned this in T386826: Placing unexpected data in MediaWiki:GrowthMentors.json causes internal errors.
Urbanecm_WMF subscribed.Apr 28 2025, 7:21 AM

Regarding the subtask and T386826#10771548: I'm confused by what @SecurityPatchBot wants and why it only complains about T386826. In any case, the patch for T386826 is already in master long enough, so it probably can be removed. I'm happy to do it, but I'd like to understand what I should do for the other two secpatches (which are also in master, but SecurityPatchBot doesn't complain about them).

@hashar, please let me know if my assistance is required here.

hashar added a comment.Apr 28 2025, 9:42 AM
In T386222#10771597, @Urbanecm_WMF wrote:

Regarding the subtask and T386826#10771548: I'm confused by what @SecurityPatchBot wants and why it only complains about T386826. In any case, the patch for T386826 is already in master long enough, so it probably can be removed. I'm happy to do it, but I'd like to understand what I should do for the other two secpatches (which are also in master, but SecurityPatchBot doesn't complain about them).

@hashar, please let me know if my assistance is required here.

We have sorted it out, the patches reported by SecurityPatchBot had all been merged and released in wmf.24, we simply forgot to drop them from the list of patches to apply and eventually one of them went to be in conflict with new code. It is all fine now. Thank you very much @Urbanecm_WMF to have investigated and flagged that :)

Urbanecm_WMF added a comment.Apr 28 2025, 9:48 AM
In T386222#10771886, @hashar wrote:

We have sorted it out, the patches reported by SecurityPatchBot had all been merged and released in wmf.24

Note they were merged and released much earlier (as far as I can see, in wmf.19). Anyway, glad it was solved.

taavi added a subtask: T392832: Unable to access the revision-deletion interface from Special:Log - an "Invalid target revision" error page is displayed.Apr 28 2025, 4:16 PM
cscott mentioned this in T392840: CTT tasks week of 2025-04-25.Apr 28 2025, 5:52 PM
matmarex closed subtask T392832: Unable to access the revision-deletion interface from Special:Log - an "Invalid target revision" error page is displayed as Resolved.Apr 28 2025, 10:12 PM
gerritbot added a comment.Apr 29 2025, 1:09 AM

Change #1139578 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.44.0-wmf.27] Branch commit for wmf/1.44.0-wmf.27

https://gerrit.wikimedia.org/r/1139578

gerritbot added a project: Patch-For-Review.Apr 29 2025, 1:09 AM
gerritbot added a comment.Apr 29 2025, 1:22 AM

Change #1139578 merged by jenkins-bot:

[mediawiki/core@wmf/1.44.0-wmf.27] Branch commit for wmf/1.44.0-wmf.27

https://gerrit.wikimedia.org/r/1139578

Maintenance_bot removed a project: Patch-For-Review.Apr 29 2025, 1:30 AM
gerritbot added a comment.Apr 29 2025, 3:01 AM

Change #1139583 had a related patch set uploaded (by TrainBranchBot; author: MediaWiki PreSync):

[operations/mediawiki-config@master] testwikis to 1.44.0-wmf.27

https://gerrit.wikimedia.org/r/1139583

gerritbot added a project: Patch-For-Review.Apr 29 2025, 3:01 AM

Change #1139583 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis to 1.44.0-wmf.27

https://gerrit.wikimedia.org/r/1139583

Stashbot added a comment.Apr 29 2025, 3:03 AM

Mentioned in SAL (#wikimedia-operations) [2025-04-29T03:03:00Z] <mwpresync@deploy1003> Started scap sync-world: testwikis to 1.44.0-wmf.27 refs T386222

Maintenance_bot removed a project: Patch-For-Review.Apr 29 2025, 3:30 AM
Stashbot added a comment.Apr 29 2025, 4:04 AM

Mentioned in SAL (#wikimedia-operations) [2025-04-29T04:04:24Z] <mwpresync@deploy1003> Finished scap sync-world: testwikis to 1.44.0-wmf.27 refs T386222 (duration: 61m 23s)

gerritbot added a comment.Apr 29 2025, 8:01 AM

Change #1139780 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] group0 to 1.44.0-wmf.27

https://gerrit.wikimedia.org/r/1139780

gerritbot added a project: Patch-For-Review.Apr 29 2025, 8:01 AM

Change #1139780 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 to 1.44.0-wmf.27

https://gerrit.wikimedia.org/r/1139780

Stashbot added a comment.Apr 29 2025, 8:17 AM

Mentioned in SAL (#wikimedia-operations) [2025-04-29T08:17:29Z] <hashar@deploy1003> rebuilt and synchronized wikiversions files: group0 to 1.44.0-wmf.27 refs T386222

Maintenance_bot removed a project: Patch-For-Review.Apr 29 2025, 8:30 AM
gerritbot added a comment.Apr 30 2025, 8:04 AM

Change #1140122 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] group1 to 1.44.0-wmf.27

https://gerrit.wikimedia.org/r/1140122

gerritbot added a project: Patch-For-Review.Apr 30 2025, 8:04 AM

Change #1140122 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 to 1.44.0-wmf.27

https://gerrit.wikimedia.org/r/1140122

Stashbot added a comment.Apr 30 2025, 8:17 AM

Mentioned in SAL (#wikimedia-operations) [2025-04-30T08:17:57Z] <hashar@deploy1003> rebuilt and synchronized wikiversions files: group1 to 1.44.0-wmf.27 refs T386222

gerritbot added a comment.Apr 30 2025, 8:21 AM

Change #1140126 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] group0 to 1.44.0-wmf.27

https://gerrit.wikimedia.org/r/1140126

gerritbot added a comment.Apr 30 2025, 8:22 AM

Change #1140126 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 to 1.44.0-wmf.27

https://gerrit.wikimedia.org/r/1140126

hashar mentioned this in T392988: TypeError: MediaWiki\Mail\RecentChangeMailComposer::__construct(): Argument #6 ($timestamp) must be of type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.25/includes/mail/EmailNotification.php on line 222.Apr 30 2025, 8:26 AM
hashar added a subtask: T392988: TypeError: MediaWiki\Mail\RecentChangeMailComposer::__construct(): Argument #6 ($timestamp) must be of type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.25/includes/mail/EmailNotification.php on line 222.
Stashbot added a comment.Apr 30 2025, 8:29 AM

Mentioned in SAL (#wikimedia-operations) [2025-04-30T08:29:57Z] <hashar> Rolled back MediaWiki train from group 1 to group 0 due to T392988 # T386222

Maintenance_bot removed a project: Patch-For-Review.Apr 30 2025, 8:31 AM
Stashbot added a comment.Apr 30 2025, 8:35 AM

Mentioned in SAL (#wikimedia-operations) [2025-04-30T08:35:24Z] <hashar@deploy1003> rebuilt and synchronized wikiversions files: group0 to 1.44.0-wmf.27 refs T386222

gerritbot added a comment.Apr 30 2025, 4:43 PM

Change #1140206 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] group1 to 1.44.0-wmf.27

https://gerrit.wikimedia.org/r/1140206

gerritbot added a project: Patch-For-Review.Apr 30 2025, 4:43 PM
gerritbot added a comment.Apr 30 2025, 4:46 PM

Change #1140206 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 to 1.44.0-wmf.27

https://gerrit.wikimedia.org/r/1140206

hashar added a subtask: T393034: Investigate out of date refs following gerrit switchover.Apr 30 2025, 5:13 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 30 2025, 5:31 PM
matmarex closed subtask T392988: TypeError: MediaWiki\Mail\RecentChangeMailComposer::__construct(): Argument #6 ($timestamp) must be of type string, null given, called in /srv/mediawiki/php-1.44.0-wmf.25/includes/mail/EmailNotification.php on line 222 as Resolved.May 1 2025, 11:25 AM
thcipriani reassigned this task from hashar to dduvall.May 1 2025, 12:50 PM
thcipriani updated Other Assignee, added: hashar; removed: dduvall.
thcipriani added subscribers: dduvall, hashar.

Reassigning to @dduvall for the hand-off today as @hashar is out for May day.

T393034 meant that we never rolled to group1 yesterday (despite the patch on this task saying otherwise—we had to abandon that patch server-side because it was made on top of an impossible state, long story :)), anyway: group1 is where to start today! Thanks @dduvall

thcipriani removed a subtask: T393034: Investigate out of date refs following gerrit switchover.May 1 2025, 5:02 PM
gerritbot added a comment.May 1 2025, 6:12 PM

Change #1140524 had a related patch set uploaded (by TrainBranchBot; author: Dduvall):

[operations/mediawiki-config@master] group1 to 1.44.0-wmf.27

https://gerrit.wikimedia.org/r/1140524

gerritbot added a project: Patch-For-Review.May 1 2025, 6:12 PM

Change #1140524 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 to 1.44.0-wmf.27

https://gerrit.wikimedia.org/r/1140524

Stashbot added a comment.May 1 2025, 6:24 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-01T18:24:44Z] <dduvall@deploy1003> rebuilt and synchronized wikiversions files: group1 to 1.44.0-wmf.27 refs T386222

Maintenance_bot removed a project: Patch-For-Review.May 1 2025, 6:30 PM
gerritbot added a comment.May 1 2025, 6:49 PM

Change #1140527 had a related patch set uploaded (by TrainBranchBot; author: Dduvall):

[operations/mediawiki-config@master] group2 to 1.44.0-wmf.27

https://gerrit.wikimedia.org/r/1140527

gerritbot added a project: Patch-For-Review.May 1 2025, 6:49 PM

Change #1140527 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 to 1.44.0-wmf.27

https://gerrit.wikimedia.org/r/1140527

Stashbot added a comment.May 1 2025, 7:09 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-01T19:09:47Z] <dduvall> deployment of mw-jobrunner-main for codfw failed during scap train (group2) (T386222)

Maintenance_bot removed a project: Patch-For-Review.May 1 2025, 7:30 PM
Stashbot added a comment.May 1 2025, 7:33 PM

Mentioned in SAL (#wikimedia-operations) [2025-05-01T19:33:27Z] <dduvall> re-ran scap sync to fix mw-jobrunner codfw deployments following failed helmfile apply and verified correct image ref manually (T386222)

thcipriani closed this task as Resolved.May 2 2025, 12:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits