Page MenuHomePhabricator
Create Task
Maniphest T386227

Don't treat pre-defined Types (like Z80) as having built-in converters unless we actually have them (like Z6)
Open, MediumPublic
Actions

Description

Description

Z80 is now going to be modified like a regular type. It should be removed from all of the shortcutting behavior in the backend.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • Z80 is treated as a non-built-in
  • nastyhax (all relevant changes should be marked as such)

Remove all the non-applicable tags from the "Tags" field, leave only the tags of the projects/repositories related to this task

Completion checklist

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update function-schemata sub-module to HEAD (a6def55)mediawiki/extensions/WikiLambdamaster+1 -1
wikifunctions: Update evaluators from 2025-02-11-155338 to 2025-02-19-135838operations/deployment-chartsmaster+2 -2
wikifunctions: Upgrade orchestrator from 2025-02-03-215824 to 2025-02-12-171406operations/deployment-chartsmaster+1 -1
Customize query in gerrit
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Update function-schemata sub-module to HEAD (12fce6f)repos/abstract-wiki/wikifunctions/function-evaluator!314jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (12fce6f)repos/abstract-wiki/wikifunctions/wikilambda-cli!62jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (12fce6f)repos/abstract-wiki/wikifunctions/function-orchestrator!284apinesync-function-schematamain
Cease to treat Z80 and Z86 as built-in types.repos/abstract-wiki/wikifunctions/function-schemata!193apineapine-nasty-haxmain
Customize query in GitLab

Related Objects

Event Timeline

cmassaro created this task.Feb 12 2025, 4:08 PM
Jdforrester-WMF renamed this task from Make a nastyhax to treat Z80 as a non-built-in type to Don't treat pre-defined Types (like Z80) as having built-in converters unless we actually have them (like Z6).Feb 12 2025, 4:15 PM
CodeReviewBot added a comment.Feb 12 2025, 4:16 PM

apine updated https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/193

Cease to treat Z80 as a built-in type.

cmassaro claimed this task.Feb 12 2025, 4:17 PM
CodeReviewBot added a comment.Feb 12 2025, 4:58 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/193

Cease to treat Z80 and Z86 as built-in types.

CodeReviewBot added a project: Patch-For-Review.Feb 12 2025, 5:00 PM

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/284

Update function-schemata sub-module to HEAD (70bde71)

CodeReviewBot added a comment.Feb 12 2025, 5:07 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/62

Update function-schemata sub-module to HEAD (12fce6f)

CodeReviewBot added a comment.Feb 12 2025, 5:13 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/284

Update function-schemata sub-module to HEAD (12fce6f)

CodeReviewBot added a comment.Feb 12 2025, 5:17 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/62

Update function-schemata sub-module to HEAD (12fce6f)

gerritbot added a comment.Feb 12 2025, 5:27 PM

Change #1119191 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-02-03-215824 to 2025-02-12-171406

https://gerrit.wikimedia.org/r/1119191

CodeReviewBot added a comment.Feb 12 2025, 5:30 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/314

Update function-schemata sub-module to HEAD (12fce6f)

Jdforrester-WMF added a project: Abstract Wikipedia Fix-It tasks.Feb 12 2025, 6:09 PM
Jdforrester-WMF subscribed.

The above "just" fixes things ad hoc, properly doing this is left for later work.

Jdforrester-WMF triaged this task as Medium priority.Feb 12 2025, 6:09 PM
Jdforrester-WMF moved this task from To Triage to Engineering Backlog on the Abstract Wikipedia team board.
gerritbot added a comment.Feb 12 2025, 10:03 PM

Change #1119191 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2025-02-03-215824 to 2025-02-12-171406

https://gerrit.wikimedia.org/r/1119191

CodeReviewBot added a comment.Feb 12 2025, 10:12 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/314

Update function-schemata sub-module to HEAD (12fce6f)

gerritbot added a comment.Feb 19 2025, 3:03 PM

Change #1120992 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Update evaluators from 2025-02-11-155338 to 2025-02-19-135838

https://gerrit.wikimedia.org/r/1120992

gerritbot added a comment.Feb 19 2025, 3:19 PM

Change #1120992 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Update evaluators from 2025-02-11-155338 to 2025-02-19-135838

https://gerrit.wikimedia.org/r/1120992

gerritbot added a comment.Mar 6 2025, 4:20 PM

Change #1125186 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (a6def55)

https://gerrit.wikimedia.org/r/1125186

gerritbot added a comment.Mar 6 2025, 10:52 PM

Change #1125186 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (a6def55)

https://gerrit.wikimedia.org/r/1125186

cmassaro removed cmassaro as the assignee of this task.Mar 17 2025, 9:30 PM
cmassaro mentioned this in rMSFEaa06b90caa35: Update function-schemata sub-module to HEAD (12fce6f).Oct 3 2025, 9:43 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits