Design questions:

• Where/how to allow search filter for event type?

Desired behavior for filtering:

• User should be able to search for multiple event type at the same time (for example, search for editing events and photo upload events). This means it can probably work similarly to how people add wikis or topics to filter for in the Collaboration List.
• Filters works as an OR rather than AND

The 'Event type' filter will be located in a second, new row. We'll also be moving the 'Meeting type' filter to that same new row, since the two align logically.

That means that we are giving full width to the keyword search field. Mockup below:

Moving this to Dev input — are there any technical or general constraints/risks that come to mind? Is this a disruptive change (since we are changing the current layout and re-arranging rows)?

Notes from team meeting on May 12:

• Engineers said the design is doable. The full length change for keyword field will take a bit of extra work, but nothing major.
• Team agrees that it makes sense, conceptually, to put event type + participation options together
• Next steps are for Ilana and Julieta to finalize this ticket, so it can be estimated and added to sprint board

Moving this to Ready for Development. The filtering for event types will be an OR, and the user can include "Other" when filtering as well, which means that all options can be selected together.

Change #1151732 had a related patch set uploaded (by Mhorsey; author: Mhorsey):

[mediawiki/extensions/CampaignEvents@master] Add event types filter to collaboration list

https://gerrit.wikimedia.org/r/1151732

Question: is it intentional that the field is labelled "Event type" and not "Event types"?

@Daimona, I didn't deeply think about it when I wrote out "Event type" rather than "Event types" (and good catch, btw!), but I think I unconsciously did choose "type" because we ideally want to encourage people to pick one type, whenever possible. Some events are truly 2 types -- and that's fine -- but we imagine some events are really one type, and in those cases, accuracy and specificity is the way to go. This contrasts with event topics, since topics can especially overlap and cover a larger conceptual area. With all that being said, we *do* allow for more than 1 type, so perhaps we can change it to "Event types," since it may be confusing if we state it as singular and then allow the selection of 2.

Shall I change the AC, or should the change be made in a separate ticket?

In T386275#10881980, @ifried wrote:

@Daimona, I didn't deeply think about it when I wrote out "Event type" rather than "Event types" (and good catch, btw!), but I think I unconsciously did choose "type" because we ideally want to encourage people to pick one type, whenever possible.

I didn't point this out above, but the AC for this task (and the other ones too) are from before we decided how many topics we would allow, with 1 still being a potential option ;) It also came up in T386273#10866084 (4th bullet), so I wanted to make sure we stay consistent.

With all that being said, we *do* allow for more than 1 type, so perhaps we can change it to "Event types," since it may be confusing if we state it as singular and then allow the selection of 2.

I think singular wouldn't be too bad, it still makes sense to me. But ultimately, what matters is that it is a conscious decision.

Shall I change the AC, or should the change be made in a separate ticket?

I'd rather have the correct version of the message from the get go.

Also, note I had the same question in T386277#10869733, T386279#10869736 and (more implicitly) T386278#10869745.

Okay, thanks, @Daimona, and apologies for the delay on this.

I've thought about this, and there are good arguments to keep it singular ("type") and plural ("types"). But a decision needs to be made - so, I have decided that we should use "Event types" (plural). This is because a) we already use the plural for other options with multiple selections in the UI (e.g., wikis, topics), so this is more consistent, and b) we want to be clear that multiple options are possible, in order to reduce confusion.

I will update the AC of relevant tickets accordingly.

Change #1151732 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Add event types filter to collaboration list

https://gerrit.wikimedia.org/r/1151732

• Given that a user is on the Collaboration List,
  • ✅ And they should be able to apply search filters to find the event types of an event
  • We can have a maximum number of 20 event types applied as search filters QA note - there are currently less than 20 event types to choose from
    
• ✅ Placeholder text: "Add event types..."
  
• ✅ Label text: "Event types"
  
• ✅ The filtering for event types will be an OR, and the user can include "Other" when filtering as well, which means that all options can be selected together.
• ✅ Add a feature flag
  • $wgCampaignEventsEnableEventTypes = true;

Filtering working as expected and AC met, sending to design sign off

looks good to me, sending to product sign off