Page MenuHomePhabricator

Genfixes do not handle {{coord}} per [[MOS:ORDER]]
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Load [[Bamban Bridge]] with genfixes

What happens?:

  • AWB moves {{coord}} from immediately above the infobox to immediately below the infobox

What should have happened instead?:

  • Per [[Template:Coord/doc]], move {{coord}} to the bottom of the article in the 'end matter', after any navigation templates, but before all categories, including the {{DEFAULTSORT}} template.

Software version
AWB 6.3.2.1 SVN 12863

Event Timeline

@GoingBatty OK, I don't really see this as a bug then - the template has been added to the wrong section, and AWB moves it down the section.

So to move to the correct section: {{coord}} documentation says last section before defaultsort. But it also says {{coord}} may be in an infobox. So sounds like we can only move {{coord}} when not inside another template?

Last section: if there are multiple general templates e.g. commons cat in the last section, there aren't rules as to how to sort all of those.

So my suggestion would be that we could potentially move {{coord}} to the last section, but at the top of it. However, even then, if the last level 2 heading then has level 3 headings (some articles have references the split into bibliography, secondary sources etc.), then I'm not clear where the template should go.

What do you think then? I don't want to make a change that then opens up another 10 bugs for further scenarios within the last section, when we only currently deal with DEFAULTSORT and cats.

Simpler thought: maybe if we need to move {{coord}} we should move to end of article, before the defaultsort/category sorting applies, then allow that sorting to move it above defaultsort/category. Would at least be simple.

@Rjwilmsi - I debated whether to create this as a bug request or feature request, but decided to open a bug request because AWB moves {{coord}} a little bit.
I agree with simpler thought to move {{cord}} before the defaultsort/category sorting applies, then allow that sorting to move it above defaultsort/category.
Thank you!

Rjwilmsi claimed this task.

rev 12888: MetaDataSorter: move standalone {{coord}} to end of article text, then sort it to above DEFAULTSORT/cats if present.

Constraints: not templates nested in another e.g. in infoxbox. Can't move templates if a mixture of non-nested and nested.

@Rjwilmsi - Should {{WikidataCoord}} be moved with the same logic as {{Coord}} ? (see [[1982 Hama massacre]])

@GoingBatty I don't know, the template documentation for {{WikidataCoord}} doesn't seem to mention placement. Do you want AWB to treat it the same as {{Coord}}?

@Rjwilmsi - Rev 12888 doesn't seem to work in [[Consulate General of Russia, Isfahan]] with AWB 6.4.0.0 SVN 12927.

rev 12936 further changes to {{coord}} moving to support scenario of standalone {{coord}} template, and another one nested in an infobox