Error: Call to a member function isTemp() on null
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Aklapper
	Feb 13 2025, 9:55 AM

Description

Error

service.version: 1.44.0-wmf.16
trace.id: b7f6e885-4a68-423c-831a-bc9e1bea4199
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   Error: Call to a member function isTemp() on null

Frame	Location	Call
from	/srv/mediawiki/php-1.44.0-wmf.16/extensions/PageTriage/includes/Api/ApiPageTriageList.php(114)
#0	/srv/mediawiki/php-1.44.0-wmf.16/includes/api/ApiMain.php(2011)	MediaWiki\Extension\PageTriage\Api\ApiPageTriageList->execute()
#1	/srv/mediawiki/php-1.44.0-wmf.16/includes/api/ApiMain.php(946)	MediaWiki\Api\ApiMain->executeAction()
#2	/srv/mediawiki/php-1.44.0-wmf.16/includes/api/ApiMain.php(917)	MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#3	/srv/mediawiki/php-1.44.0-wmf.16/includes/api/ApiEntryPoint.php(152)	MediaWiki\Api\ApiMain->execute()
#4	/srv/mediawiki/php-1.44.0-wmf.16/includes/MediaWikiEntryPoint.php(202)	MediaWiki\Api\ApiEntryPoint->execute()
#5	/srv/mediawiki/php-1.44.0-wmf.16/api.php(44)	MediaWiki\MediaWikiEntryPoint->run()
#6	/srv/mediawiki/w/api.php(3)	require(string)
#7	{main}

Impact

High, 21 occurrences on enwiki, testwiki so far, and quickly going up.

Notes

First appearance on Feb 12, 2025 @ 17:57:10.682
Regression from https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/PageTriage/+/1009841144c6d5f755b65445467dd8c2216a18cd%5E%21/ introduced in T381653

Details

MediaWiki Version: 1.44.0-wmf.16
Request URL: https://en.wikipedia.org/w/api.php?action=pagetriagelist&afcDir=*&afc_state=*&dir=*&format=*&limit=*&namespace=*&offset=*&pageoffset=*&showreviewed=*&showunreviewed=*

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	ApiPageTriageList: Check that $user is defined before using it	mediawiki/extensions/PageTriage	wmf/1.44.0-wmf.16	+1 -1
	ApiPageTriageList: Check that $user is defined before using it	mediawiki/extensions/PageTriage	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T382367: 1.44.0-wmf.16 deployment blockers
Mentioned Here: T381653: PageTriage should use temporary accounts username styling

Event Timeline

Aklapper created this task.Feb 13 2025, 9:55 AM

Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptFeb 13 2025, 9:55 AM

Aklapper triaged this task as Unbreak Now! priority.Feb 13 2025, 9:59 AM

Aklapper updated the task description. (Show Details)

Aklapper added a project: Temporary accounts.

Aklapper added subscribers: Kgraessle, Samwalton9-WMF.

Restricted Application added a project: Trust and Safety Product Team. · View Herald TranscriptFeb 13 2025, 9:59 AM

Aklapper mentioned this in T382367: 1.44.0-wmf.16 deployment blockers.Feb 13 2025, 10:00 AM

Change #1119468 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/PageTriage@master] ApiPageTriageList: Check that $user is defined before using it

https://gerrit.wikimedia.org/r/1119468

gerritbot added a project: Patch-For-Review.Feb 13 2025, 10:03 AM

Change #1119471 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/PageTriage@wmf/1.44.0-wmf.16] ApiPageTriageList: Check that $user is defined before using it

https://gerrit.wikimedia.org/r/1119471

Change #1119468 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] ApiPageTriageList: Check that $user is defined before using it

https://gerrit.wikimedia.org/r/1119468

Change #1119471 merged by Aklapper:

[mediawiki/extensions/PageTriage@wmf/1.44.0-wmf.16] ApiPageTriageList: Check that $user is defined before using it

https://gerrit.wikimedia.org/r/1119471

kostajh claimed this task.Feb 13 2025, 10:37 AM

Mentioned in SAL (#wikimedia-operations) [2025-02-13T10:38:25Z] <aklapper@deploy2002> Started scap sync-world: Backport for [[gerrit:1119471|ApiPageTriageList: Check that $user is defined before using it (T386332)]]

Mentioned in SAL (#wikimedia-operations) [2025-02-13T10:41:04Z] <aklapper@deploy2002> kharlan, aklapper: Backport for [[gerrit:1119471|ApiPageTriageList: Check that $user is defined before using it (T386332)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2025-02-13T10:49:12Z] <aklapper@deploy2002> Finished scap sync-world: Backport for [[gerrit:1119471|ApiPageTriageList: Check that $user is defined before using it (T386332)]] (duration: 10m 47s)

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.16; 2025-02-11).Feb 13 2025, 11:00 AM

• Agusbou2015 subscribed.Feb 13 2025, 11:01 AM