Page MenuHomePhabricator

IP reveal guidance dialog: Allow user to proceed to next step if "Save preference" button press results in an error
Closed, ResolvedPublic1 Estimated Story Points

Description

Summary

The IP reveal guidance dialog prevents the user proceeding to another step if the IP Info use agreement preference is not updated on the server. However, we should not prevent moving to another step if the preference failed to save when the user pressed "Save preference".

Background

  • The IP reveal guidance dialog has a second step that is only shown if IP Info is loaded.
  • This step allows the user to set the IPInfo use agreement preference in the dialog
    • When this preference checkbox is checked but the new value is not saved, the dialog prevents moving to another step to ensure the user saves their changes using "Save preference"
  • When the save fails we should allow the user to proceed to another step because they have tried to save their preferences but this failed

User story

As a user using the IP reveal guidance dialog, I attempt to agree to the IP Info use agreement preference. However, this fails due to the site being in read-only mode. I want to continue to the next step and will set the preference when read-only mode is disabled.

Acceptance criteria

  • When the attempt to save the IP Info use agreement preference fails (such as for the site being in read-only mode), the user can proceed to another step or close the dialog on the first attempt

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1123409 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Temp account onboarding dialog: Allow proceeding if pref save fails

https://gerrit.wikimedia.org/r/1123409

Change #1123409 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Temp account onboarding dialog: Allow proceeding if pref save fails

https://gerrit.wikimedia.org/r/1123409

dom_walden subscribed.

After trying to save the IPInfo preference leads to an error, I can go forward and backward in the dialog.

If the API response is a fatal error (e.g. make a syntax error in LocalSettings.php), the error isn't very helpful:

Something went wrong. Please try again. The error message received was: http

It probably won't come up that often, but I might raise a separate bug.

Test environment: local docker CheckUser 2.5 (ef2879f) 07:44, 28 February 2025.