SkinMobile needs to be properly registered
Closed, ResolvedPublic

Description

Because the system knows about it only when it's set as current skin by a hook, requests like the one in the URL field return Vector's styles. Looks like this needs core support.


Version: unspecified
Severity: enhancement
URL: http://bits.wikimedia.org/zh.wikipedia.org/load.php?debug=true&lang=zh&modules=site&only=styles&skin=SkinMobile&*

Details

Reference
bz36636
bzimport added a subscriber: Unknown Object (MLST).
bzimport set Reference to bz36636.
MaxSem created this task.May 8 2012, 10:55 AM

mw.config.get( 'skin' ) currently returns vector. Now we are using minerva we should call ourselves minerva.

I was talking to Matt and CentralNotice could do with this to distinguish between skins in deciding which banner to serve.

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1191

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1419

Change 102866 had a related patch set uploaded by Jdlrobson:
Offer the blue pill or the red pill

https://gerrit.wikimedia.org/r/102866

  • Bug 57127 has been marked as a duplicate of this bug. ***

Change 102866 merged by jenkins-bot:
Beta Feature: Register mobile skin, offer users the ability to change it

https://gerrit.wikimedia.org/r/102866

Change 118037 had a related patch set uploaded by Jdlrobson:
Make sure Minerva is registered as a valid skin

https://gerrit.wikimedia.org/r/118037

After discussing with Ryan, we actually realised we can register it but stop it from being user facing. So that's what's happening!

Change 118037 merged by jenkins-bot:
Make sure Minerva is registered as a valid skin

https://gerrit.wikimedia.org/r/118037

Add Comment