Page MenuHomePhabricator
Create Task
Maniphest T386428

Drop feature flag for Special:AllEvents section UI
Closed, ResolvedPublic
Actions

Description

Acceptance criteria
  • The CampaignEventsSeparateOngoingEvents config flag is removed from the CampaignEvents codebase
  • The flag is no longer set in WMF config

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Drop unused $wgCampaignEventsSeparateOngoingEventsDaimona Eaytoyoperations/mediawiki-configmaster+0 -4
Drop feature flag for upcoming/ongoing section separationDaimona Eaytoymediawiki/extensions/CampaignEventsmaster+7 -186
Customize query in gerrit

Related Objects
Search...

Event Timeline

Daimona created this task.Feb 14 2025, 3:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2025, 3:38 AM
Daimona added a subtask: T386427: Release section UI for Special:AllEvents.Feb 14 2025, 3:38 AM
Daimona added a parent task: T382018: [EPIC] Create separate sections for ongoing and upcoming events in the Collaboration List.
gerritbot added a comment.Mar 5 2025, 11:10 PM

Change #1124888 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Drop feature flag for upcoming/ongoing section separation

https://gerrit.wikimedia.org/r/1124888

gerritbot added a project: Patch-For-Review.Mar 5 2025, 11:10 PM
Daimona claimed this task.Mar 5 2025, 11:10 PM
Daimona moved this task from Upcoming / refining 💡 to Code Review 💬 on the Connection-Team (Connection-Current-Sprint) board.
gerritbot added a comment.Mar 7 2025, 3:09 PM

Change #1124888 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Drop feature flag for upcoming/ongoing section separation

https://gerrit.wikimedia.org/r/1124888

Maintenance_bot removed a project: Patch-For-Review.Mar 7 2025, 3:31 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.20; 2025-03-11).Mar 7 2025, 4:00 PM
Daimona moved this task from Code Review 💬 to Blocked ⛔ on the Connection-Team (Connection-Current-Sprint) board.Mar 7 2025, 7:00 PM

Now waiting for the next train before we can clean up the WMF config.

ifried closed subtask T386427: Release section UI for Special:AllEvents as Resolved.Mar 10 2025, 10:07 PM
Daimona moved this task from Blocked ⛔ to Ready for development on the Connection-Team (Connection-Current-Sprint) board.Mar 20 2025, 4:15 PM
gerritbot added a comment.Mar 24 2025, 5:16 PM

Change #1130659 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[operations/mediawiki-config@master] Drop unused $wgCampaignEventsSeparateOngoingEvents

https://gerrit.wikimedia.org/r/1130659

gerritbot added a project: Patch-For-Review.Mar 24 2025, 5:16 PM
Daimona moved this task from Ready for development to Development In Progress 💻 on the Connection-Team (Connection-Current-Sprint) board.Mar 24 2025, 5:18 PM

Scheduled for tomorrow 2025-03-25 13:00Z.

gerritbot added a comment.Mar 25 2025, 9:11 PM

Change #1130659 merged by jenkins-bot:

[operations/mediawiki-config@master] Drop unused $wgCampaignEventsSeparateOngoingEvents

https://gerrit.wikimedia.org/r/1130659

Stashbot mentioned this in T388955: Add Translate namespace in Kannada and Tulu wikisource.Mar 25 2025, 9:12 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-25T21:12:25Z] <tgr@deploy1003> Started scap sync-world: Backport for [[gerrit:1130659|Drop unused $wgCampaignEventsSeparateOngoingEvents (T386428)]], [[gerrit:1130752|Enable SUL3 login for 10% of group 2 users (T384219)]], [[gerrit:1130981|knwikisource, tcywikisource: add translate namespace (T388955)]]

Stashbot mentioned this in T384219: SUL3 Phase 4: Staged rollout for all existing users.Mar 25 2025, 9:12 PM
Stashbot added a comment.Mar 25 2025, 9:18 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-25T21:18:41Z] <tgr@deploy1003> daimona, anzx, tgr: Backport for [[gerrit:1130659|Drop unused $wgCampaignEventsSeparateOngoingEvents (T386428)]], [[gerrit:1130752|Enable SUL3 login for 10% of group 2 users (T384219)]], [[gerrit:1130981|knwikisource, tcywikisource: add translate namespace (T388955)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Mar 25 2025, 9:29 PM

Mentioned in SAL (#wikimedia-operations) [2025-03-25T21:29:29Z] <tgr@deploy1003> Finished scap sync-world: Backport for [[gerrit:1130659|Drop unused $wgCampaignEventsSeparateOngoingEvents (T386428)]], [[gerrit:1130752|Enable SUL3 login for 10% of group 2 users (T384219)]], [[gerrit:1130981|knwikisource, tcywikisource: add translate namespace (T388955)]] (duration: 17m 04s)

Maintenance_bot removed a project: Patch-For-Review.Mar 25 2025, 9:30 PM
Daimona moved this task from Development In Progress 💻 to QA 🐛 on the Connection-Team (Connection-Current-Sprint) board.Mar 25 2025, 10:47 PM
vaughnwalters closed this task as Resolved.Mar 26 2025, 2:52 PM
vaughnwalters moved this task from QA 🐛 to Done 🏁 on the Connection-Team (Connection-Current-Sprint) board.
vaughnwalters subscribed.

No instances of CampaignEventsSeparateOngoingEvents and wgCampaignEventsSeparateOngoingEvents in the codebase, and the feature is working as expected in prod. marking this as done / resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits