Page MenuHomePhabricator

Revert incorrect size and position values in resource files
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
DavidBrooks
Feb 14 2025, 4:55 AM
Referenced Files
Restricted File
Oct 8 2025, 9:06 PM
F66739312: input field.png
Oct 8 2025, 9:04 PM
F58445413: Set2.patch
Feb 21 2025, 6:19 PM
F58405044: Set1.patch
Feb 16 2025, 4:49 AM

Description

In a series of recent changes, some visual control property settings in the *.Designer.cs files were abstracted into the matching .resx files, as a preparation for localizing them. Some (all?) Size and Position elements have incorrect X, Y values (generally over twice the proper values) resulting in visual elements misplaced and mis-sized.

We need to revert the changes for those places where the visual impact is significant, and think again. There may be value in having the positions and sizes in the resource file, to accommodate different lengths of translated text, but the en-us text should use the legacy layout.

Do it in batches, starting with the errors that have been reported on the AWB talk page. This will revert T385373 and T385736.

Event Timeline

First tranche, restoring to the old (mostly empty) resx files and all the logic in Designer files: Main, CustomerModule, CustomModuleErrors, WikiFunctions/ReplaceSpecial. Layouts verified against rev 12900. Can a developer apply them?

I'll look around for some more.

I found four more: SummaryEditor, and in WIkiFunctions DabForm, InputBox, RuleControl. Still looking through the more obscure dialogs. The attached patch verified against revision 12939.

You should be able to commit things yourself @DavidBrooks :)

Thanks. I wasn't aware I had been added to the sourceforge inner circle :o). But not having worked with SVN until recently:

  1. Do you have any project-specific requirements concerning the svn commit command? (other than a descriptive message)
  2. Is there still a separate read-write URL?
  3. If so, presumably I need to check out a new tree and commit from that?

At least it looks easier than git...

You should be able to svn switch to a "different checkout" (like changing origin (or similar) in git).

If you look at https://sourceforge.net/p/autowikibrowser/code/HEAD/tree/ there should be an SSH and a HTTPS option that will work fine for pushing (rather than being ro)

Got it. Have to break off and need time to verify; back in a few hours. Sorry to be using a public forum for DMs...

SVN rev 12942: fixed SummaryEditor, InputBox, DabForm, RuleControl

SVN rev 12943: fixed CFD, IFD, Templator windows. That's all I could find for now.

Here are my notes and screenshot from ticket #T406410 filed on Oct 4, 2025{F66739312}


Just updated to 6.4.0.0 on Windows 10.

Under the Advanced Settings for Find and Replace, the input field for Replace With is scrunched down so far that you can't see what's been entered into the field. It's possible to drag the top field border up to temporarily remedy this, but the cursor has trouble finding the grabbing point. Also, it has to be done again upon the creation of any new Rule. Moving the field barrier and saving settings has no affect.

I've provided a screenshot. https://i.imgur.com/T5jw9ep.png

I searched the filed bug reports and could not find that this had already been reported. No known previous version of AWB had this bug.
{F66739313}

It has been fixed in the source tree, but that has not been pushed as an official build yet. I have an (almost) up to date build at https://github.com/DavidWBrooks/UnofficialAWB/releases/latest. As a bonus there's a build optimized for an ARM64 device.

Is it possible to get a beta release of the next version with the fixed code? I tried using an old version of AWB, but I get an error saying that version isn't enabled.