| Samwalton9-WMF | |
| Feb 14 2025, 1:19 PM |
| F58398856: Screenshot 2025-02-14 at 13.18.25.png | |
| Feb 14 2025, 1:20 PM |
The new page size (in bytes) min/max filters (T378488) enable editors to set minimum and/or maximum page sizes to be listed by the tool for deletion. The max filter contains a default value of 2097152. When I first saw this I had no idea what it was or why it was there.
Acceptance criteria
I assume that this default value is present because it's the maximum possible size of a page. I believe that, even if that's true, it's confusing to have this value in the form as a default value - I doubt more than a handful of editors are aware that this is what that value represents, so they're presented with the question of "Do I need to change this?" If left blank I think it would better communicate the idea that the maximum is unrestricted, with no particular restriction having been set.
We default the date field because it's not intuitive that there is a software-imposed restriction on the date. Leaving it blank would imply that results from all time can be retrieved, but we actually have a non-obvious limitation on the results that can be returned. In the case of the page size, we are imposing no such limit - all pages, regardless of size, can be retrieved. Having a default here communicates potentially the opposite - that there's some restriction to be aware of.
Using the $wgMaxPageSize to pre-fill the form was actually a workaround for a another issue I couldn't resolve which was that there's no way to tell the difference between a user actually listing 0 as the max page size (which is a valid way to find only 0-byte pages which can exist) or leaving the field blank (thus not wishing for it to be used) when there is no default set. Setting the "default" value for the form in OOUI, which I set to the technical maximum possible page size, makes the box pre-filled with that number. I'm not too experienced with OOUI so if anyone sees a workaround that would be very much appreciated, I'll try and investigate and see if I can find another way we can do this.
Change #1139879 had a related patch set uploaded (by Kgraessle; author: Kgraessle):
[mediawiki/extensions/Nuke@master] Max page size (in bytes) default value is confusing - Removed default max bytes in form - Also removes unused $interfaceLanguage param from the SpecialNukeHTMLFormUIRenderer constructor
Change #1139879 merged by jenkins-bot:
[mediawiki/extensions/Nuke@master] Max page size (in bytes) default value is confusing - Removed default max bytes in form - Also removes unused $interfaceLanguage param from the SpecialNukeHTMLFormUIRenderer constructor