Version 1.6.2 of Data Transfer does not work with MW < 1.41
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Osnard
	Feb 14 2025, 3:11 PM

Description

Change https://github.com/wikimedia/mediawiki-extensions-DataTransfer/commit/d56e80a56a52731355199855f0b38f3bdef15ba7
introduces $this->getAuthority()->isDefinitelyAllowed(...), which is not available before MediaWiki 1.41

The extension.json states compatibility to MW 1.37: https://github.com/wikimedia/mediawiki-extensions-DataTransfer/blob/1.6.2/extension.json#L13

Steps to replicate the issue (include links if applicable):

Install DataTransfer V1.6.2 on a MediaWiki 1.39
Try to access Special:ImportSpreadsheet

What happens?:
Error message

[3531f909893519aca9f0006c] /wiki/Special:ImportSpreadsheet Error: Call to undefined method User::isDefinitelyAllowed()

Backtrace:

from extensions/DataTransfer/includes/specials/DT_ImportCSV.php(32)
#0 includes/specialpage/SpecialPage.php(701): DTImportCSV->execute()
#1 includes/specialpage/SpecialPageFactory.php(1428): SpecialPage->run()
#2 includes/MediaWiki.php(316): MediaWiki\SpecialPage\SpecialPageFactory->executePath()
#3 includes/MediaWiki.php(904): MediaWiki->performRequest()
#4 includes/MediaWiki.php(562): MediaWiki->main()
#5 index.php(50): MediaWiki->run()
#6 w/index.php(46): wfIndexMain()
#7 {main}

What should have happened instead?:

The SpecialPage should be displayed

Software version:

MediaWiki 1.39
DataTransfer 1.6.2

Details

	Subject	Repo	Branch	Lines +/-
	Fix for d56e80a56a52 - restore support for MW < 1.41	mediawiki/extensions/DataTransfer	master	+11 -4

Customize query in gerrit

Event Timeline

Osnard created this task.Feb 14 2025, 3:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2025, 3:11 PM

Yaron_Koren renamed this task from Version 1.6.2 of Extension:DataTransfer introduces a breaking change to Version 1.6.2 of Data Transfer does not work with MW < 1.41.Feb 14 2025, 6:03 PM

Change #1121065 had a related patch set uploaded (by Yaron Koren; author: Yaron Koren):

[mediawiki/extensions/DataTransfer@master] Fix for d56e80a56a52 - restore support for MW < 1.41

https://gerrit.wikimedia.org/r/1121065

gerritbot added a project: Patch-For-Review.Feb 19 2025, 6:02 PM

Change #1121065 merged by jenkins-bot:

[mediawiki/extensions/DataTransfer@master] Fix for d56e80a56a52 - restore support for MW < 1.41

https://gerrit.wikimedia.org/r/1121065

@Osnard - sorry about that; I think this is fixed now, though it would be good to get confirmation.

Maintenance_bot removed a project: Patch-For-Review.Feb 19 2025, 7:30 PM

Yaron_Koren closed this task as Resolved.Fri, Apr 11, 1:27 PM

Yaron_Koren claimed this task.

Version 1.6.2 of Data Transfer does not work with MW < 1.41Closed, ResolvedPublicBUG REPORTActions

Description

Details

Event Timeline

Version 1.6.2 of Data Transfer does not work with MW < 1.41
Closed, ResolvedPublicBUG REPORT
Actions