Page MenuHomePhabricator
Create Task
Maniphest T386492

IP auto-reveal: Assign the IP auto-reveal right to user groups
Closed, ResolvedPublic
Actions

Description

Summary

Once IP auto-reveal is ready to be used, assign the right to user groups.

As specified in T385823, the right should be given to all users who get checkuser-temporary-account or checkuser-temporary-account-no-preference, except those who are assigned checkuser-temporary-account manually.

Technical notes

These local groups should have the checkuser-temporary-account-auto-reveal right, in line with the access policy:

  • checkuser (via extension.json)
  • suppress (via mediawiki-config)
  • sysop (via mediawiki-config)
  • bureaucrat (via mediawiki-config)

Global groups that have the checkuser-temporary-account or checkuser-temporary-account-no-preference right should also have the checkuser-temporary-account-auto-reveal right. A list of rights assigned to global groups can be seen at: https://meta.wikimedia.org/wiki/Special:GlobalGroupPermissions

Acceptance criteria

  • The group that is used to assign IP reveal rights manually is not assigned the IP auto-reveal right
  • All other groups that are assigned IP reveal rights are also assigned the IP auto-reveal right

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Assign IP auto-reveal rights to `checkuser` groupmediawiki/extensions/CheckUsermaster+1 -0
Assign IP auto-reveal rights to certain groupsoperations/mediawiki-configmaster+3 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Feb 14 2025, 5:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2025, 5:15 PM
Tchanders added a parent task: T358853: Temporary accounts: Automatically resolve temporary account names to IP addresses on displaying (auto reveal feature).Feb 14 2025, 5:16 PM
Tchanders mentioned this in T386500: IP auto-reveal: Allow managing IP auto-reveal from sidebar tools menu.Feb 14 2025, 6:08 PM
Tchanders moved this task from Backlog to Planned on the Temporary accounts (Major pilot wiki deployment) board.Feb 26 2025, 11:47 AM
Tchanders changed the status of subtask T386496: IP auto-reveal: Allow managing auto-reveal mode from the bottom dock menu from Open to Stalled.Mar 17 2025, 2:16 PM
kostajh edited projects, added Trust and Safety Product Sprint (Sprint Chocolate Cake (March 24 - April 11)); removed Trust and Safety Product Sprint.Mar 20 2025, 12:02 PM
Tchanders removed a subtask: T386496: IP auto-reveal: Allow managing auto-reveal mode from the bottom dock menu.Apr 3 2025, 1:34 PM
kostajh closed subtask T386498: IP auto-reveal: Indicate when IP auto-reveal mode has just been switched on or off as Resolved.Apr 14 2025, 8:07 AM
kostajh edited projects, added Trust and Safety Product Sprint (Sprint Cozonac (April 14 - May 2)); removed Trust and Safety Product Sprint (Sprint Chocolate Cake (March 24 - April 11)).Apr 14 2025, 2:54 PM
Tchanders mentioned this in T387600: IP Auto-reveal: Agree and implement metrics and instrumentation plan.Apr 25 2025, 6:47 PM
Tchanders added a subtask: T387600: IP Auto-reveal: Agree and implement metrics and instrumentation plan.Apr 28 2025, 1:07 PM
kostajh moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Cozonac (April 14 - May 2)) board.Apr 30 2025, 1:55 PM
kostajh edited projects, added Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)); removed Trust and Safety Product Sprint (Sprint Cozonac (April 14 - May 2)).May 5 2025, 6:50 AM
kostajh moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)) board.
Tchanders moved this task from Ready to In Progress on the Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)) board.May 6 2025, 5:12 PM
Tchanders updated the task description. (Show Details)May 6 2025, 5:35 PM
Tchanders added a comment.May 6 2025, 5:38 PM

Since anyone who is in any local checkuser and suppress gets the global-temporary-account-viewer group (which will have the auto-reveal right), it is not necessary to give them checkuser-temporary-account-auto-reveal via the global groups. But it might look odd not doing so.

For the first pass, I'll assign the right to the local groups in the patches, and we can change them not to do so if necessary.

gerritbot added a comment.May 6 2025, 5:39 PM

Change #1142647 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Assign IP auto-reveal rights to `checkuser` group

https://gerrit.wikimedia.org/r/1142647

gerritbot added a project: Patch-For-Review.May 6 2025, 5:39 PM
gerritbot added a comment.May 6 2025, 5:42 PM

Change #1142649 had a related patch set uploaded (by Tchanders; author: Tchanders):

[operations/mediawiki-config@master] Assign IP auto-reveal rights to certain groups

https://gerrit.wikimedia.org/r/1142649

Tchanders added a comment.EditedMay 6 2025, 5:45 PM

Global groups that have the checkuser-temporary-account or checkuser-temporary-account-no-preference right should also have the checkuser-temporary-account-auto-reveal right. A list of rights assigned to global groups can be seen at: https://meta.wikimedia.org/wiki/Special:GlobalGroupPermissions

Would we need to ask a community member to add the checkuser-temporary-account-auto-reveal right to the relevant global groups?

JJMC89 subscribed.May 7 2025, 1:03 AM
In T386492#10797269, @Tchanders wrote:

Global groups that have the checkuser-temporary-account or checkuser-temporary-account-no-preference right should also have the checkuser-temporary-account-auto-reveal right. A list of rights assigned to global groups can be seen at: https://meta.wikimedia.org/wiki/Special:GlobalGroupPermissions

Would we need to ask a community member to add the checkuser-temporary-account-auto-reveal right to the relevant global groups?

Yes, a steward needs to do this.

kostajh changed the status of subtask T393643: IP auto-reveal: Use the UserTemporaryLocation icon in the tool menu on mobile from Open to Stalled.May 9 2025, 6:39 AM
Tchanders closed subtask T386494: IP auto-reveal: Log when mode is switched and when IPs are revealed as Resolved.May 9 2025, 12:30 PM
Tchanders closed subtask T389816: IP auto-reveal: Enable and disable the mode globally as Resolved.
Tchanders closed subtask T388688: IP auto-reveal: Limit the duration that auto-reveal mode can be extended for as Resolved.
Dreamy_Jazz assigned this task to Tchanders.May 15 2025, 8:05 PM
kostajh closed subtask T394074: IP auto-reveal: Indicate on sidebar tool link if auto-reveal mode is on as Resolved.May 25 2025, 6:51 PM
kostajh edited projects, added Trust and Safety Product Sprint (Sprint Carrot Cake (May 26 - June 13)); removed Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)).May 25 2025, 6:59 PM
kostajh moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Carrot Cake (May 26 - June 13)) board.
Tchanders moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Carrot Cake (May 26 - June 13)) board.May 27 2025, 3:35 PM
Tchanders added subscribers: kostajh, Niharika.

While we wait for an OOUI release (so the icon on the mobile tools menu can be updated), we'll enable auto-reveal for users, so they can try this ahead of major pilots deployment, as discussed with @kostajh and @Niharika.

Tchanders added a subscriber: Urbanecm.May 27 2025, 3:43 PM
In T386492#10798615, @JJMC89 wrote:
In T386492#10797269, @Tchanders wrote:

Global groups that have the checkuser-temporary-account or checkuser-temporary-account-no-preference right should also have the checkuser-temporary-account-auto-reveal right. A list of rights assigned to global groups can be seen at: https://meta.wikimedia.org/wiki/Special:GlobalGroupPermissions

Would we need to ask a community member to add the checkuser-temporary-account-auto-reveal right to the relevant global groups?

Yes, a steward needs to do this.

@Urbanecm Would you be happy to do this?

gerritbot added a comment.Jun 3 2025, 7:14 AM

Change #1142649 merged by jenkins-bot:

[operations/mediawiki-config@master] Assign IP auto-reveal rights to certain groups

https://gerrit.wikimedia.org/r/1142649

Stashbot added a comment.Jun 3 2025, 7:14 AM

Mentioned in SAL (#wikimedia-operations) [2025-06-03T07:14:45Z] <tchanders@deploy1003> Started scap sync-world: Backport for [[gerrit:1142649|Assign IP auto-reveal rights to certain groups (T386492)]]

Stashbot added a comment.Jun 3 2025, 7:16 AM

Mentioned in SAL (#wikimedia-operations) [2025-06-03T07:16:49Z] <tchanders@deploy1003> tchanders: Backport for [[gerrit:1142649|Assign IP auto-reveal rights to certain groups (T386492)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Jun 3 2025, 7:25 AM

Mentioned in SAL (#wikimedia-operations) [2025-06-03T07:25:24Z] <tchanders@deploy1003> Finished scap sync-world: Backport for [[gerrit:1142649|Assign IP auto-reveal rights to certain groups (T386492)]] (duration: 10m 39s)

Urbanecm added a comment.Jun 3 2025, 1:50 PM
In T386492#10859924, @Tchanders wrote:
In T386492#10798615, @JJMC89 wrote:
In T386492#10797269, @Tchanders wrote:

Global groups that have the checkuser-temporary-account or checkuser-temporary-account-no-preference right should also have the checkuser-temporary-account-auto-reveal right. A list of rights assigned to global groups can be seen at: https://meta.wikimedia.org/wiki/Special:GlobalGroupPermissions

Would we need to ask a community member to add the checkuser-temporary-account-auto-reveal right to the relevant global groups?

Yes, a steward needs to do this.

@Urbanecm Would you be happy to do this?

Should be done (from my staff self). Can you double check?

Tchanders closed this task as Resolved.EditedJun 3 2025, 2:37 PM
Tchanders moved this task from Needs Review to Done on the Trust and Safety Product Sprint (Sprint Carrot Cake (May 26 - June 13)) board.

@Urbanecm Looks good: https://meta.wikimedia.org/wiki/Special:GlobalGroupPermissions - every group with checkuser-temporary-account or checkuser-temporary-account-no-preference also has checkuser-temporary-account-auto-reveal.

Thank you!

gerritbot added a comment.Jun 3 2025, 3:11 PM

Change #1142647 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Assign IP auto-reveal rights to `checkuser` group

https://gerrit.wikimedia.org/r/1142647

Maintenance_bot removed a project: Patch-For-Review.Jun 3 2025, 3:30 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.5; 2025-06-10).Jun 3 2025, 4:00 PM
Tchanders changed the status of subtask T393643: IP auto-reveal: Use the UserTemporaryLocation icon in the tool menu on mobile from Stalled to Open.Jun 16 2025, 9:25 AM
Tchanders closed subtask T393643: IP auto-reveal: Use the UserTemporaryLocation icon in the tool menu on mobile as Resolved.Jun 21 2025, 9:35 PM
kostajh closed subtask T387600: IP Auto-reveal: Agree and implement metrics and instrumentation plan as Resolved.Jul 7 2025, 9:37 AM
Niharika mentioned this in T406706: [Work in progress] Make auto reveal a switch instead of a timed mode.Oct 8 2025, 9:52 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits