Page MenuHomePhabricator
Create Task
Maniphest T386536

Ensure `@color-subtle` is used instead of `#72777d`
Open, Needs TriagePublic
Actions

Assigned To
None
Authored By
Volker_E
Feb 15 2025, 1:08 AM
Tags
Referenced Files
None
Subscribers
Aklapper
Arian_Bozorg
DTorsani-WMF
IKhitron
jhsoby
karapayneWMDE
Nikerabbit
Volker_E

Description

Background

Originated in T335225: Token clean-up: Collect and evaluate `@color-subtle` #54595d vs often used #72777d the decision was provided to solely rely on @color-subtle with #54595d as value in current Codex WikimediaUI theme.

Goal

Replace static values and outdated @color-base-subtle variables with current, as of v1.20.1, @color-subtle token.
This also makes the interface react appropriately to dark mode user preference while it fails before.

Acceptance criteria for done

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Prepare GlobalWatchlist for IP maskingmediawiki/extensions/GlobalWatchlistmaster+46 -12
ve.ui.CodeMirror.less: use @color-subtle var instead of hard-coding itmediawiki/extensions/CodeMirrormaster+3 -1
ui(PostEditPanel): drop background color behind opaque picturemediawiki/extensions/GrowthExperimentsmaster+1 -1
styles: Replace static values by Codex design tokens and fix todomediawiki/extensions/WikibaseQualityConstraintsmaster+5 -6
Customize query in gerrit

Related Objects
Search...

Event Timeline

Volker_E created this task.Feb 15 2025, 1:08 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptFeb 15 2025, 1:08 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Volker_E moved this task from Inbox to Following on the Design-System-Team board.Feb 15 2025, 1:08 AM
gerritbot added a comment.Feb 15 2025, 1:44 AM

Change #1119784 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/WikibaseQualityConstraints@master] styles: Replace static values by Codex design tokens and fix todo

https://gerrit.wikimedia.org/r/1119784

gerritbot added a project: Patch-For-Review.Feb 15 2025, 1:44 AM
gerritbot added a comment.Feb 17 2025, 2:55 PM

Change #1119784 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] styles: Replace static values by Codex design tokens and fix todo

https://gerrit.wikimedia.org/r/1119784

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.17; 2025-02-18).Feb 17 2025, 3:00 PM
Nikerabbit moved this task from Needs Triage to Upstream/Other teams on the ContentTranslation board.Feb 20 2025, 9:01 AM
Nikerabbit moved this task from Backlog to cross projects on the MediaWiki-extensions-Translate board.Feb 20 2025, 9:06 AM
Nikerabbit subscribed.
NOTE: Parking this on the "external" columns on LPL extensions for now since this is a shared task and we cannot properly triage such without creating subtasks.
Maintenance_bot removed a project: Patch-For-Review.Feb 20 2025, 9:30 AM
gerritbot added a comment.Mar 18 2025, 3:52 PM

Change #1128898 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] ui(PostEditPanel): replace static color with token

https://gerrit.wikimedia.org/r/1128898

gerritbot added a project: Patch-For-Review.Mar 18 2025, 3:52 PM
Michael subscribed.Mar 18 2025, 3:52 PM

@Volker_E can/should this also happen inside of SVGs? This seems to be the main use-case for GrowthExperiments. (There is one use in less-code which I will make a change for.)

Michael edited projects, added Growth-Team (Current Sprint); removed Growth-Team.Mar 18 2025, 3:54 PM

(not assigning to me because this is a shared task)

Michael moved this task from Incoming to Doing on the Growth-Team (Current Sprint) board.Mar 18 2025, 3:54 PM
Volker_E added a comment.Mar 18 2025, 4:48 PM

@Michael Only when there were text in the SVG. #72777d continues to exist in our palette, just the usage as text color is problematic.

Michael added a comment.Mar 18 2025, 4:58 PM
In T386536#10647675, @Volker_E wrote:

@Michael Only when there were text in the SVG. #72777d continues to exist in our palette, just the usage as text color is problematic.

Ah, this is only about text color? That one line in less code for GrowthExperiments is background: url( ../../images/try-new-task-ltr.svg ) no-repeat center/40px, #72777d;

I still have to double-check if the changed color makes sense there for light and dark-mode.

Michael moved this task from Doing to Code Review on the Growth-Team (Current Sprint) board.Mar 27 2025, 12:40 PM
In T386536#10647745, @Michael wrote:
In T386536#10647675, @Volker_E wrote:

@Michael Only when there were text in the SVG. #72777d continues to exist in our palette, just the usage as text color is problematic.

Ah, this is only about text color? That one line in less code for GrowthExperiments is background: url( ../../images/try-new-task-ltr.svg ) no-repeat center/40px, #72777d;

I still have to double-check if the changed color makes sense there for light and dark-mode.

That is a background color behind an entirely opaque image. There is little point to doing that, I removed it. If the image is slow to load or fails to load, then the user will see the background of the overall notification in its place instead of a gray box, which makes much more sense to me.

Volker_E added a comment.Mar 27 2025, 10:16 PM
In T386536#10682699, @Michael wrote:

That is a background color behind an entirely opaque image. There is little point to doing that, I removed it. If the image is slow to load or fails to load, then the user will see the background of the overall notification in its place instead of a gray box, which makes much more sense to me.

Great, thanks for the persistance!

gerritbot added a comment.Mar 28 2025, 11:37 AM

Change #1128898 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] ui(PostEditPanel): drop background color behind opaque picture

https://gerrit.wikimedia.org/r/1128898

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.23; 2025-04-01); removed MW-1.44-notes (1.44.0-wmf.17; 2025-02-18).Mar 28 2025, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 28 2025, 12:30 PM
Volker_E updated the task description. (Show Details)Mar 31 2025, 11:52 PM
Volker_E added a parent task: T390645: [EPIC] Replace all static hex color values in Wikimedia deployed MediaWiki skins and extensions with Codex design tokens.Apr 1 2025, 1:41 AM
Michael removed projects: Growth-Team (Current Sprint), GrowthExperiments.Apr 1 2025, 12:31 PM
Michael unsubscribed.

Done on our end, removing this from our boards. Please ping me if there is anything else to do for us.

Volker_E added projects: MediaWiki-extensions-GlobalWatchlist, MediaWiki-extensions-CodeMirror, MediaUploader, MediaWiki-extensions-SecurePoll, Wikidata Lexicographical data.Apr 1 2025, 5:52 PM
Volker_E updated the task description. (Show Details)
Restricted Application added projects: User-DannyS712, Trust and Safety Product Team. · View Herald TranscriptApr 1 2025, 5:52 PM
Maintenance_bot added a project: Wikidata.Apr 1 2025, 6:29 PM
gerritbot added a comment.Apr 6 2025, 7:18 PM

Change #1134377 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] ve.ui.CodeMirror.less: use @color-subtle var instead of hard-coding it

https://gerrit.wikimedia.org/r/1134377

gerritbot added a project: Patch-For-Review.Apr 6 2025, 7:18 PM
MusikAnimal moved this task from Backlog to Maintenance / tech debt on the MediaWiki-extensions-CodeMirror board.Apr 6 2025, 7:20 PM
gerritbot added a comment.Apr 7 2025, 3:57 AM

Change #1134377 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] ve.ui.CodeMirror.less: use @color-subtle var instead of hard-coding it

https://gerrit.wikimedia.org/r/1134377

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.24; 2025-04-08); removed MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Apr 7 2025, 4:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 7 2025, 4:30 AM
Volker_E updated the task description. (Show Details)Apr 23 2025, 4:36 PM
Jdlrobson-WMF moved this task from Backlog to Tech debt on the MinervaNeue board.Apr 24 2025, 3:04 PM
Dreamy_Jazz moved this task from Inbox to Engineering on the Trust and Safety Product Team board.May 14 2025, 8:59 PM
Nikerabbit moved this task from Upstream/Other teams to Maintenance on the ContentTranslation board.May 22 2025, 1:53 PM
gerritbot added a comment.Jun 11 2025, 11:06 AM

Change #1155639 had a related patch set uploaded (by SD0001; author: SD0001):

[mediawiki/extensions/SecurePoll@master] Use @color-subtle instead of #72777d

https://gerrit.wikimedia.org/r/1155639

gerritbot added a project: Patch-For-Review.Jun 11 2025, 11:06 AM
jhsoby removed a project: MediaWiki-extensions-Translate.Jun 13 2025, 8:43 AM
jhsoby subscribed.

Done back in December–February for the Translate extension (T381834), so removing that tag.

Bhsd moved this task from Maintenance / tech debt to Done on the MediaWiki-extensions-CodeMirror board.Jun 25 2025, 7:29 AM
OKryva-WMF edited projects, added Product Safety and Integrity, Essential-Work; removed Trust and Safety Product Team.Oct 3 2025, 3:26 PM
OKryva-WMF moved this task from Inbox to Triaged (backlog) on the Product Safety and Integrity board.Oct 3 2025, 3:26 PM
karapayneWMDE added a project: Wikidata Omega Product.Oct 15 2025, 1:59 PM
karapayneWMDE added subscribers: Arian_Bozorg, karapayneWMDE.

Adding to relevant wikidata team board. @Arian_Bozorg we should pick this up whenever we're working on the NSLP next

MusikAnimal removed a project: MediaWiki-extensions-CodeMirror.Oct 19 2025, 6:24 PM
IKhitron subscribed.Dec 20 2025, 5:03 PM

Didn't know about this task, but made the same thing for MediaWiki-extensions-GlobalWatchlist in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalWatchlist/+/1211732 as a part of a bigger change. Is it what you need, and is it enough? Should I split this part to a new change?

IKhitron added a project: User-IKhitron.Dec 20 2025, 5:10 PM
IKhitron moved this task from Backlog to Coding on the User-IKhitron board.
Volker_E added a comment.Dec 22 2025, 6:36 PM
In T386536#11479762, @IKhitron wrote:

Didn't know about this task, but made the same thing for MediaWiki-extensions-GlobalWatchlist in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalWatchlist/+/1211732 as a part of a bigger change. Is it what you need, and is it enough? Should I split this part to a new change?

That patch is great and sufficient, thanks!

IKhitron added a comment.Dec 22 2025, 6:54 PM
In T386536#11481782, @Volker_E wrote:
In T386536#11479762, @IKhitron wrote:

Didn't know about this task, but made the same thing for MediaWiki-extensions-GlobalWatchlist in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GlobalWatchlist/+/1211732 as a part of a bigger change. Is it what you need, and is it enough? Should I split this part to a new change?

That patch is great and sufficient, thanks!

Great. Now let's hope there will be somebody to approve it. Since, Danny left, there isn't so much interest in this extension.

gerritbot added a comment.Dec 22 2025, 9:27 PM

Change #1211732 had a related patch set uploaded (by IKhitron; author: IKhitron):

[mediawiki/extensions/GlobalWatchlist@master] Prepare GlobalWatchlist for IP masking

https://gerrit.wikimedia.org/r/1211732

gerritbot added a comment.Dec 22 2025, 9:45 PM

Change #1211732 merged by jenkins-bot:

[mediawiki/extensions/GlobalWatchlist@master] Prepare GlobalWatchlist for IP masking

https://gerrit.wikimedia.org/r/1211732

IKhitron moved this task from Coding to Merged on the User-IKhitron board.Dec 22 2025, 10:06 PM
Novem_Linguae updated the task description. (Show Details)Dec 23 2025, 2:54 AM
IKhitron moved this task from Merged to Deployed on the User-IKhitron board.Jan 7 2026, 7:26 PM
Lucas_Werkmeister_WMDE edited projects, added Wikibase-Quality-Constraints; removed Wikibase Architecture.Mar 23 2026, 9:35 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits