Page MenuHomePhabricator
Create Task
Maniphest T386606

DISPLAYTITLE not honoured in category page lists
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

1.43 with DisplayTitle extension installed. For pages with DISPLAYTITLE set and a category, visit the category page

What happens?:

Page name displayed, not the DISPLAYTITLE is shown, as was done in 1.39

What should have happened instead?:

DISPLAYTITLE should be shown, presumably by the DisplayTitle extension, but possibly without.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

MediaWiki 1.43.0
DisplayTitle 4.0.3 (920768a) 07:59, 23 November 2024

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
DISPLAYTITLE not honoured in category page listsmediawiki/extensions/DisplayTitleREL1_44+6 -2
DISPLAYTITLE not honoured in category page listsmediawiki/extensions/DisplayTitleREL1_43+6 -2
DISPLAYTITLE not honoured in category page listsmediawiki/extensions/DisplayTitlemaster+6 -2
DISPLAYTITLE not honoured in category page listsmediawiki/extensions/DisplayTitleREL1_45+6 -2
Customize query in gerrit

Related Objects

Event Timeline

Vicarage created this task.Feb 17 2025, 8:24 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 17 2025, 8:24 AM
Aklapper added a project: MediaWiki-extensions-DisplayTitle.Feb 17 2025, 9:43 AM
NeatNit mentioned this in T26139: Use display title from page_props as the displayed title everywhere (tracking).Apr 2 2025, 10:31 PM
Bugreporter2 subscribed.May 14 2025, 6:34 AM

I think it is if you also use this one:

https://www.mediawiki.org/wiki/Extension:DISPLAYCAT

Ideally though, this should be fixable and fixed without hackish changes.

Bugreporter2 awarded a token.May 14 2025, 6:34 AM
Mr._Starfleet_Command subscribed.Jul 10 2025, 12:03 AM
Rvdwiel added subscribers: cicalese, Rvdwiel.Aug 25 2025, 9:35 AM

This is happening due to a change in an if-statement, see: https://github.com/wikimedia/mediawiki-extensions-DisplayTitle/blob/REL1_43/includes/DisplayTitleService.php#L170

In the case of category pages, the variable $html is null in the case of displaytitle links on category pages, which in turn causes the processing (i.e. checking if the page has a display title set) to stop. It was probably added to let phan tests pass (change-ID: I91af732da11c97929d1746ebba2a6a7a82eaac67), but it unfortunately has side effects.

@cicalese Do you suggest I proceed in reverting the change to the if-statement?

gerritbot added a comment.Wed, Oct 29, 12:27 PM

Change #1199759 had a related patch set uploaded (by Rrvdw; author: Rrvdw):

[mediawiki/extensions/DisplayTitle@master] DISPLAYTITLE not honoured in category page lists

https://gerrit.wikimedia.org/r/1199759

gerritbot added a project: Patch-For-Review.Wed, Oct 29, 12:27 PM
gerritbot added a comment.Wed, Oct 29, 12:57 PM

Change #1199770 had a related patch set uploaded (by Cicalese; author: Rrvdw):

[mediawiki/extensions/DisplayTitle@REL1_43] DISPLAYTITLE not honoured in category page lists

https://gerrit.wikimedia.org/r/1199770

gerritbot added a comment.Wed, Oct 29, 12:58 PM

Change #1199772 had a related patch set uploaded (by Cicalese; author: Rrvdw):

[mediawiki/extensions/DisplayTitle@REL1_44] DISPLAYTITLE not honoured in category page lists

https://gerrit.wikimedia.org/r/1199772

gerritbot added a comment.Wed, Oct 29, 12:58 PM

Change #1199773 had a related patch set uploaded (by Cicalese; author: Rrvdw):

[mediawiki/extensions/DisplayTitle@REL1_45] DISPLAYTITLE not honoured in category page lists

https://gerrit.wikimedia.org/r/1199773

cicalese closed this task as Resolved.Wed, Oct 29, 1:02 PM
cicalese claimed this task.
cicalese merged a task: T402760: DISPLAYTITLE not shown in WhatLinksHere.Wed, Oct 29, 1:06 PM
gerritbot added a comment.Wed, Oct 29, 1:12 PM

Change #1199759 merged by jenkins-bot:

[mediawiki/extensions/DisplayTitle@master] DISPLAYTITLE not honoured in category page lists

https://gerrit.wikimedia.org/r/1199759

gerritbot added a comment.Wed, Oct 29, 1:14 PM

Change #1199773 merged by jenkins-bot:

[mediawiki/extensions/DisplayTitle@REL1_45] DISPLAYTITLE not honoured in category page lists

https://gerrit.wikimedia.org/r/1199773

gerritbot added a comment.Wed, Oct 29, 1:18 PM

Change #1199770 merged by jenkins-bot:

[mediawiki/extensions/DisplayTitle@REL1_43] DISPLAYTITLE not honoured in category page lists

https://gerrit.wikimedia.org/r/1199770

gerritbot added a comment.Wed, Oct 29, 1:23 PM

Change #1199772 merged by jenkins-bot:

[mediawiki/extensions/DisplayTitle@REL1_44] DISPLAYTITLE not honoured in category page lists

https://gerrit.wikimedia.org/r/1199772

Maintenance_bot removed a project: Patch-For-Review.Wed, Oct 29, 1:32 PM
cicalese mentioned this in rEDPTc19f417b20b0: DISPLAYTITLE not honoured in category page lists.Wed, Oct 29, 3:57 PM
cicalese mentioned this in rEDPTdb8596d156b8: DISPLAYTITLE not honoured in category page lists.
cicalese mentioned this in rEDPTe656cf89f887: DISPLAYTITLE not honoured in category page lists.
Restricted Repository Identity mentioned this in rEDPTe6a8a81fe19d: DISPLAYTITLE not honoured in category page lists.Wed, Oct 29, 3:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits