Enforce GrowthConfigValidation::MAX_TEMPLATES_IN_COLLECTION using CommunityConfiguration
Closed, ResolvedPublic5 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Urbanecm_WMF
	Feb 17 2025, 12:57 PM

Description

Background

GrowthExperiments adds a template collection feature to search, which allows users to submit search queries based on groups of templates. This feature is used to exclude articles with infoboxes from Add Image. It is exposed to administrators using Community Configuration as this:

Since ElasticSearch doesn't allow more than 1024 clauses in a boolean query, the total number of templates is limited. Currently, this limit is set at 500 templates (500 infobox templates). Prior to migrating to CC2.0, GrowthExperiments enforced this restriction via its GrowthConfigValidation. However, this limitation was not migrated to Community Configuration 2.0.

Problem

Currently, Special:CommunityConfiguration/GrowthSuggestedEdits would allow admins to specify as many templates as they want. If they exceed the 500 limit, the template collection feature will not exclude anything. In other words: specifying more than 500 templates results in excluding no articles from Add Link. This is an user facing portion of the impact.

This also makes it more challenging to remove CC legacy, as a portion of GrowthConfigValidation (part of CC legacy) continues to be used (namely, the 500 constant).

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	fix(CC2.0): enforce max-limit on InfoboxTemplates	mediawiki/extensions/GrowthExperiments	master	+16 -6

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T265163 Create a system to encode best practices into editing experiences
Open		None	T327563 Enable volunteers to configure Edit Check in ways that align with project policies and norms
Open		None	T327655 Epic: Migration of some GrowthExperiments features into MediaWiki core
Resolved		Urbanecm_WMF	T323811 [EPIC] Community configuration 2.0: Factor Community configuration out of GrowthExperiments
Resolved		DMburugu	T367429 [Epic] FY 2024-25 Growth Maintenance Work
In Progress		Sgs	T367574 [Epic] Remove code for Special:EditGrowthConfig
Resolved	BUG REPORT	Michael	T386629 Enforce GrowthConfigValidation::MAX_TEMPLATES_IN_COLLECTION using CommunityConfiguration

Event Timeline

Urbanecm_WMF created this task.Feb 17 2025, 12:57 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptFeb 17 2025, 12:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Moving to Up Next, as we decided to prioritize tasks related to CC1.0 deprecation.

Michael subscribed.Feb 17 2025, 5:14 PM

Sgs added a parent task: T367574: [Epic] Remove code for Special:EditGrowthConfig.Feb 17 2025, 5:15 PM

Michael changed the subtype of this task from "Task" to "Bug Report".Feb 17 2025, 5:21 PM

Urbanecm_WMF set the point value for this task to 5.Feb 17 2025, 5:27 PM

KStoller-WMF moved this task from Estimated tasks backlog to Current Sprint on the Growth-Team board.Feb 18 2025, 5:52 PM

KStoller-WMF edited projects, added Growth-Team (Current Sprint); removed Growth-Team.

Sergio and I discussed this task today. When looking at the existing configuration, it turned out that one wiki, Polish wikipedia, had more than 500 entries for this. Surprisingly, it had those more than 500 entries BOTH in the legacy config as well as in the new config. This is the edit that would have seemed to add additional templates to the legacy config on April 12th 2024: https://pl.wikipedia.org/w/index.php?title=MediaWiki:GrowthExperimentsConfig.json&diff=prev&oldid=73495657

That was before the migration to CommunityConfiguration in June 2024 (see T368121). So maybe that limit was already not enforced to 500 in the legacy configuraiton?

Restricted Application added a project: User-Michael. · View Herald TranscriptMar 11 2025, 12:24 PM

Michael moved this task from Incoming to Doing on the Growth-Team (Current Sprint) board.Mar 11 2025, 12:35 PM

Not sure where the "500" in the article description is coming from, but in code we seem to have a limit of 800, added in Avoid references to TemplateCollectionFeature in 2021. This would mean that also the config in Polish Wikipedia is within the limits, and we can just move forward with enforcing it in CC2.0 as well.

Change #1126557 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] fix(CC2.0): enforce max-limit on InfoboxTemplates

https://gerrit.wikimedia.org/r/1126557

gerritbot added a project: Patch-For-Review.Mar 11 2025, 1:36 PM

Michael moved this task from Doing to Code Review on the Growth-Team (Current Sprint) board.Mar 11 2025, 1:51 PM

Change #1126557 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix(CC2.0): enforce max-limit on InfoboxTemplates

https://gerrit.wikimedia.org/r/1126557

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.21; 2025-03-18).Mar 13 2025, 12:01 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 13 2025, 12:30 PM

Now storing more than 800 templates in the "Infobox templates"-section should fail. Not sure how feasible it is to test that...

In T386629#10641334, @Michael wrote:

Now storing more than 800 templates in the "Infobox templates"-section should fail. Not sure how feasible it is to test that...

I just checked for general regression.plwiki has disabled both Add image tasks. GEInfoboxTemplates still lists lots of Infobox templates though - https://pl.wikipedia.org/wiki/Specjalna:Konfiguracja_wiki/GrowthSuggestedEdits.

Enforce GrowthConfigValidation::MAX_TEMPLATES_IN_COLLECTION using CommunityConfigurationClosed, ResolvedPublic5 Estimated Story PointsBUG REPORTActions