In T348284: Handle sidecar containers in one-off Kubernetes jobs we introduced a controller that adds functionality which I believe is build in with Kubernetes 1.31.
We should evaluate that, migrate the charts that use the pod.kubernetes.io/sidecars annotation and remove the k8s-controller-sidecars controller if applicable.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | JMeybohm | T341984 Update Kubernetes clusters to 1.31 | |||
| Open | None | T386694 Replace k8s-controller-sidecars with built in Sidecar containers on k8s 1.31 |
Yep 100% agree. The controller we're using is just a stopgap until https://kubernetes.io/docs/concepts/workloads/pods/sidecar-containers/ is available, we should shut it down once we can.
Thank you for tagging this task with good first task for Wikimedia newcomers!
Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.
A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !
Thank you for helping us drive new contributions to our projects <3