Page MenuHomePhabricator

Compare contents header: Spacing doesn't follow design specifications on desktop
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
ngkountas
Feb 18 2025, 10:29 AM
Referenced Files
F58615036: 2025-03-05_15-11-13.png
Mar 6 2025, 12:11 AM
F58615032: 2025-03-05_15-01-33.mp4.gif
Mar 6 2025, 12:11 AM
F58615018: 2025-03-05_15-03-35.mp4.gif
Mar 6 2025, 12:11 AM
F58615014: 2025-03-05_15-01-02.mp4.gif
Mar 6 2025, 12:11 AM
F58615007: 2025-03-05_15-05-20.png
Mar 6 2025, 12:11 AM
F58615005: 2025-03-05_15-05-45.png
Mar 6 2025, 12:11 AM
F58615003: 2025-03-05_15-06-20.png
Mar 6 2025, 12:11 AM
F58415882: before-fix-1256.png
Feb 18 2025, 10:29 AM

Description

Steps to replicate the issue (include links if applicable):

  1. Go to the Unified Dashboard on desktop
  2. Select an article to expand by translation a new section (section translation)
  3. Proceed to the "Compare the contents" step

What happens?:
The header in this step doesn't follow the design specifications as defined in T241589.

What should have happened instead?:
The spacing inside the header should follow the design specifications.

Design:

Compare contents - Header responsive.png (768×1 px, 79 KB)

Screenshot from test wiki (screen size: 648px) (Elements overflow the row's width):

before-fix-648.png (995×897 px, 228 KB)

Screenshot from test wiki (screen size: 1090px) (Elements don’t occupy the full available width):

before-fix-1090.png (995×1 px, 297 KB)

Screenshot from test wiki (screen size: 1256px) (Elements don’t occupy the full available width):

before-fix-1256.png (995×1 px, 300 KB)

Derived Requirements

  1. Ensure Correct Spacing for "Compare the Contents" Header
    • Update the spacing inside the header in the "Compare the Contents" step to match the design specifications from T241589.
    • Ensure that the elements inside the header do not overflow and align properly.
  1. Ensure Responsive Behavior on Different Screen Sizes
    • On smaller screens (e.g., 648px width):
      • The elements should not overflow the row’s width.
    • On medium screens (e.g., 1090px width):
      • The elements should occupy the full available width instead of leaving excessive whitespace.
    • On larger screens (e.g., 1256px width):
      • The layout should scale properly without breaking.
  1. Match the Design in Figma
    • Ensure the layout follows the specifications in the Compare contents - Header responsive.png design file.
    • Verify that spacing, alignment, and proportions match the intended layout.
Test Steps

Test Case: Verify Header Spacing in the "Compare the Contents" Step

  1. Check Header Layout on Small Screens (648px width)
    • Resize the browser window to 648px width.
    • ✅❓❌⬜ AC1: Ensure that elements do not overflow the row’s width.
  1. Check Header Layout on Medium Screens (1090px width)
    • Resize the browser window to 1090px width.
    • ✅❓❌⬜ AC2: Ensure that the elements occupy the full available width without unnecessary gaps.
  1. Check Header Layout on Large Screens (1256px width)
    • Resize the browser window to 1256px width.
    • ✅❓❌⬜ AC3: Verify that the header scales properly and elements are correctly spaced.
  1. Compare Design with Figma Specification
    • ✅❓❌⬜ AC4: Confirm that the header spacing aligns with the design in Compare contents - Header responsive.png.

QA Results - Test Wiki

Event Timeline

ngkountas triaged this task as High priority.

Change #1120502 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] Compare contents header: Fix spacing to match specifications

https://gerrit.wikimedia.org/r/1120502

ngkountas lowered the priority of this task from High to Medium.Feb 19 2025, 2:06 PM

Change #1120502 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Compare contents header: Fix spacing to match specifications

https://gerrit.wikimedia.org/r/1120502

Change #1122111 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20250224

https://gerrit.wikimedia.org/r/1122111

Change #1122111 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20250224

https://gerrit.wikimedia.org/r/1122111

Once this is completed, we may want to close T260115: Compare the contents: Responsive adaptations for larger screens since the adjustments made for this task may be all the responsive adaptation needed.

@ngkountas On the first 3 screenshots, does that count as the considerations to review and eye icon? Also when hovering on the source or target, it doesn't show the light version indicator.

UPDATE: Based off T386696#10609091, those options are out of scope. As for the task in hand, this now passes. I will move this to sign-off. Thanks for all your work!

Test Result - TestWiki

Status: ✅ PASS
Environment: TestWiki
OS: macOS Sonoma 15.3.1
Browser: Chrome 133
Device: MacBook Air

Test Artifact(s):

Test Steps

Test Case: Verify Header Spacing in the "Compare the Contents" Step

  1. Check Header Layout on Small Screens (648px width)
    • Resize the browser window to 648px width.
    • AC1: Ensure that elements do not overflow the row’s width.

2025-03-05_15-06-20.png (494×625 px, 52 KB)

  1. Check Header Layout on Medium Screens (1090px width)
    • Resize the browser window to 1090px width.
    • AC2: Ensure that the elements occupy the full available width without unnecessary gaps.

2025-03-05_15-05-45.png (477×575 px, 45 KB)

  1. Check Header Layout on Large Screens (1256px width)
    • Resize the browser window to 1256px width.
    • AC3: Verify that the header scales properly and elements are correctly spaced.

2025-03-05_15-05-20.png (469×618 px, 52 KB)

  1. Compare Design with Figma Specification
    • AC4: Confirm that the header spacing aligns with the design in Compare contents - Header responsive.png.

gif
Spacing/Measurements

✅ Desktop✅ Mobile
2025-03-05_15-01-02.mp4.gif (550×1 px, 1 MB)
2025-03-05_15-03-35.mp4.gif (514×656 px, 916 KB)

UPDATE: Not in scope from T386696#10609091
gif
❌Source and Target selector

2025-03-05_15-01-33.mp4.gif (506×1 px, 281 KB)
2025-03-05_15-11-13.png (715×810 px, 79 KB)

@GMikesell-WMF the source and target selector is out of scope for this task. This task is only about the header (the part above the "eye" icon).

GMikesell-WMF updated Other Assignee, removed: GMikesell-WMF.
GMikesell-WMF moved this task from Needs QA to Design Signoff on the LPL Hypothesis board.