RTL support in Special:Contributions link
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Feb 18 2025, 11:38 AM

Description

What is the problem?

In the Special:Contributions link below the target input, some usernames do not look correct in RTL. I think they need to be wrapped in <bdi> element like we use in other places. This particularly effects temporary account usernames, where the tilde appears on the wrong side.

I also notice that the target input does not support RTL well either. This seems to be a wider bug.

Steps to reproduce problem

https://test.wikipedia.beta.wmflabs.org/wiki/Special:Block/~2024-20310?uselang=he

Expected behaviour: The link ~תרומות של 2024-20310
Observed behaviour: The link is תרומות של ~2024-20310

Environment

Wiki(s): https://test.wikipedia.beta.wmflabs.org MediaWiki 1.44.0-alpha (4a859d0) 09:52, 18 February 2025.

Screenshots

How a temporary username looks in Special:Block:

How it should look for comparison, from the top of Special:Contributions:

Derived Requirement

The Special:Contributions link displayed below the target input on Special:Block should correctly support RTL (right-to-left) languages by ensuring usernames, particularly temporary accounts, are wrapped in a <bdi> element to maintain correct text direction.

Additionally, the target input field on Special:Block should properly support RTL input.

Test Steps

Test Case 1: Ensure Special:Contributions Link Displays Correctly in RTL

Navigate to Special:Block on an RTL-language wiki (e.g., Hebrew).
Enter a temporary username (e.g., ~2024-20310) in the target input field.
Observe the Special:Contributions link displayed below the input field.
✅❓❌⬜ AC1: Confirm that the username is correctly wrapped in a <bdi> element and appears in the correct order (e.g., ~תרומות של 2024-20310).

Test Case 2: Ensure Target Input Field Supports RTL Properly

Navigate to Special:Block on an RTL-language wiki (e.g., Hebrew).
Enter a temporary username (e.g., ~2024-20310) in the target input field.
✅❓❌⬜ AC2: Confirm that the text input aligns correctly for RTL and the tilde (~) remains on the correct side of the username.

QA Results - Test Wiki

AC	Status	Details
1	✅	T386700#10592358
2	✅	T386700#10592358

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Special:Block [Codex]: add RTL support to already blocked message	mediawiki/core	master	+4 -1
	Special:Block [Codex]: add RTL support in Special:Contributions link	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T387602: Design a CI test that can try to identify missing bidi support
Mentioned Here: rMW4a859d0d474e: Merge "feeds: Fix str_replace() deprecation warnings on PHP 8"

Event Timeline

dom_walden created this task.Feb 18 2025, 11:38 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 18 2025, 11:38 AM

A_smart_kitten added a project: RTL.Feb 18 2025, 12:26 PM

Restricted Application added a project: I18n. · View Herald TranscriptFeb 18 2025, 12:26 PM

• MusikAnimal edited projects, added Community-Tech (Sea Lion Squad); removed Community-Tech.Feb 19 2025, 10:22 PM

• MusikAnimal moved this task from Backlog to Actual multiblocks on the Multiblocks board.

• MusikAnimal edited projects, added Multiblocks (Actual multiblocks); removed Multiblocks.

• MusikAnimal moved this task from Actual multiblocks to Implement Codex Special:Block on the Multiblocks board.

• MusikAnimal edited projects, added Multiblocks (Implement Codex Special:Block); removed Multiblocks (Actual multiblocks).

• MusikAnimal set the point value for this task to 2.Feb 19 2025, 10:42 PM

• MusikAnimal moved this task from Backlog - groomed to Ready (prioritized + estimated) on the Community-Tech (Sea Lion Squad) board.

HMonroy claimed this task.Feb 20 2025, 4:27 AM

HMonroy moved this task from Ready (prioritized + estimated) to In Development on the Community-Tech (Sea Lion Squad) board.

Change #1121462 had a related patch set uploaded (by HMonroy; author: HMonroy):

[mediawiki/core@master] Special:Block [Codex]: add RTL support in Special:Contributions link

https://gerrit.wikimedia.org/r/1121462

gerritbot added a project: Patch-For-Review.Feb 20 2025, 11:26 PM

HMonroy moved this task from In Development to Feedback and Review on the Community-Tech (Sea Lion Squad) board.Feb 20 2025, 11:26 PM

dmaza subscribed.Feb 21 2025, 4:38 PM

This comment was removed by dmaza.

Change #1121462 merged by jenkins-bot:

[mediawiki/core@master] Special:Block [Codex]: add RTL support in Special:Contributions link

https://gerrit.wikimedia.org/r/1121462

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.18; 2025-02-25).Feb 21 2025, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 21 2025, 6:30 PM

@dom_walden We did notice that the username text field shows the ~ on the wrong side in RTL language as well. This is also happening in Special:Contributions so we are going to leave the username textfield alone for now.

HMonroy moved this task from Feedback and Review to QA on the Community-Tech (Sea Lion Squad) board.Feb 21 2025, 6:54 PM

GMikesell-WMF updated the task description. (Show Details)Feb 26 2025, 4:38 PM

GMikesell-WMF updated Other Assignee, added: GMikesell-WMF.

@HMonroy Question regarding AC2. The tilde is on the correct spot for the contribution link but it's not on the target search and warning. The tilde stays in the same spot even when you select the correct way in the suggestion name.

In Chrome-Minerva, it doesn't show the warning and also has the same issue with the suggestion name tilde not changing.
Firefox Monobook, no information shows up at all
Safari Timeless- name shows up on the wrong side.

Test Result - Beta|Prod

Status:❌ FAIL AC2
Environment: TestWiki
OS: macOS Sonoma 15.3.1
Browser: Chrome 133, Firefox 135, Safari 18.3
Device: MBA
Emulated Device: NA

Test Artifact(s):
https://test.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Block/~2024-20310&uselang=he
https://test.wikipedia.beta.wmflabs.org/wiki/Special:Block/~2024-20310?title=Special:Block/~2024-20310&uselang=he&useskin=monobook
https://test.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Block/~2024-20310&uselang=he&useskin=timeless

Test Steps

Test Case 1: Ensure Special:Contributions Link Displays Correctly in RTL

Navigate to Special:Block on an RTL-language wiki (e.g., Hebrew).
Enter a temporary username (e.g., ~2024-20310) in the target input field.
Observe the Special:Contributions link displayed below the input field.
✅ AC1: Confirm that the username is correctly wrapped in a <bdi> element and appears in the correct order (e.g., ~תרומות של 2024-20310).

2025-02-26_08-37-32.png (752×1 px, 150 KB)

Test Case 2: Ensure Target Input Field Supports RTL Properly

Navigate to Special:Block on an RTL-language wiki (e.g., Hebrew).
Enter a temporary username (e.g., ~2024-20310) in the target input field.
❌ AC2: Confirm that the text input aligns correctly for RTL and the tilde (~) remains on the correct side of the username.

❌Chrome- Vector

2025-02-26_08-40-32.mp4.gif (752×938 px, 522 KB)

❌Chrome- Minerva	❌Firebox- Monobook	❌Safari- Timeless

GMikesell-WMF updated the task description. (Show Details)Feb 26 2025, 5:06 PM

GMikesell-WMF moved this task from QA to In Development on the Community-Tech (Sea Lion Squad) board.

Change #1123465 had a related patch set uploaded (by HMonroy; author: HMonroy):

[mediawiki/core@master] Special:Block [Codex]: add RTL support to already blocked message

https://gerrit.wikimedia.org/r/1123465

gerritbot added a project: Patch-For-Review.Feb 27 2025, 9:03 PM

The already blocked error message also needs RTL support.

Good catch @GMikesell-WMF !

HMonroy moved this task from In Development to Feedback and Review on the Community-Tech (Sea Lion Squad) board.Feb 27 2025, 9:03 PM

Change #1123465 merged by jenkins-bot:

[mediawiki/core@master] Special:Block [Codex]: add RTL support to already blocked message

https://gerrit.wikimedia.org/r/1123465

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.19; 2025-03-04); removed MW-1.44-notes (1.44.0-wmf.18; 2025-02-25).Feb 28 2025, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Feb 28 2025, 12:30 AM

HMonroy moved this task from Feedback and Review to QA on the Community-Tech (Sea Lion Squad) board.Feb 28 2025, 2:58 AM

@HMonroy Confirmed that RTL support us now with the username and "already blocked message" as seen in the screenshots below. I will now mark this as Resolved. Thanks for all your work!
UPDATE:

Search bar tilde per conversation is fine being on the other side
Firefox- Monobook info is running.
RTL support to already blocked message

Test Result - TestWiki

Status:✅ PASS
Environment: TestWiki
OS: macOS Sonoma 15.3.1
Browser: Chrome 133, Firefox 135, Safari 18.3
Device: MBA
Emulated Device: NA

Test Steps

Test Case 1: Ensure Special:Contributions Link Displays Correctly in RTL

Navigate to Special:Block on an RTL-language wiki (e.g., Hebrew).
Enter a temporary username (e.g., ~2024-20310) in the target input field.
Observe the Special:Contributions link displayed below the input field.
✅ AC1: Confirm that the username is correctly wrapped in a <bdi> element and appears in the correct order (e.g., ~תרומות של 2024-20310).

Test Case 2: Ensure Target Input Field Supports RTL Properly

Navigate to Special:Block on an RTL-language wiki (e.g., Hebrew).
Enter a temporary username (e.g., ~2024-20310) in the target input field.
✅ AC2: Confirm that the text input aligns correctly for RTL and the tilde (~) remains on the correct side of the username.

Search bar is fine how it is but the RTL support to already blocked message is now woking