"TypeError: document.querySelector(...) is null" loading block by ID
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Feb 18 2025, 11:57 AM

Project Tags

Referenced Files

	F58436749: 2025-02-20_11-38-50.mp4.gif
	Feb 20 2025, 7:49 PM

	F58436745: 2025-02-20_11-36-02.mp4.gif
	Feb 20 2025, 7:49 PM

	F58436743: 2025-02-20_11-44-56.mp4.gif
	Feb 20 2025, 7:49 PM

	F12: project.png
	Feb 20 2025, 7:41 PM
	File Not Attached

Subscribers

Description

What is the problem?

When loading Special:Block?id=<id>, I sometimes see this in the console:

Uncaught (in promise) TypeError: document.querySelector(...) is null
    highlightSelectedBlockRow http://enwiki.localhost:8080/w/load.php?lang=en&modules=mediawiki.special.block.codex&skin=vector-2022&version=ild8z:49
    promise callback*nextTick jQuery
    highlightSelectedBlockRow http://enwiki.localhost:8080/w/load.php?lang=en&modules=mediawiki.special.block.codex&skin=vector-2022&version=ild8z:49
    setup http://enwiki.localhost:8080/w/load.php?lang=en&modules=mediawiki.special.block.codex&skin=vector-2022&version=ild8z:49
    jQuery 14
    loadFromData http://enwiki.localhost:8080/w/load.php?lang=en&modules=mediawiki.special.block.codex&skin=vector-2022&version=ild8z:6
    wrapAction http://enwiki.localhost:8080/w/load.php?lang=en&modules=pinia&skin=vector-2022&version=150k1:29
    setup http://enwiki.localhost:8080/w/load.php?lang=en&modules=mediawiki.special.block.codex&skin=vector-2022&version=ild8z:47
    jQuery 17
    xhr http://enwiki.localhost:8080/w/load.php?lang=en&modules=mediawiki.api&skin=vector-2022&version=1n285:4
    fire jQuery
load.php:49:366
    highlightSelectedBlockRow http://enwiki.localhost:8080/w/load.php?lang=en&modules=mediawiki.special.block.codex&skin=vector-2022&version=ild8z:49
    (Async: promise callback)
    nextTick jQuery
    highlightSelectedBlockRow http://enwiki.localhost:8080/w/load.php?lang=en&modules=mediawiki.special.block.codex&skin=vector-2022&version=ild8z:49
    setup http://enwiki.localhost:8080/w/load.php?lang=en&modules=mediawiki.special.block.codex&skin=vector-2022&version=ild8z:49
    jQuery 14
    loadFromData http://enwiki.localhost:8080/w/load.php?lang=en&modules=mediawiki.special.block.codex&skin=vector-2022&version=ild8z:6
    wrapAction http://enwiki.localhost:8080/w/load.php?lang=en&modules=pinia&skin=vector-2022&version=150k1:29
    setup http://enwiki.localhost:8080/w/load.php?lang=en&modules=mediawiki.special.block.codex&skin=vector-2022&version=ild8z:47
    jQuery 17
    xhr http://enwiki.localhost:8080/w/load.php?lang=en&modules=mediawiki.api&skin=vector-2022&version=1n285:4
    fire jQuery

Steps to reproduce problem

Open browser console, login to beta as an admin and go to https://test.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Block/~2024-20310&id=232

Environment

Browser: Firefox 128. Chromium 133.
Wiki(s): https://test.wikipedia.beta.wmflabs.org MediaWiki 1.44.0-alpha (4a859d0) 09:52, 18 February 2025.

Derived Requirement

Ensure that loading Special:Block?id=<id> does not produce a TypeError: document.querySelector(...) is null in the browser console, and the corresponding block is correctly highlighted.

Test Steps

Test Case 1: Ensure No TypeError When Loading Special:Block by ID

Open the browser console (F12 → Console tab).
Log in to testwiki as an admin.
Navigate to https://test.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Block/~2024-20310&id=232.
✅❓❌⬜ AC1: Confirm that no TypeError: document.querySelector(...) is null appears in the console and block form loads correctly without errors.

QA Results - Test Wiki

AC	Status	Details
1	✅	T386701#10569190

Related Objects

Mentioned Here: T383846: Highlight current block row when editing or removing
rMW4a859d0d474e: Merge "feeds: Fix str_replace() deprecation warnings on PHP 8"

Event Timeline

dom_walden created this task.Feb 18 2025, 11:57 AM

Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptFeb 18 2025, 11:57 AM

MusikAnimal edited projects, added: Community-Tech (Sea Lion Squad); removed: Community-Tech.Feb 19 2025, 10:21 PM

MusikAnimal moved this task from Backlog to Actual multiblocks on the Multiblocks board.

MusikAnimal edited projects, added: Multiblocks (Actual multiblocks); removed: Multiblocks.

MusikAnimal moved this task from Actual multiblocks to Implement Codex Special:Block on the Multiblocks board.

MusikAnimal edited projects, added: Multiblocks (Implement Codex Special:Block); removed: Multiblocks (Actual multiblocks).

MusikAnimal set the point value for this task to 1.Feb 19 2025, 10:40 PM

MusikAnimal moved this task from Backlog - groomed to Ready (prioritized + estimated) on the Community-Tech (Sea Lion Squad) board.

• HMonroy moved this task from Ready (prioritized + estimated) to Feedback and Review on the Community-Tech (Sea Lion Squad) board.Feb 20 2025, 12:19 AM

• HMonroy moved this task from Feedback and Review to QA on the Community-Tech (Sea Lion Squad) board.

I wasn't able to replicate this anymore. I believe it was fixed by T383846: Highlight current block row when editing or removing.

• HMonroy claimed this task.Feb 20 2025, 12:22 AM

GMikesell-WMF updated the task description. (Show Details)Feb 20 2025, 7:41 PM

GMikesell-WMF updated Other Assignee, added: GMikesell-WMF.

@HMonroy Confirmed that no TypeError: document.querySelector(...) is null appears in the console and block form loads correctly without errors as seen in the gifs below. With not being able to recreate it and T386701#10566136, I will put this as Resolved, thanks!
being able
Test Result - TestWiki

Status: ✅ PASS
Environment: TestWiki
OS: macOS Sonoma 15.3.1
Browser: Chrome 133, Firefox 135, Safari 18.3
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure No TypeError When Loading Special:Block by ID

Open the browser console (F12 → Console tab).
Log in to testwiki as an admin.
Navigate to https://test.wikipedia.beta.wmflabs.org/w/index.php?title=Special:Block/~2024-20310&id=232.
✅ AC1: Confirm that no TypeError: document.querySelector(...) is null appears in the console and block form loads correctly without errors.