Page MenuHomePhabricator

Consider removal of $wgAddGroups and $wgRemoveGroups added for the event-organizer group in WMF config
Closed, ResolvedPublic

Description

As part of T376822, and especially T376822#10542726, I added explicit overrides for $wgAddGroups and $wgRemoveGroups to the WMF config. At the same time, I found T386210, a core bug which prevented $wgAddGroups and $wgRemoveGroups entries from extension.json files from being properly merged in.

In T376822#10544346 I theorized that the production bug was due to the WMF config setting, instead of merging, the $wgAddGroups and $wgRemoveGroups arrays. However, on second thought, this shouldn't make any difference, because settings from extension.json files are applied after WMF config. So, my current thinking is that T386210 wasn't a related bug, but rather the primary cause of the issue observed in production. If this is indeed the case, and local testing seems to confirm it, we will be able to revert r1119136, removing the WMF config overrides, as soon as wmf.17 reaches all wikis. If not, this task can be closed as invalid, and its author be told that he has a poor understanding of how MW config works.

Event Timeline

Change #1124879 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[operations/mediawiki-config@master] Revert "Let sysops add/remove the event-organizer group by default"

https://gerrit.wikimedia.org/r/1124879

composer diffConfig confirms that we can go ahead with the revert. Scheduled for tomorrow 2025-03-06 14:00 UTC.

Change #1124879 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "Let sysops add/remove the event-organizer group by default"

https://gerrit.wikimedia.org/r/1124879

Mentioned in SAL (#wikimedia-operations) [2025-03-06T14:56:06Z] <hashar@deploy2002> Started scap sync-world: Backport for [[gerrit:1120180|[Growth] Set default api lookahead size to 10 (T325990)]], [[gerrit:1124879|Revert "Let sysops add/remove the event-organizer group by default" (T386738)]], [[gerrit:1122990|Remove unused route file from Wikibase REST API configuration (T383774)]]

Mentioned in SAL (#wikimedia-operations) [2025-03-06T14:58:49Z] <hashar@deploy2002> hashar, sgimeno, itamar, daimona: Backport for [[gerrit:1120180|[Growth] Set default api lookahead size to 10 (T325990)]], [[gerrit:1124879|Revert "Let sysops add/remove the event-organizer group by default" (T386738)]], [[gerrit:1122990|Remove unused route file from Wikibase REST API configuration (T383774)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2025-03-06T15:20:34Z] <hashar@deploy2002> Started scap sync-world: Backport for [[gerrit:1120180|[Growth] Set default api lookahead size to 10 (T325990)]], [[gerrit:1124879|Revert "Let sysops add/remove the event-organizer group by default" (T386738)]], [[gerrit:1122990|Remove unused route file from Wikibase REST API configuration (T383774)]]

Mentioned in SAL (#wikimedia-operations) [2025-03-06T15:24:26Z] <hashar@deploy2002> itamar, sgimeno, daimona, hashar: Backport for [[gerrit:1120180|[Growth] Set default api lookahead size to 10 (T325990)]], [[gerrit:1124879|Revert "Let sysops add/remove the event-organizer group by default" (T386738)]], [[gerrit:1122990|Remove unused route file from Wikibase REST API configuration (T383774)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2025-03-06T15:30:58Z] <hashar@deploy2002> Finished scap sync-world: Backport for [[gerrit:1120180|[Growth] Set default api lookahead size to 10 (T325990)]], [[gerrit:1124879|Revert "Let sysops add/remove the event-organizer group by default" (T386738)]], [[gerrit:1122990|Remove unused route file from Wikibase REST API configuration (T383774)]] (duration: 10m 23s)

Only thing to test is that admins are still able to assign and remove the event organizer group, like before.

enigfr
Screenshot 2025-03-10 at 4.45.50 PM.png (1,762×260 px, 96 KB)
Screenshot 2025-03-10 at 4.46.16 PM.png (1,916×176 px, 75 KB)
Screenshot 2025-03-10 at 4.46.38 PM.png (2,020×166 px, 84 KB)
esarzh
Screenshot 2025-03-10 at 4.47.02 PM.png (1,622×142 px, 65 KB)
Screenshot 2025-03-10 at 4.47.22 PM.png (1,118×120 px, 46 KB)
Screenshot 2025-03-10 at 4.56.18 PM.png (1,724×222 px, 85 KB)
uams wiktionaryms wikipedia
Screenshot 2025-03-10 at 5.58.24 PM.png (1,864×168 px, 77 KB)
Screenshot 2025-03-10 at 5.59.17 PM.png (1,720×166 px, 71 KB)
Screenshot 2025-03-10 at 6.00.00 PM.png (1,702×162 px, 71 KB)
metaigtest
Screenshot 2025-03-10 at 6.01.16 PM.png (1,704×156 px, 72 KB)
Screenshot 2025-03-10 at 6.02.58 PM.png (1,846×164 px, 74 KB)
Screenshot 2025-03-10 at 6.06.16 PM.png (1,500×148 px, 62 KB)
br
Screenshot 2025-03-10 at 6.09.22 PM.png (1,988×170 px, 79 KB)

event-organizer group exists and contains campaignevents-email-participants, campaignevents-enable-registration, and campaignevents-organize-events. I don't have admin access so cant test this further, but it looks correct from what I can see on the wikis in T386738#10621534 above. Sending to product sign off