Page MenuHomePhabricator

Links within warning templates are not shown on mobile
Closed, InvalidPublicBUG REPORT

Description

Steps to replicate the issue:

What happens?:

  • The links are not shown. They do exist, but are in the same text color as the rest of the sentence.

What should have happened instead?:

  • Visible link

Relevant code from browser-inspector
(If we toggle this off, the link appears)

.client-js body.skin-minerva .mw-parser-output .ambox a { 
color: inherit !important;
}

Screenshot

image.png (1,195×665 px, 197 KB)

original report:

Event Timeline

Jdlrobson-WMF subscribed.

The whole banner is clickable so we intentionally change the styling of links to avoid confusion that clicking them will take you to a page instead of opening the associated overlay.

We should update https://www.mediawiki.org/wiki/Recommendations_for_mobile_friendly_articles_on_Wikimedia_wikis#Mark_the_text_portion_of_an_issue to make it clearer that the title of the issue should not contain any links - they should only live in the description (how to fix the issue). You have to click the banner to see and follow the link.

@Jdlrobson, can you explain in simpler terms what your suggested resolution to this issue is? If I'm understanding correctly, you're suggesting that clicking on the banner on mobile should always just open up the full banner, not follow any of the links (and that if someone wants to follow a link they should click it once the full banner is open). That makes sense to me. But it's not how warning templates currently work, since right now you can click on links directly without opening the full banner. And it's not clear to me what needs to be changed so that you can no longer do so.

@Jdlrobson-WMF, ah, I was also running into the issue of the overall banner not working, so appreciate you identifying the issue with that and creating a task for it! But I was asking above specifically about the linking issue from this ticket. Can you help me understand that better?

The intention of the banner is to summarize the issue in as few words as possible to encourage the editor to be intrigued enough to "learn more" and understand the issue.

In the example clicking on "lead section" should open the overlay not the lead section link. This is because the banner itself is a large (transparent) link that covers the entire touch area. If it looked like a link that would be confusing as it wouldn't work like a link. ie. the links are only accessible once you click "learn more" and click on them in the banner. Does that make sense?

pageissues.gif (600×797 px, 108 KB)

@Jdlrobson-WMF, yes, that makes sense. We're on the same page then in terms of the preferred resolution. Given that, though, I'm not sure why the task is marked as invalid. Since the current behavior is that clicking opens, in the example, the lead section link. So something needs to change to produce the behavior we're both seeking.

@Jdlrobson-WMF, yes, that makes sense. We're on the same page then in terms of the preferred resolution. Given that, though, I'm not sure why the task is marked as invalid. Since the current behavior is that clicking opens, in the example, the lead section link. So something needs to change to produce the behavior we're both seeking.

Yes that will be fixed as part of T386873 ! We can merge the two as duplicates if that's clearer.