If one of the selected images includes a protected page that the user can't edit, the API returns an error and the in-progress dialog stays open forever.
Steps to replicate the issue (include links if applicable):
- Enable Cat-a-lot from preferences
- Open category Category:Cat-a-lot test images with protected file File:IOS Client upload testing image 607DD0EE-AF12-4BD4-AE74-12FA1896B124.jpg
- Open Cat-a-lot dialog from right-bottom-corner
- Click to select file protected file File:IOS Client upload testing image 607DD0EE-AF12-4BD4-AE74-12FA1896B124.jpg
- Remove the category Category:Cat-a-lot test images from protected file File:IOS Client upload testing image 607DD0EE-AF12-4BD4-AE74-12FA1896B124.jpg using Cat-a-lot
What happens?:
- API returns error, which is handled incorrectly (program doesn't crash but it fails to continue)
- in-progress dialog stays open forever
What should have happened instead?:
- There should have been notification for the error with possibility to ignore it and continue editing
TODO:
Investigate where the editing request error handling occurs:
- Check MediaWiki:Gadget-libAPI.js (where actual editing API requests are made)
- Check MediaWiki:Gadget-Cat-a-lot.js
Based on findings:
If error handling is in Cat-a-lot.js:
- Add proper error handling code to display a dialog with options to ignore the error or cancel editing
If error handling is in Gadget-libAPI.js and it doesn't return to Cat-a-lot.js:
- Document the code behavior in the ticket


