SqliteMaintenance TypeError: SqliteMaintenance::vacuum(): Argument #1 ($dbw) must be of type Wikimedia\Rdbms\Databa seSqlite, Wikimedia\Rdbms\DBConnRef given
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Un1Gfn
	Feb 20 2025, 5:30 AM

Project Tags

Referenced Files

None

Subscribers

Aklapper

Umherirrender

Un1Gfn

Description

SqliteMaintenance

cd /usr/share/webapps/mediawiki/maintenance
sudo -u apache -g apache php ./run.php SqliteMaintenance --vacuum --integrity

Error

[bd237d1cef6d626ee1badfac] [no req]   TypeError: SqliteMaintenance::vacuum(): Argument #1 ($dbw) must be of type Wikimedia\Rdbms\Databa
seSqlite, Wikimedia\Rdbms\DBConnRef given, called in /usr/share/webapps/mediawiki/maintenance/SqliteMaintenance.php on line 68 
Backtrace: 
from /usr/share/webapps/mediawiki/maintenance/SqliteMaintenance.php(80) 
#0 /usr/share/webapps/mediawiki/maintenance/SqliteMaintenance.php(68): SqliteMaintenance->vacuum() 
#1 /usr/share/webapps/mediawiki/maintenance/includes/MaintenanceRunner.php(703): SqliteMaintenance->execute() 
#2 /usr/share/webapps/mediawiki/maintenance/run.php(51): MediaWiki\Maintenance\MaintenanceRunner->run() 
#3 {main}

Info

fedora linux f41

mediawiki 1.43
*** i did not patch mediawiki source code except shebangs ***
spec <https://github.com/Un1Gfn/copr/blob/main/mediawiki-x/mediawiki-x.spec>
build <https://copr.fedorainfracloud.org/coprs/ps3taa/mq3rbu/build/8672152/>


php-fpm --version
PHP 8.3.16 (fpm-fcgi) (built: Jan 14 2025 18:25:29)
Copyright (c) The PHP Group
Zend Engine v4.3.16, Copyright (c) Zend Technologies
    with Zend OPcache v8.3.16, Copyright (c), by Zend Technologies

support desk https://www.mediawiki.org/wiki/Project:Support_desk#SqliteMaintenance_TypeError

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Revert "maintenance: Use DatabaseSqlite for type-hinting instead of DBConnRef"	mediawiki/core	REL1_43	+6 -7
	Revert "maintenance: Use DatabaseSqlite for type-hinting instead of DBConnRef"	mediawiki/core	master	+6 -7

Customize query in gerrit

Event Timeline

Un1Gfn created this task.Feb 20 2025, 5:30 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 20 2025, 5:30 AM

Un1Gfn updated the task description. (Show Details)Feb 20 2025, 5:30 AM

Un1Gfn updated the task description. (Show Details)Feb 20 2025, 5:33 AM

hello @Umherirrender

I had no problem running 1.42.1

Issue appears after upgrading to 1.43.0

Correct me if I'm wrong but this commit seems related

Please help me adapt my database. Thanks

excerpt

# in maintenance/SqliteMaintenance.php execute(){}
...
$dbw = getMaintenanceConnectionRef()
...
SqliteMaintenance::vacuum( $dbw )
...

It seems that

getMaintenanceConnectionRef() return a Wikimedia\Rdbms\DBConnRef
SqliteMaintenance::vacuum() wants a Wikimedia\Rdbms\DatabaseSqlite
incompatible

Tried moving all sqlite database elsewhere and re-generating blank wiki.

Issue persists.

Bug?

Nemoralis added a project: MediaWiki-Maintenance-system.Feb 20 2025, 8:25 AM

Aklapper renamed this task from SqliteMaintenance TypeError to SqliteMaintenance TypeError: SqliteMaintenance::vacuum(): Argument #1 ($dbw) must be of type Wikimedia\Rdbms\Databa seSqlite, Wikimedia\Rdbms\DBConnRef given.Feb 20 2025, 6:36 PM

Aklapper added a project: SQLite.

Change #1121421 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Revert "maintenance: Use DatabaseSqlite for type-hinting instead of DBConnRef"

https://gerrit.wikimedia.org/r/1121421

gerritbot added a project: Patch-For-Review.Feb 20 2025, 7:28 PM

Change #1121421 merged by jenkins-bot:

[mediawiki/core@master] Revert "maintenance: Use DatabaseSqlite for type-hinting instead of DBConnRef"

https://gerrit.wikimedia.org/r/1121421

Maintenance_bot removed a project: Patch-For-Review.Feb 20 2025, 8:30 PM

Change #1121433 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_43] Revert "maintenance: Use DatabaseSqlite for type-hinting instead of DBConnRef"

https://gerrit.wikimedia.org/r/1121433

gerritbot added a project: Patch-For-Review.Feb 20 2025, 8:35 PM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.18; 2025-02-25).Feb 20 2025, 9:00 PM

Change #1121433 merged by jenkins-bot:

[mediawiki/core@REL1_43] Revert "maintenance: Use DatabaseSqlite for type-hinting instead of DBConnRef"

https://gerrit.wikimedia.org/r/1121433

I have revert the change.

Maintenance_bot removed a project: Patch-For-Review.Feb 20 2025, 9:30 PM

ReleaseTaggerBot added a project: MW-1.43-notes.Feb 20 2025, 10:00 PM

SqliteMaintenance TypeError: SqliteMaintenance::vacuum(): Argument #1 ($dbw) must be of type Wikimedia\Rdbms\Databa seSqlite, Wikimedia\Rdbms\DBConnRef givenClosed, ResolvedPublicBUG REPORTActions

Description

Details

Event Timeline

SqliteMaintenance TypeError: SqliteMaintenance::vacuum(): Argument #1 ($dbw) must be of type Wikimedia\Rdbms\Databa seSqlite, Wikimedia\Rdbms\DBConnRef given
Closed, ResolvedPublicBUG REPORT
Actions