Page MenuHomePhabricator

Temporary accounts onboarding dialog: Update content of third (IP reveal) step to clarify not all users need to check a preference
Closed, ResolvedPublic

Description

Summary

The Temporary Accounts onboarding dialog has a third step that describes IP reveal. The content of this step says that users need to enable a preference to use IP reveal. This is not the case for some users, and we should clarify the text to make this clear.

Background

  • The temporary accounts onboarding dialog has a third step that describes IP reveal and the prerequisites for using this
  • This step describes that the user needs to enable the preference to have access to the tool
    • This is the case for most users, but not users who have the checkuser-temporary-account-no-preference right
  • The content of the step should be updated to make this clearer

New step content

The IP Reveal feature allows admins, vandal fighters and experienced users to reveal the IP associated with a temporary account.

Users who meet the access requirements may need to enable IP reveal in their [[Special:Preferences#mw-prefsection-personal-checkuser-tempaccount|preferences]] or [[Special:GlobalPreferences#mw-prefsection-personal-checkuser-tempaccount|global preferences]]. Once enabled, the "Show IP" button will be displayed next to temporary accounts.

Technical notes

  • We will need two versions of the message, where one mentions global preferences and the other which does not
  • There are WikimediaMessages overrides which will also need updating

Acceptance criteria

  • Update the step content to the new content
  • Update the WikimediaMessages overrides for the step content

Event Timeline

Change #1153280 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Link to Special:GlobalPreferences for IP reveal in onboarding dialog

https://gerrit.wikimedia.org/r/1153280

Change #1153283 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/WikimediaMessages@master] Update temporary account IP reveal onboarding dialog overrides

https://gerrit.wikimedia.org/r/1153283

Change #1153280 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Link to Special:GlobalPreferences for IP reveal in onboarding dialog

https://gerrit.wikimedia.org/r/1153280

Change #1153283 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Update temporary account IP reveal onboarding dialog overrides

https://gerrit.wikimedia.org/r/1153283

Djackson-ctr subscribed.

During my testing of this ticket:
I am not seeing the correct verbiage for the New Step Content per the ticket Description, the verbiage in the ticket Description shows as:

Users who meet the access requirements may need to enable IP reveal in their [[Special:Preferences#mw-prefsection-personal-checkuser-tempaccount|preferences]] or [[Special:GlobalPreferences#mw-prefsection-personal-checkuser-tempaccount|global preferences]].

My testing is displaying the verbiage as:

Users who meet the access requirements can enable IP reveal in their [[Special:Preferences#mw-prefsection-personal-checkuser-tempaccount|preferences]] or [[Special:GlobalPreferences#mw-prefsection-personal-checkuser-tempaccount|global preferences]].

image.png (773×851 px, 108 KB)

Since William is on vacation next week I will push this ticket back to Review just in case an engineer wanted to troubleshoot the issue.

Change #1154770 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/WikimediaMessages@master] Fix message overrides for IP reveal onboarding dialog

https://gerrit.wikimedia.org/r/1154770

Change #1154770 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Fix message overrides for IP reveal onboarding dialog

https://gerrit.wikimedia.org/r/1154770

Using localhost for testing:
The new code changes have been verified and are functioning as expected (3rd step verbiage has been updated)... Thank you @Tchanders and @Dreamy_Jazz.


Screenshot of 3rd step of Onboarding Dialog with updated verbiage for Global Preferences:

image.png (696×915 px, 103 KB)


Screenshot of 3rd step of Onboarding Dialog with updated verbiage without Global Preferences:

image.png (689×870 px, 97 KB)