Page MenuHomePhabricator
Create Task
Maniphest T387004

Improve platform detection to make sure the desktop editor is used on the desktop site regardless of the viewport size
Closed, ResolvedPublic
Actions

Assigned To
SBisson
Authored By
Pginer-WMF
Feb 21 2025, 9:54 AM
Tags
Referenced Files
F58821839: 2025-03-13_16-10-21.mp4.gif
Mar 13 2025, 11:33 PM
F58821847: 2025-03-13_16-16-45.mp4.gif
Mar 13 2025, 11:33 PM
F58810638: 2025-03-12_17-07-34.mp4.gif
Mar 13 2025, 12:10 AM
F58810631: 2025-03-12_17-05-50.mp4.gif
Mar 13 2025, 12:10 AM
F58810614: 2025-03-12_16-59-47.mp4.gif
Mar 13 2025, 12:10 AM
F58442061: Kapture 2025-02-21 at 10.46.53.webm
Feb 21 2025, 9:54 AM
Subscribers
• Agusbou2015
Aklapper
Firestar464
GMikesell-WMF
He7d3r
Jdlrobson
Jony
View All 18 Subscribers

Description

As part of T328936, the confirmation step decides whether to use the desktop or mobile editor depending on the platform. In T337917, fixes were made to make sure that on the mobile site (with a ".m" in the url), the mobile editor is used (even if the viewport is wider).

However, currently on desktop the unified dashboard seems to redirect to editors based on the viewport size. That is, on a narrow window, the user is taken to the mobile editor (to an infinite loading state, maybe because some inconsistencies in the platform detection assumptions).

This ticket proposes to make sure the desktop editor is used on the desktop site regardless of the viewport size. Given that it is not possible to transition seamlessly between the mobile and desktop editors when adjusting the window size, it is preferred to provide each editor based on platform detection.`

Derived Requirement

Ensure that the desktop editor is always used on the desktop site, regardless of viewport size, to prevent incorrect redirections to the mobile editor.

Test Steps

Test Case 1: Ensure desktop editor is used on desktop site regardless of viewport size

  1. Open Wikipedia on a desktop browser and navigate to the desktop site (ensure no ".m" in the URL).
  2. Initiate an edit action to open the editor.
  3. ✅❓❌⬜ AC1: Confirm that the desktop editor loads.
  4. Resize the browser window to a narrow viewport.
  5. ✅❓❌⬜ AC2: Confirm that the editor remains the desktop editor without switching to the mobile editor or entering an infinite loading state.

Test Case 2: Ensure mobile editor is used on mobile site regardless of viewport size

  1. Open Wikipedia on a mobile browser or manually navigate to the mobile site (with ".m" in the URL).
  2. Initiate an edit action to open the editor.
  3. ✅❓❌⬜ AC3: Confirm that the mobile editor loads.
  4. Resize the browser window to a wider viewport.
  5. ✅❓❌⬜ AC4: Confirm that the editor remains the mobile editor without switching to the desktop editor.

QA Results - Test Wiki

ACStatusDetails
1✅T387004#10635139
2✅T387004#10635139
3✅T387004#10635139
4✅T387004#10635139

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
CX3 Build 0.2.0+20250303mediawiki/extensions/ContentTranslationmaster+5 K -5 K
Select editor based on site (mobile vs. desktop)mediawiki/extensions/ContentTranslationmaster+32 -157
Customize query in gerrit

Related Objects
Search...

Event Timeline

Pginer-WMF created this task.Feb 21 2025, 9:54 AM
Pginer-WMF triaged this task as High priority.Feb 25 2025, 2:14 PM
Pginer-WMF moved this task from Backlog to Prioritized on the LPL Hypothesis board.
SBisson claimed this task.Feb 25 2025, 2:29 PM
SBisson moved this task from Prioritized to In-progress on the LPL Hypothesis board.
gerritbot added a comment.Feb 25 2025, 7:56 PM

Change #1122652 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/ContentTranslation@master] Select editor based on site (mobile vs. desktop)

https://gerrit.wikimedia.org/r/1122652

gerritbot added a project: Patch-For-Review.Feb 25 2025, 7:56 PM
SBisson moved this task from In-progress to Needs Code Review on the LPL Hypothesis board.Feb 25 2025, 7:56 PM
gerritbot added a comment.Feb 26 2025, 2:18 PM

Change #1122652 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Select editor based on site (mobile vs. desktop)

https://gerrit.wikimedia.org/r/1122652

SBisson moved this task from Needs Code Review to Pending deployment on the LPL Hypothesis board.Feb 26 2025, 2:24 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 26 2025, 2:30 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.19; 2025-03-04).Feb 26 2025, 3:00 PM
Nikerabbit moved this task from Needs Triage to Enhancements on the ContentTranslation board.Feb 27 2025, 9:09 AM
gerritbot added a comment.Mar 3 2025, 4:11 PM

Change #1124141 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20250303

https://gerrit.wikimedia.org/r/1124141

gerritbot added a project: Patch-For-Review.Mar 3 2025, 4:11 PM
gerritbot added a comment.Mar 3 2025, 5:36 PM

Change #1124141 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20250303

https://gerrit.wikimedia.org/r/1124141

Maintenance_bot removed a project: Patch-For-Review.Mar 3 2025, 6:33 PM
ngkountas moved this task from Pending deployment to Needs QA on the LPL Hypothesis board.Mar 7 2025, 10:18 AM
GMikesell-WMF updated Other Assignee, added: GMikesell-WMF.Mar 12 2025, 11:55 PM
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF subscribed.Mar 13 2025, 12:10 AM

@SBisson I just have a quick question regarding AC2 and AC4. Is it considered mobile only when the URL adds ".m" or when the Suggestion, In Progress and Published switches to the bottom like a mobile device.

Test Result - TestWiki

Status: ✅ PASS / ❓Need More Info
Environment: TestWiki
OS: macOS Sonoma 15.3.1
Browser: Chrome 134
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure desktop editor is used on desktop site regardless of viewport size

  1. Open Wikipedia on a desktop browser and navigate to the desktop site (ensure no ".m" in the URL).
  2. Initiate an edit action to open the editor.
  3. ✅ AC1: Confirm that the desktop editor loads.

2025-03-12_16-59-47.mp4.gif (818×1 px, 1 MB)

  1. Resize the browser window to a narrow viewport.
  2. ❓*AC2:** Confirm that the editor remains the desktop editor without switching to the mobile editor or entering an infinite loading state.

Is this considered going into mobile mode when Suggestion, In Progress and Published switches to the bottom or is it only when URL adds ".m"?

See AC1

Test Case 2: Ensure mobile editor is used on mobile site regardless of viewport size

  1. Open Wikipedia on a mobile browser or manually navigate to the mobile site (with ".m" in the URL).
  2. Initiate an edit action to open the editor.
  3. ✅ AC3: Confirm that the mobile editor loads.

Desktop switches to mobile when you view it on a mobile device

2025-03-12_17-05-50.mp4.gif (690×1 px, 1 MB)

  1. Resize the browser window to a wider viewport.
  2. ❓ AC4: Confirm that the editor remains the mobile editor without switching to the desktop editor.

Vice versa, when you have ".m" if you widen it

2025-03-12_17-07-34.mp4.gif (670×1 px, 1 MB)

GMikesell-WMF updated the task description. (Show Details)Mar 13 2025, 12:11 AM
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF moved this task from Needs QA to In-progress on the LPL Hypothesis board.
SBisson added a comment.Mar 13 2025, 8:36 PM
In T387004#10631257, @GMikesell-WMF wrote:

@SBisson I just have a quick question regarding AC2 and AC4. Is it considered mobile only when the URL adds ".m" or when the Suggestion, In Progress and Published switches to the bottom like a mobile device.

For the purpose of this task and others that have been in play recently, "mobile" means that we are on the mobile site. In production, this is visible via the ".m" subdomain in the URL but be aware that this is going away and eventually both mobile and desktop sites are going to be served from the same URL (without the ".m").

If you are using mobile emulation in your browser, it is important to reload the page after switching mode so that the site is in the right mode.

Both dashboards are also responsive and their layout adjusts to the screen width but this is independent from the site mode. For instance, an iPad would be served the mobile site but the dashboard layout may end up being the same as a small laptop, which would get the desktop site.

SBisson moved this task from In-progress to Needs QA on the LPL Hypothesis board.Mar 13 2025, 8:51 PM
GMikesell-WMF added a comment.Mar 13 2025, 11:33 PM

@SBisson Confirmed that the desktop editor loads even when narrow. Also confirmed mobile stays mobile the whole way through as seen in screenshots and gifs. I will move this to sign-off. Thanks for all your work!

Test Result - TestWiki

Status: ✅ PASS
Environment: TestWiki
OS: macOS Sonoma 15.3.1
Browser: Chrome 134
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure desktop editor is used on desktop site regardless of viewport size

  1. Open Wikipedia on a desktop browser and navigate to the desktop site (ensure no ".m" in the URL).
  2. Initiate an edit action to open the editor.
  3. ✅ AC1: Confirm that the desktop editor loads.

2025-03-13_16-16-45.mp4.gif (814×1 px, 2 MB)

  1. Resize the browser window to a narrow viewport.
  2. ✅ *AC2:** Confirm that the editor remains the desktop editor without switching to the mobile editor or entering an infinite loading state.

See AC1

Test Case 2: Ensure mobile editor is used on mobile site regardless of viewport size

  1. Open Wikipedia on a mobile browser or manually navigate to the mobile site (with ".m" in the URL).
  2. Initiate an edit action to open the editor.
  3. ✅ AC3: Confirm that the mobile editor loads.

2025-03-12_17-05-50.mp4.gif (690×1 px, 1 MB)

  1. Resize the browser window to a wider viewport.
  2. ✅ AC4: Confirm that the editor remains the mobile editor without switching to the desktop editor.
iPad Mini
2025-03-13_16-10-21.mp4.gif (838×1 px, 1 MB)
GMikesell-WMF updated Other Assignee, removed: GMikesell-WMF.Mar 13 2025, 11:34 PM
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF moved this task from Needs QA to Design Signoff on the LPL Hypothesis board.
SBisson mentioned this in T387696: VE fails to load when section translation is started in desktop site with narrow browser window.Mar 18 2025, 6:01 PM
Pginer-WMF moved this task from Design Signoff to Product Signoff on the LPL Hypothesis board.Mar 24 2025, 2:16 PM
• PWaigi-WMF closed this task as Resolved.Mar 25 2025, 6:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits