Page MenuHomePhabricator

Codex Special:Block: Empty state of active blocks no longer appears
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:

The "Active blocks" accordion shows the "Add block" button and nothing else.

Screenshot from 2025-02-21 18-22-42.png (168×1 px, 8 KB)

What should have happened instead?:

The empty state with the message "No active blocks found" should be shown, as it was before.

Screenshot from 2025-02-21 18-22-19.png (247×1 px, 13 KB)

Other information (browser name/version, screenshots, etc.):

In working on T383846, we made use of the Codex Table component's tbody slot to more easily conditionally add CSS classes to rows. It would seem the empty-state slot is ignored when tbody is used.

Derived Requirement

The Special:Block page should correctly display the empty state message in the Active blocks section when a user has no active blocks, ensuring that:

  • When viewing Special:Block for a user who is not currently blocked, the Active blocks section should display the message: "No active blocks found" instead of just showing the "Add block" button.
  • The empty-state message should not be ignored when using the Codex Table component's tbody slot.
Test Steps

Test Case 1: Ensure Empty State Message Appears for Users Without Active Blocks

  1. Go to Special:Block for a user who is not currently blocked (e.g., Special:Block/~2024-22972).
  2. Scroll to the Active blocks section.
  3. ✅❓❌⬜ AC1: Confirm that the message "No active blocks found" is displayed instead of just showing the "Add block" button.

QA Results - Test Wiki

ACStatusDetails
1T387051#10587809

Details

Event Timeline

Change #1122272 had a related patch set uploaded (by HMonroy; author: HMonroy):

[mediawiki/core@master] Special:Block [Codex]: Added empty state for active blocks

https://gerrit.wikimedia.org/r/1122272

Change #1122272 merged by jenkins-bot:

[mediawiki/core@master] Special:Block [Codex]: Added empty state for active blocks

https://gerrit.wikimedia.org/r/1122272

@HMonroy Confirmed that the message "No active blocks found" is displayed instead of just showing the "Add block" button as seen in the screenshots below. I will mark this as Resolved. Thanks for all your work!

Test Result - TestWiki

Status: ✅ PASS
Environment: TestWiki
OS: macOS Sonoma 15.3.1
Browser: Chrome 133, Firefox 135, Safari 18.3
Device: MBA
Emulated Device: NA

Test Artifact(s):

https://test.wikipedia.beta.wmflabs.org/wiki/Special:Block/~2024-22972

Test Steps

Test Case 1: Ensure Empty State Message Appears for Users Without Active Blocks

  1. Go to Special:Block for a user who is not currently blocked (e.g., Special:Block/~2024-22972).
  2. Scroll to the Active blocks section.
  3. AC1: Confirm that the message "No active blocks found" is displayed instead of just showing the "Add block" button.
Chrome- VectorChrome- MinervaFirebox- MonobookSafari- Timeless
2025-02-27_08-21-58.png (755×1 px, 108 KB)
2025-02-27_08-22-16.png (755×1 px, 87 KB)
2025-02-27_08-22-57.png (705×1 px, 152 KB)
2025-02-27_08-23-28.png (640×1 px, 106 KB)
GMikesell-WMF updated the task description. (Show Details)