Close button not working when landing on confirmation step
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	SBisson
	Feb 24 2025, 2:26 PM

Description

Steps to replicate the issue (include links if applicable):

Land on the unified dashboard confirmation step from an external entry point
Click on the 'x' button on the top right corner

What happens?:

nothing

What should have happened instead?:

Go to the unified dashboard. In this way, the specific pre-selected article is discarded but users can still participate in translation with a different configuration.

Derived Requirement

Ensure that clicking the close ('x') button on the confirmation step redirects users to the unified dashboard, discarding the pre-selected article while allowing users to participate in translation with a different configuration.

Test Steps

Test Case 1: Ensure close button redirects to unified dashboard

Open Wikipedia and navigate to the unified dashboard confirmation step from an external entry point.
Click on the 'x' button on the top right corner.
✅❓❌⬜ AC1: Confirm that the user is redirected to the unified dashboard.

QA Results - Test Wiki

AC	Status	Details
1	✅	T387126#10634913

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	CX3 Build 0.2.0+20250303	mediawiki/extensions/ContentTranslation	master	+5 K -5 K
	Fix confirmer close button when coming from external link	mediawiki/extensions/ContentTranslation	master	+6 -1

Customize query in gerrit

Event Timeline

SBisson created this task.Feb 24 2025, 2:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2025, 2:26 PM

SBisson updated the task description. (Show Details)Feb 24 2025, 2:26 PM

Pginer-WMF triaged this task as High priority.Feb 25 2025, 2:11 PM

Pginer-WMF moved this task from Backlog to Prioritized on the LPL Hypothesis board.

Pginer-WMF lowered the priority of this task from High to Medium.Feb 25 2025, 2:13 PM

I'd propose for the "X" to direct the user to the dashboard.
The rationale for this:

It may be convenient to have a way to access the dashboard. For example, a user may follow a link to translate that happens to include a specific article pre-selected. If the user wants to translate but a different article, the user can discard the dialog and start a new translation. Otherwise, they'd have to leave and figure out how to get to the translation too again.
Moving back to wherever the user was can be tricky, especially in cases where the user starts with an external link (e.g. shared though a chat app). If users want to go back, they can always use the browser button.

Pginer-WMF updated the task description. (Show Details)Feb 25 2025, 3:07 PM

eamedina claimed this task.Feb 25 2025, 5:32 PM

eamedina moved this task from Prioritized to In-progress on the LPL Hypothesis board.

Change #1122637 had a related patch set uploaded (by Eamedina; author: Eamedina):

[mediawiki/extensions/ContentTranslation@master] Fix confirmer close button when coming from external link

https://gerrit.wikimedia.org/r/1122637

gerritbot added a project: Patch-For-Review.Feb 25 2025, 5:47 PM

eamedina moved this task from In-progress to Needs Code Review on the LPL Hypothesis board.Feb 25 2025, 5:48 PM

Change #1122637 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Fix confirmer close button when coming from external link

https://gerrit.wikimedia.org/r/1122637

Maintenance_bot removed a project: Patch-For-Review.Feb 25 2025, 6:31 PM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.19; 2025-03-04).Feb 25 2025, 7:00 PM

eamedina moved this task from Needs Code Review to Pending deployment on the LPL Hypothesis board.Feb 25 2025, 7:26 PM

Nikerabbit moved this task from Needs Triage to Bugs on the ContentTranslation board.Feb 27 2025, 8:59 AM

Change #1124141 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20250303

https://gerrit.wikimedia.org/r/1124141

gerritbot added a project: Patch-For-Review.Mar 3 2025, 4:11 PM

Change #1124141 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20250303

https://gerrit.wikimedia.org/r/1124141

Maintenance_bot removed a project: Patch-For-Review.Mar 3 2025, 6:34 PM

ngkountas moved this task from Pending deployment to Needs QA on the LPL Hypothesis board.Mar 7 2025, 10:20 AM

GMikesell-WMF updated the task description. (Show Details)Mar 13 2025, 12:20 AM

GMikesell-WMF updated Other Assignee, added: GMikesell-WMF.

@eamedina Mobile stays on desktop mode even when the URL has ".m" and on a mobile device as seen in the gif.

Test Result - TestWiki

Status: ❌ FAIL
Environment: TestWiki
OS: macOS Sonoma 15.3.1
Browser: Chrome 134
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure close button redirects to unified dashboard

Open Wikipedia and navigate to the unified dashboard confirmation step from an external entry point.
Click on the 'x' button on the top right corner.
❌ AC1: Confirm that the user is redirected to the unified dashboard.

Desktop	Mobile
	{

GMikesell-WMF updated the task description. (Show Details)Mar 13 2025, 12:25 AM

GMikesell-WMF moved this task from Needs QA to In-progress on the LPL Hypothesis board.

@eamedina Confirmed that the user is redirected to the unified dashboard as seen from the gifs below. I will move this to sign-off. Thanks for all your work!

Test Result - TestWiki

Status: ✅ PASS
Environment: TestWiki
OS: macOS Sonoma 15.3.1
Browser: Chrome 134
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure close button redirects to unified dashboard

Open Wikipedia and navigate to the unified dashboard confirmation step from an external entry point (ex. open a new tab and paste the URL confirmation).
Click on the 'x' button on the top right corner.
✅ AC1: Confirm that the user is redirected to the unified dashboard.