Maniphest T387170

mw:ExtLink in indent pre isn't getting link attributes
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ABreault-WMF
	Feb 24 2025, 9:32 PM

Tags

Referenced Files

None

Subscribers

Description

https://mr.wiktionary.org/wiki/%E0%A4%B8%E0%A4%BE%E0%A4%9A%E0%A4%BE:All_messages?useparsoid=0
vs
https://mr.wiktionary.org/wiki/%E0%A4%B8%E0%A4%BE%E0%A4%9A%E0%A4%BE:All_messages?useparsoid=1

This is because we've combined 'displayspace+linkclasses' and displayspace skips <pre> elements.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Bump wikimedia/parsoid to 0.21.0-a19	mediawiki/vendor	master	+73 -77
	Stop combining displayspace and linkattributes passes	mediawiki/services/parsoid	master	+21 -5

Customize query in gerrit

Event Timeline

ABreault-WMF created this task.Feb 24 2025, 9:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2025, 9:32 PM

ABreault-WMF claimed this task.Feb 24 2025, 9:32 PM

ABreault-WMF triaged this task as Medium priority.

ABreault-WMF added a project: Content-Transform-Team (Work In Progress).

ABreault-WMF moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.

Change #1122253 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Stop combining display and linkattributes passes

https://gerrit.wikimedia.org/r/1122253

gerritbot added a project: Patch-For-Review.Feb 24 2025, 9:43 PM

ABreault-WMF moved this task from Backlog to Code Review on the Content-Transform-Team (Work In Progress) board.Feb 24 2025, 9:43 PM

Change #1122253 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Stop combining displayspace and linkattributes passes

https://gerrit.wikimedia.org/r/1122253

Maintenance_bot removed a project: Patch-For-Review.Feb 25 2025, 3:30 AM

ABreault-WMF moved this task from Code Review to To Deploy on the Content-Transform-Team (Work In Progress) board.Feb 25 2025, 3:50 PM

Change #1124186 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump wikimedia/parsoid to V0.21.0-a19

https://gerrit.wikimedia.org/r/1124186

gerritbot added a project: Patch-For-Review.Mar 3 2025, 9:18 PM

Change #1124186 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.21.0-a19

https://gerrit.wikimedia.org/r/1124186

Maintenance_bot removed a project: Patch-For-Review.Mar 3 2025, 10:31 PM

ABreault-WMF moved this task from To Deploy to To Verify on the Content-Transform-Team (Work In Progress) board.Mar 4 2025, 10:59 PM

Extlink styling is the same now post-deploy,
https://mr.wiktionary.org/wiki/%E0%A4%B8%E0%A4%BE%E0%A4%9A%E0%A4%BE:All_messages?useparsoid=0
https://mr.wiktionary.org/wiki/%E0%A4%B8%E0%A4%BE%E0%A4%9A%E0%A4%BE:All_messages?useparsoid=1