Page MenuHomePhabricator

[jobs-api] when manually triggering a scheduled job, we strip off any unknown fields set in the k8s cronjob
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Create a scheduled job with --timeout set
  • Manually run toolforge jobs restart <scheduledjobname>
  • The run never times out (the Job does not have the activeDeadlineSeconds set)

This happens for any other non-managed field in the job, as we manually build the job in the code from the cron (https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-api/-/blob/main/tjf/runtimes/k8s/jobs.py?ref_type=heads#L328).

What happens?:

The job gets created from the scheduled job, but it does not have any timeout set.

What should have happened instead?:
It should create the job with the timeout set properly.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
dcaro changed the task status from Open to In Progress.Feb 25 2025, 1:03 PM
dcaro claimed this task.
dcaro triaged this task as Medium priority.
dcaro moved this task from Next Up to In Review on the Toolforge (Toolforge iteration 17) board.

group_203_bot_4866fc124f4b41659f667468a6115cf3 opened https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/678

jobs-api: bump to 0.0.354-20250226132437-b2bd1355

dcaro moved this task from In Review to Done on the Toolforge (Toolforge iteration 18) board.