Page MenuHomePhabricator

GlobalBlocking global autoblocks: Missing caller in queries used to find relevant IP in CheckUser
Closed, ResolvedPublic1 Estimated Story Points

Description

Summary

The CheckUser extension provides the IP address to globally autoblock. The query does not specify a caller, which raises a warning in logstash. We should provide the caller.

Background

  • SelectQueryBuilder provides a ::caller method that allows specifying the PHP code that caused the query
  • When this method is not called, the caller is guessed and a warning is created
  • Additional warnings in logstash causes more events to appear in the TSP Team dashboard, which makes it harder to see other issues
  • We should address these warnings by adding the caller, which should be a small change

Acceptance criteria

  • Warnings are no longer created about a missing caller in SQL queries performed by GlobalBlockingHandler

Event Timeline

Change #1122628 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Provide caller in GlobalBlockingHandler::fetchIPAddressesFromLocalWiki

https://gerrit.wikimedia.org/r/1122628

Change #1122628 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Provide caller in GlobalBlockingHandler::fetchIPAddressesFromLocalWiki

https://gerrit.wikimedia.org/r/1122628