Page MenuHomePhabricator

Number of days in Watchlist is not localized
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Add a page to your Watchlist for a finite number of days, like 90 days
  • Go to Special:EditWatchlist?uselang=fa
  • Find that item on the list

What happens?:
The number of days remaining is shown using Arabic numerals like "89" such as the example shown below

image.png (64×1 px, 34 KB)

What should have happened instead?:
The number of days remaining should be shown using localized Numerals. In the case of lang=fa it would be Eastern Arabic numerals, like "۸۹" instead of "89"

Details

Event Timeline

Restricted Application added subscribers: hubaishan, Aklapper. · View Herald Transcript

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Change #1122681 had a related patch set uploaded (by Huji; author: Huji):

[mediawiki/core@master] Localize duration number in Watchlist editor

https://gerrit.wikimedia.org/r/1122681

@MusikAnimal I need your help with tests/phpunit/unit/includes/watchlist/WatchedItemUnitTest.php which fails as a result of the change I proposed in the proposed patch. I cannot figure out how to modify the unit tests such that it would not expect the value to be provided as a direct parameter to the msg() function, but rather, as a parameter passed through the numParams() method.

jsn.sherman set the point value for this task to 2.Mar 25 2025, 6:50 PM

Test wiki created on Patch demo by JSherman (WMF) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/b474de3575/w/

Change #1122681 merged by jenkins-bot:

[mediawiki/core@master] Localize duration number in Watchlist editor

https://gerrit.wikimedia.org/r/1122681

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org//wikis/b474de3575/w/