| Sebastian_Berlin-WMSE | |
| Feb 26 2025, 9:58 AM |
This should extend UtteranceStore::createUtterance to accept a message key instead of page id and segment. Possibly page id can be used with a faux value to signify that an utterance is not tied to a certain page.
The interaction with Speechoid is currently done in ApiWikispeechListen. We may want to move this to UtteranceStore or maybe a new class.
Outbreak: 1138958
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T255112 ☂ Synthezise default error messages | |||
| Resolved | Viktoria_Hillerud_WMSE | T387280 Enable synthesising messages |
This will serve as an introduction to @Viktoria_Hillerud_WMSE of the underlying infrastructure
I think it would be best to break out the logic that deals with creating/fetching utterances from ApiWikispeechListen to a new class. UtteranceStore should just handle storage, not generation, of utterances. That new class can then be used both by ApiWikispeechListen and any internal utterance generation, such as what we want to do here.
Change #1130076 had a related patch set uploaded (by Viktoria Hillerud WMSE; author: Viktoria Hillerud WMSE):
[mediawiki/extensions/Wikispeech@master] Enables synthesizing error message
Could you break out the changes in patchset 2 into a separate patch? That would make it easier to review and I could use the same change when working on T387739.
Change #1138958 had a related patch set uploaded (by Viktoria Hillerud WMSE; author: Viktoria Hillerud WMSE):
[mediawiki/extensions/Wikispeech@master] Extracted changes from patchset 2 Related to: T387280
Change #1138958 had a related patch set uploaded (by Viktoria Hillerud WMSE; author: Viktoria Hillerud WMSE):
[mediawiki/extensions/Wikispeech@master] Breakout of non-api logic: UtteranceGenerator and InputTextValidator
Change #1138958 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Breakout of non-api logic: UtteranceGenerator and InputTextValidator
When this is approved, I can implement this: Play error message if non-existing page is visited
Change #1130076 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Enable synthesizing error message