Page MenuHomePhabricator

Refactor CheckUser ProtectedVarsAccessLogger logging out of AbuseFilter
Closed, ResolvedPublic

Description

Following T387324: Add hook to support custom logging in `ProtectedVarsAccessLogger`, we should no longer be checking for CheckUser in ProtectedVarsAccessLogger and instead should use this new mechanism from within the CU extension instead. Since CU no longer needs to expose its log to other extensions, the changes made in I35d50df7cd6754e29d964cc716fb3c42406272df could possibly be removed as well.

Acceptance Criteria:

  • ProtectedVarsAccessLogger no longer needs to check for CU or use its logger
  • Any refactoring needed to be done to TemporaryAccountLogger (external logging) is done
  • CheckUser calls the new hook in ProtectedVarsAccessLogger to log access
  • Access is not logged twice between AbuseFilter and CheckUser (feature parity)

Event Timeline

Change #1125213 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/AbuseFilter@master] [WIP] Remove CU-specific logging logic

https://gerrit.wikimedia.org/r/1125213

Change #1125214 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/CheckUser@master] [WIP] Log access to protected variables from AbuseFilter

https://gerrit.wikimedia.org/r/1125214

Change #1125214 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Log access to protected variables from AbuseFilter

https://gerrit.wikimedia.org/r/1125214

Change #1125213 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Remove CU-specific logging logic

https://gerrit.wikimedia.org/r/1125213

dom_walden subscribed.

This was tested as part of T390708#10748237. I added another variable to $wgAbuseFilterProtectedVariables so I could see access being logged to both checkuser-temporary-account and abusefilter-protected-vars, as appropriate.