[regression] ToC icons appears as black squares while assets are loading
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Feb 26 2025, 2:50 PM

Description

While the page is loading, the expand/collapse icons in the ToC appears as black squares:

Bisect blames https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1118191 "styles: Remove transparent PNG fallback for .vector-icon"

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Table of contents icon shouldn't be a black square while loading	mediawiki/skins/Vector	master	+13 -1
Documentation: Add cautionary note based on previous regression	mediawiki/skins/Vector	master	+6 -0
Remove transparent PNG fallback for `.vector-icon`"	mediawiki/skins/Vector	master	+0 -6
Revert "styles: Remove transparent PNG fallback for `.vector-icon`"	mediawiki/skins/Vector	wmf/1.44.0-wmf.18	+6 -0
Revert "styles: Remove transparent PNG fallback for `.vector-icon`"	mediawiki/skins/Vector	master	+6 -0

Customize query in gerrit

Related Objects

Mentioned In: T358910: [M] Open image full screen for Image Recs
T387542: Delayed Image Rendering on Reload with Firefox
Mentioned Here: T358910: [M] Open image full screen for Image Recs

Event Timeline

Esanders created this task.Feb 26 2025, 2:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 26 2025, 2:50 PM

Change #1123004 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/Vector@master] Revert "styles: Remove transparent PNG fallback for `.vector-icon`"

https://gerrit.wikimedia.org/r/1123004

gerritbot added a project: Patch-For-Review.Feb 26 2025, 5:23 PM

DLynch added a parent task: T382369: 1.44.0-wmf.18 deployment blockers.Feb 26 2025, 6:19 PM

Aklapper renamed this task from [regrssion] ToC icons appears as black squares while assets are loading to [regression] ToC icons appears as black squares while assets are loading.Feb 26 2025, 6:28 PM

Change #1123018 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Table of contents icon shouldn't be a black square while loading

https://gerrit.wikimedia.org/r/1123018

Jdlrobson-WMF triaged this task as Medium priority.Feb 26 2025, 7:31 PM

ovasileva raised the priority of this task from Medium to High.Feb 26 2025, 7:36 PM

• Agusbou2015 subscribed.Feb 27 2025, 12:06 AM

Change #1123004 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Revert "styles: Remove transparent PNG fallback for `.vector-icon`"

https://gerrit.wikimedia.org/r/1123004

Change #1123395 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Remove transparent PNG fallback for `.vector-icon`"

https://gerrit.wikimedia.org/r/1123395

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.19; 2025-03-04).Feb 27 2025, 4:00 PM

What's the status here? Do we need a cherry-pick to wmf.18 to unblock the train?

Just a reminder that all train blockers need to be UBN. If this isn't a blocker, please remove the parent task.

It's not a train blocker. Sorry, didn't realize the ticket was created as a subtask. Phabricator doesn't make that obvious.

Jdlrobson-WMF removed a parent task: T382369: 1.44.0-wmf.18 deployment blockers.Feb 27 2025, 7:57 PM

Thanks, Jon!

Jdlrobson-WMF moved this task from Incoming to Groomed on the Vector 2022 board.Feb 27 2025, 11:41 PM

Also reported on Wikipedia village pump: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Expand_arrows_in_section_table_of_contents_flash_black/white_when_loading

In dark mode, the black boxes become white. All I have to say in the matter.

Michael subscribed.Feb 28 2025, 7:15 AM

Trizek-WMF added a project: User-notice.Feb 28 2025, 9:19 AM

Aklapper mentioned this in T387542: Delayed Image Rendering on Reload with Firefox .Feb 28 2025, 10:03 AM

Nemoralis subscribed.Feb 28 2025, 11:29 AM

Hakimi97 subscribed.Feb 28 2025, 11:36 AM

Change #1123713 had a related patch set uploaded (by Jdlrobson; author: Esanders):

[mediawiki/skins/Vector@wmf/1.44.0-wmf.18] Revert "styles: Remove transparent PNG fallback for `.vector-icon`"

https://gerrit.wikimedia.org/r/1123713

Quiddity moved this task from To Triage to In current Tech/News draft on the User-notice board.Feb 28 2025, 10:52 PM

Btw, the same is happening with the “appearance” logo (the button used to change theme from Light to Dark to Automatic)

A06B9760-507D-4701-AF0F-90B368633311.jpeg (1×1 px, 604 KB)

Jdlrobson-WMF merged a task: T387542: Delayed Image Rendering on Reload with Firefox .Mar 3 2025, 5:04 PM

Jdlrobson-WMF added subscribers: Kallichore, Krinkle.

Actually, it's not just while loading. Some of the black squares stay for good, if there is no icon at all. For example, adding an entry to user menu does not allow to define icons yet, so instead of empty place we get this problem.

Screenshot_20250304_012810_Samsung Internet.png (536×579 px, 56 KB)

Actually, it's not just while loading. Some of the black squares stay for good, if there is no icon at all

Yeh that's an intentional feature. Please talk to the gadget developer to get that fixed.

What can be fixed here? I'm the developer.

In T387351#10598842, @IKhitron wrote:

What can be fixed here? I'm the developer.

Ping me on wiki on the gadget talk page using [[User:Jdlrobson]] (my volunteer account), not here.

ovasileva subscribed.Mar 4 2025, 4:55 PM

Change #1123713 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.44.0-wmf.18] Revert "styles: Remove transparent PNG fallback for `.vector-icon`"

https://gerrit.wikimedia.org/r/1123713

Mentioned in SAL (#wikimedia-operations) [2025-03-04T21:15:21Z] <jforrester@deploy2002> Started scap sync-world: Backport for [[gerrit:1123713|Revert "styles: Remove transparent PNG fallback for .vector-icon" (T358910 T387351)]]

Mentioned in SAL (#wikimedia-operations) [2025-03-04T21:18:23Z] <jforrester@deploy2002> jforrester, jdlrobson: Backport for [[gerrit:1123713|Revert "styles: Remove transparent PNG fallback for .vector-icon" (T358910 T387351)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2025-03-04T21:25:34Z] <jforrester@deploy2002> Finished scap sync-world: Backport for [[gerrit:1123713|Revert "styles: Remove transparent PNG fallback for .vector-icon" (T358910 T387351)]] (duration: 10m 13s)

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.18; 2025-02-25); removed MW-1.44-notes (1.44.0-wmf.19; 2025-03-04).Mar 4 2025, 10:00 PM

(Change has been backported)

Change #1125259 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Documentation: Add cautionary note based on previous regression

https://gerrit.wikimedia.org/r/1125259

Change #1123395 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Remove transparent PNG fallback for `.vector-icon`"

Reason:

Not a priority right now. Added a note for our future selves: https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1125259?usp=search

https://gerrit.wikimedia.org/r/1123395

Quiddity moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Mar 7 2025, 12:38 AM

Change #1125259 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Documentation: Add cautionary note based on previous regression

https://gerrit.wikimedia.org/r/1125259

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.20; 2025-03-11); removed MW-1.44-notes (1.44.0-wmf.18; 2025-02-25).Mar 7 2025, 2:00 AM

Maintenance_bot edited projects, added User-notice-archive; removed User-notice.Mar 17 2025, 2:30 AM

Change #1123018 abandoned by Jdlrobson: