IPInfo: REST APIs throw an exception if site is in read only mode
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Feb 26 2025, 5:12 PM

Description

Summary

When a wiki is configured to insert jobs into a database table, the IP Info REST APIs return a 500 error when the site is in read only mode along with a stack trace. This should instead return a more user friendly error.

Background

When a user uses the IP Info popup or infobox, a REST API request is made to the IPInfo REST APIs
- This request will create a log entry if the subject is defined (which is in most cases)
Inserting jobs on wikis may require writing to the DB, if the $wgJobTypeConf is configured to use the DB (which is the default)
Even if the job is inserted, the write in the job will still fail
When in read-only mode we should probably disable the REST APIs because we need to log the use of them.

Acceptance criteria

IP Info REST APIs return a user-friendly error message when the site is in read only mode

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	REST APIs: Return user friendly error when site in read only mode	mediawiki/extensions/IPInfo	master	+99 -28

Customize query in gerrit

Event Timeline

Dreamy_Jazz created this task.Feb 26 2025, 5:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 26 2025, 5:12 PM

Dreamy_Jazz claimed this task.Feb 26 2025, 5:13 PM

Dreamy_Jazz set the point value for this task to 1.

Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Hurdy-Gurdy (Feb 10 - Feb 28)) board.

Change #1123008 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/IPInfo@master] REST APIs: Return user friendly error when site in read only mode

https://gerrit.wikimedia.org/r/1123008

gerritbot added a project: Patch-For-Review.Feb 26 2025, 5:49 PM

Dreamy_Jazz renamed this task from IPInfo: REST APIs return 500 error if site is in read only mode to IPInfo: REST APIs throw an exception if site is in read only mode.Feb 26 2025, 5:52 PM

Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Hurdy-Gurdy (Feb 10 - Feb 28)) board.

Change #1123008 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] REST APIs: Return user friendly error when site in read only mode

https://gerrit.wikimedia.org/r/1123008

Dreamy_Jazz moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Hurdy-Gurdy (Feb 10 - Feb 28)) board.Feb 27 2025, 12:14 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 27 2025, 12:30 PM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.19; 2025-03-04).Feb 27 2025, 1:00 PM

Dreamy_Jazz moved this task from Inbox to Engineering on the Trust and Safety Product Team board.Feb 28 2025, 5:52 PM

Dreamy_Jazz edited projects, added Trust and Safety Product Team (Engineering); removed Trust and Safety Product Team.

Dreamy_Jazz moved this task from Sprint Hurdy-Gurdy (Feb 10 - Feb 28) to Sprint Lemon Meringue (March 3 - 21) on the Trust and Safety Product Sprint board.Mar 3 2025, 3:45 PM

Dreamy_Jazz edited projects, added Trust and Safety Product Sprint (Sprint Lemon Meringue (March 3 - 21)); removed Trust and Safety Product Sprint (Sprint Hurdy-Gurdy (Feb 10 - Feb 28)).

Dreamy_Jazz moved this task from Priority Backlog to Needs QA on the Trust and Safety Product Sprint (Sprint Lemon Meringue (March 3 - 21)) board.

QA is completed, I have verified the new code has been implemented and is functioning as expected (When a site is in read-only mode, and a user is viewing a page with the IP Info popup icon or the IP Infobox (such as: Logs or Recent Changes or View History or User Contributions), and then the user selects the IP Info popup icon or views the IP Infobox, it will display an error message indicating the database cannot be modified).

Dreamy_Jazz closed this task as Resolved.Mar 4 2025, 11:27 AM

	F58588559: image.png
	Mar 4 2025, 7:45 AM

	F58525196: image.png
	Mar 4 2025, 7:45 AM

IPInfo: REST APIs throw an exception if site is in read only modeClosed, ResolvedPublic1 Estimated Story PointsActions