Page MenuHomePhabricator

Compound templates prevent section edit links where legacy adds them
Open, Needs TriagePublicBUG REPORT

Description

Check Parsoid vs legacy on vecwiktionary. The "Tradusion" section at the bottom is missing an Edit section link. This is also seen on several other vecwiktionary pages.

@Arlolra says that this is another instance of something he investigated previously in T373400#10135519.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

@Arlolra says that this is another instance of something he investigated previously in T373400#10135519.

The task T373400 was about missing styling from the headings not being wrapped and that was fixed. But what remains is that, for compound templates, the $metadata->fromTitle = null; in WrapSectionsState means that we're not going to to be adding section edit links in HandleParsoidSectionLinks

https://github.com/wikimedia/mediawiki-services-parsoid/blob/master/src/Wt2Html/DOM/Processors/WrapSectionsState.php#L100-L102
https://github.com/wikimedia/mediawiki/blob/master/includes/OutputTransform/Stages/HandleParsoidSectionLinks.php#L105-L108

Relatedly, section edit links from nested templated aren't supported in Parsoid (see https://phabricator.wikimedia.org/T368095#9971720) and section titles failing to resolve redirected templates. See all the tests added in T368095 which probably deserve their own tasks.

ABreault-WMF renamed this task from HandleParsoidSectionLinks is skipping edit section links where legacy adds them to Compound templates prevent section edit links where legacy adds them.Apr 10 2025, 7:40 PM