Maniphest T387377

[VE WikifunctionsCall]: Match failed calls properly so that they are also configured with the WikifunctionsCall ContextItem and Dialog
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	gengh
	Feb 26 2025, 5:34 PM

Tags

Referenced Files

None

Subscribers

Description

Description

Successful function calls are being handled by the WikifunctionsCall classes, however failed calls are falling back to being handled with the Template dialog.

Figure out why.

Desired behavior/Acceptance criteria

Failed function calls should be configurable using the same screens as successful ones

Devices and Design (URLs or screenshots)

Desktop: ...
Small screens/mobile: ...

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Front-end_Task/Bug_Completion_Checklist

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Show errors in Function context popup	mediawiki/extensions/WikiLambda	master	+295 -137
	Integrate DefaultView in VisualEditor	mediawiki/extensions/WikiLambda	master	+1 K -231

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T272515 Provide nice ways for editors to insert and update Wikifunctions calls in VisualEditor
		Resolved		Jdforrester-WMF	T383106 [25Q3] Provide Wikifunctions integration in articles on Dagbani Wikipedia
		Resolved		Jdforrester-WMF	T376521 Enable one WF use case in a smaller language Wikipedia
		Resolved		Jdforrester-WMF	T373118 Implement initial integration of WF call nodes with VisualEditor
		Resolved		gengh	T387377 [VE WikifunctionsCall]: Match failed calls properly so that they are also configured with the WikifunctionsCall ContextItem and Dialog

Event Timeline

gengh created this task.Feb 26 2025, 5:34 PM

gengh added a parent task: T383106: [25Q3] Provide Wikifunctions integration in articles on Dagbani Wikipedia.

Jdforrester-WMF triaged this task as Medium priority.Feb 26 2025, 5:42 PM

Jdforrester-WMF edited parent tasks, added: T373118: Implement initial integration of WF call nodes with VisualEditor; removed: T383106: [25Q3] Provide Wikifunctions integration in articles on Dagbani Wikipedia.

Jdforrester-WMF moved this task from To Triage to 25Q3 (Jan–Mar) on the Abstract Wikipedia team board.

Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q3 (Jan–Mar)); removed Abstract Wikipedia team.

Jdforrester-WMF moved this task from Incoming to Ready, Quarterly Work on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.Feb 26 2025, 5:44 PM

gengh claimed this task.Mar 2 2025, 8:40 AM

Change #1122071 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Integrate DefaultView in VisualEditor

https://gerrit.wikimedia.org/r/1122071

gerritbot added a project: Patch-For-Review.Mar 2 2025, 8:40 AM

gengh changed the task status from Open to In Progress.Mar 3 2025, 10:34 AM

gengh moved this task from Ready, Quarterly Work to In Engineering on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.

Change #1122071 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Integrate DefaultView in VisualEditor

https://gerrit.wikimedia.org/r/1122071

Maintenance_bot removed a project: Patch-For-Review.Mar 3 2025, 2:30 PM

Change #1124367 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Show errors in Function context popup

https://gerrit.wikimedia.org/r/1124367

gerritbot added a project: Patch-For-Review.Mar 4 2025, 8:33 AM

DSantamaria added a project: Wikifunctions integration.Mar 4 2025, 12:21 PM

Change #1124367 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Show errors in Function context popup

https://gerrit.wikimedia.org/r/1124367

gengh moved this task from In Engineering to In Code review on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.Mar 4 2025, 2:53 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 4 2025, 3:31 PM

gengh moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.Mar 4 2025, 6:31 PM

Jdforrester-WMF added a project: MW-1.44-notes (1.44.0-wmf.20; 2025-03-11).Mar 11 2025, 1:34 PM

Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.Mar 12 2025, 7:22 PM

Jdforrester-WMF closed this task as Resolved.Mar 20 2025, 1:14 PM