Page MenuHomePhabricator
Create Task
Maniphest T387408

PHP Fatal error: Uncaught Error: Class "MediaWiki\HookContainer\HookRunner" not found
Open, Needs TriagePublic
Actions

Description

Not sure if this is similar to T307816: Installing MediaWiki: Error: Class "FormatJson" not found...

But trying to use update.php (or eval.php, or presumably any maintenance script?) on a long existing MW 1.39 install, but using opcache that will be warmed on master of MW..

reedy@ubuntu64-web-esxi:/var/www/wiki-1.39/core$ php -v
PHP 8.4.4 (cli) (built: Feb 15 2025 08:59:26) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.4.4, Copyright (c) Zend Technologies
    with Zend OPcache v8.4.4, Copyright (c), by Zend Technologies
    with Xdebug v3.4.1, Copyright (c) 2002-2025, by Derick Rethans
reedy@ubuntu64-web-esxi:/var/www/wiki-1.39/core$ php maintenance/update.php
PHP Fatal error:  Uncaught Error: Class "MediaWiki\HookContainer\HookRunner" not found in /var/www/wiki-1.39/core/includes/Hooks.php:174
Stack trace:
#0 /var/www/wiki-1.39/core/includes/exception/MWExceptionHandler.php(807): Hooks::runner()
#1 /var/www/wiki-1.39/core/includes/exception/MWExceptionHandler.php(336): MWExceptionHandler::logError()
#2 /var/www/wiki-1.39/core/vendor/composer/ClassLoader.php(576): MWExceptionHandler::handleError()
#3 /var/www/wiki-1.39/core/vendor/composer/ClassLoader.php(576): include('...')
#4 /var/www/wiki-1.39/core/vendor/composer/ClassLoader.php(427): {closure:Composer\Autoload\ClassLoader::initializeIncludeClosure():575}()
#5 /var/www/wiki-1.39/core/vendor/wikimedia/services/src/ServiceContainer.php(441): Composer\Autoload\ClassLoader->loadClass()
#6 /var/www/wiki-1.39/core/vendor/wikimedia/services/src/ServiceContainer.php(411): Wikimedia\Services\ServiceContainer->createService()
#7 /var/www/wiki-1.39/core/includes/MediaWikiServices.php(301): Wikimedia\Services\ServiceContainer->getService()
#8 /var/www/wiki-1.39/core/includes/MediaWikiServices.php(951): MediaWiki\MediaWikiServices->getService()
#9 /var/www/wiki-1.39/core/includes/exception/MWExceptionHandler.php(165): MediaWiki\MediaWikiServices->getDBLoadBalancerFactory()
#10 /var/www/wiki-1.39/core/includes/exception/MWExceptionHandler.php(191): MWExceptionHandler::rollbackPrimaryChanges()
#11 /var/www/wiki-1.39/core/includes/exception/MWExceptionHandler.php(247): MWExceptionHandler::rollbackPrimaryChangesAndLog()
#12 /var/www/wiki-1.39/core/includes/exception/MWExceptionHandler.php(216): MWExceptionHandler::handleException()
#13 [internal function]: MWExceptionHandler::handleUncaughtException()
#14 {main}
  thrown in /var/www/wiki-1.39/core/includes/Hooks.php on line 174

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
exception: Skip use of HookRunner when not autoloadedmediawiki/coreREL1_39+5 -1
exception: Skip use of HookRunner when not autoloadedmediawiki/coreREL1_39+10 -0
Conditionally load MWExceptionHandler's HookRunnermediawiki/coreREL1_39+15 -4
exception: Skip use of HookRunner when not autoloadedmediawiki/coreREL1_43+4 -1
exception: Skip use of HookRunner when not autoloadedmediawiki/coreREL1_44+4 -1
exception: Skip use of HookRunner when not autoloadedmediawiki/coremaster+4 -1
Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Feb 26 2025, 11:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 26 2025, 11:18 PM
Reedy added a comment.Feb 26 2025, 11:20 PM

Not sure if this is similar to T307816: Installing MediaWiki: Error: Class "FormatJson" not found...

But trying to use update.php on a long existing MW 1.39 install, but using opcache that will be warmed on master of MW..

Maybe not, reboot the host and still failing...

Reedy added a project: PHP 8.4 support.Feb 26 2025, 11:21 PM

PHP8.1-8.3 work fine...

Reedy moved this task from Backlog to MediaWiki core on the PHP 8.4 support board.Feb 26 2025, 11:25 PM

This feels dejavu.

Running the wiki via apache on PHP 8.4 is apparently fine.

Reedy added a comment.Feb 27 2025, 12:50 AM

T348136: Error: Class 'MediaWiki\HookContainer\HookRunner' not found is similar, but not the same context...

Umherirrender subscribed.Feb 28 2025, 10:35 PM

Maybe apply the fix from T379125 / 5cf3cd03dfd3f7acca4d78bf12054f3c315fee28 locally to see if that helps seeing the real error (maybe T379587 but only called by cli path).

Reedy added a comment.Feb 28 2025, 10:50 PM
In T387408#10592606, @Umherirrender wrote:

Maybe apply the fix from T379125 / 5cf3cd03dfd3f7acca4d78bf12054f3c315fee28 locally to see if that helps seeing the real error (maybe T379587 but only called by cli path).

Thanks for the hint!

I've done the cherry pick (and amends) in Gerrit. Will test locally to see

Reedy added a comment.Feb 28 2025, 11:12 PM

It changes/simplifies the stack trace a bit, but unfortunately doesn't fundamentally change the error:

reedy@ubuntu64-web-esxi:/var/www/wiki-1.39/core$ php8.4 maintenance/update.php
PHP Fatal error:  Uncaught Error: Class "MediaWiki\HookContainer\HookRunner" not found in /var/www/wiki-1.39/core/includes/Hooks.php:174
Stack trace:
#0 /var/www/wiki-1.39/core/includes/exception/MWExceptionHandler.php(820): Hooks::runner()
#1 /var/www/wiki-1.39/core/includes/exception/MWExceptionHandler.php(764): MWExceptionHandler::callLogExceptionHook()
#2 /var/www/wiki-1.39/core/includes/exception/MWExceptionHandler.php(195): MWExceptionHandler::logException()
#3 /var/www/wiki-1.39/core/includes/exception/MWExceptionHandler.php(249): MWExceptionHandler::rollbackPrimaryChangesAndLog()
#4 /var/www/wiki-1.39/core/includes/exception/MWExceptionHandler.php(218): MWExceptionHandler::handleException()
#5 [internal function]: MWExceptionHandler::handleUncaughtException()
#6 {main}
  thrown in /var/www/wiki-1.39/core/includes/Hooks.php on line 174

I've just +2'd it on REL1_39 and REL1_42, as they're not going to cause any harm in that regard, but maybe help.

Reedy updated the task description. (Show Details)Feb 28 2025, 11:12 PM
Reedy added a subscriber: tstarling.
Reedy updated the task description. (Show Details)Feb 28 2025, 11:16 PM
Umherirrender unsubscribed.Mar 29 2025, 3:41 PM
Njk subscribed.Jun 9 2025, 9:16 PM
Njk added a comment.EditedJun 9 2025, 9:30 PM

I've run into this as well, on PHP 8.4.7, using mediawiki 1.39.12, nginx 1.26.3.

$ php -v
PHP 8.4.7 (cli) (built: May  6 2025 12:31:58) (NTS gcc x86_64)
Copyright (c) The PHP Group
Built by Fedora Project
Zend Engine v4.4.7, Copyright (c) Zend Technologies

$ php maintenance/update.php 
PHP Fatal error:  Uncaught Error: Class "MediaWiki\HookContainer\HookRunner" not found in /var/www/ctlwiki/includes/Hooks.php:174
Stack trace:
#0 /var/www/ctlwiki/includes/exception/MWExceptionHandler.php(820): Hooks::runner()
#1 /var/www/ctlwiki/includes/exception/MWExceptionHandler.php(764): MWExceptionHandler::callLogExceptionHook()
#2 /var/www/ctlwiki/includes/exception/MWExceptionHandler.php(195): MWExceptionHandler::logException()
#3 /var/www/ctlwiki/includes/exception/MWExceptionHandler.php(249): MWExceptionHandler::rollbackPrimaryChangesAndLog()
#4 /var/www/ctlwiki/includes/exception/MWExceptionHandler.php(218): MWExceptionHandler::handleException()
#5 [internal function]: MWExceptionHandler::handleUncaughtException()
#6 {main}
  thrown in /var/www/ctlwiki/includes/Hooks.php on line 174
Nnyby subscribed.Jun 10 2025, 2:17 PM
gerritbot added a comment.Jun 10 2025, 5:42 PM

Change #1155294 had a related patch set uploaded (by Nnyby; author: Nnyby):

[mediawiki/core@REL1_39] Conditionally load MWExceptionHandler's HookRunner

https://gerrit.wikimedia.org/r/1155294

gerritbot added a project: Patch-For-Review.Jun 10 2025, 5:42 PM
gerritbot added a comment.Jun 28 2025, 9:22 AM

Change #1164550 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] exception: Skip use of HookRunner when not autoloaded.

https://gerrit.wikimedia.org/r/1164550

gerritbot added a comment.Jun 28 2025, 7:25 PM

Change #1164550 merged by jenkins-bot:

[mediawiki/core@master] exception: Skip use of HookRunner when not autoloaded

https://gerrit.wikimedia.org/r/1164550

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.8; 2025-07-01).Jun 28 2025, 8:00 PM
gerritbot added a comment.Jun 28 2025, 8:15 PM

Change #1164625 had a related patch set uploaded (by Reedy; author: Umherirrender):

[mediawiki/core@REL1_44] exception: Skip use of HookRunner when not autoloaded

https://gerrit.wikimedia.org/r/1164625

gerritbot added a comment.Jun 28 2025, 8:15 PM

Change #1164626 had a related patch set uploaded (by Reedy; author: Umherirrender):

[mediawiki/core@REL1_43] exception: Skip use of HookRunner when not autoloaded

https://gerrit.wikimedia.org/r/1164626

gerritbot added a comment.Jun 28 2025, 8:54 PM

Change #1164625 merged by jenkins-bot:

[mediawiki/core@REL1_44] exception: Skip use of HookRunner when not autoloaded

https://gerrit.wikimedia.org/r/1164625

ReleaseTaggerBot added a project: MW-1.44-notes.Jun 28 2025, 9:00 PM
gerritbot added a comment.Jun 28 2025, 9:48 PM

Change #1164626 merged by jenkins-bot:

[mediawiki/core@REL1_43] exception: Skip use of HookRunner when not autoloaded

https://gerrit.wikimedia.org/r/1164626

ReleaseTaggerBot added a project: MW-1.43-notes.Jun 28 2025, 10:00 PM
gerritbot added a comment.Jun 29 2025, 4:22 PM

Change #1155294 abandoned by Nnyby:

[mediawiki/core@REL1_39] Conditionally load MWExceptionHandler's HookRunner

Reason:

Better patch is here: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1164626

https://gerrit.wikimedia.org/r/1155294

Maintenance_bot removed a project: Patch-For-Review.Jun 29 2025, 4:30 PM
gerritbot added a comment.Jul 10 2025, 4:18 AM

Change #1167728 had a related patch set uploaded (by Nnyby; author: Nnyby):

[mediawiki/core@REL1_39] exception: Skip use of HookRunner when not autoloaded

https://gerrit.wikimedia.org/r/1167728

gerritbot added a project: Patch-For-Review.Jul 10 2025, 4:18 AM
gerritbot added a comment.Jul 24 2025, 8:56 PM

Change #1172410 had a related patch set uploaded (by Reedy; author: Umherirrender):

[mediawiki/core@REL1_39] exception: Skip use of HookRunner when not autoloaded

https://gerrit.wikimedia.org/r/1172410

gerritbot added a comment.Jul 24 2025, 8:57 PM

Change #1167728 abandoned by Reedy:

[mediawiki/core@REL1_39] exception: Skip use of HookRunner when not autoloaded

Reason:

Properly cherry picked via https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1172409/2 and https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1172410/1

https://gerrit.wikimedia.org/r/1167728

gerritbot added a comment.Jul 25 2025, 5:39 PM

Change #1172410 merged by jenkins-bot:

[mediawiki/core@REL1_39] exception: Skip use of HookRunner when not autoloaded

https://gerrit.wikimedia.org/r/1172410

ReleaseTaggerBot added a project: MW-1.39-notes.Jul 25 2025, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 25 2025, 6:31 PM
Reedy moved this task from Blocker to Not a blocker on the MW-1.39-release board.Sep 23 2025, 10:47 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits