Page MenuHomePhabricator
Create Task
Maniphest T387414

Insert above/below throwing error instead of adding a new row
Closed, DuplicatePublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

Uncaught TypeError: c is null
    style ve.ui.TableAction.js:717
    insertRowOrCol ve.ui.TableAction.js:717
    insert ve.ui.TableAction.js:131
    executeWithSource ve.ui.Surface.js:737
    execute ve.ui.Command.js:43
    onActionButtonClick ve.ui.TableLineContextItem.js:67
    emit oojs.js:858
    onClick oojs-ui-core.js:2377
    jQuery 9
        dispatch
        handle
        add
        on
        each
        each
        on
        on
        on
    setButtonElement oojs-ui-core.js:2317
    OoUiMixinButtonElement oojs-ui-core.js:2260
    OoUiButtonWidget oojs-ui-core.js:3970
    VeUiTableLineContextItem ve.ui.TableLineContextItem.js:23
    VeUiInsertRowOrColumnContextItem ve.ui.TableLineContextItem.js:115
    create oojs.js:1683
    items ve.ui.Context.js:173
    setupMenuItems ve.ui.Context.js:171
    toggleMenu ve.ui.Context.js:150
    toggleMenu ve.ui.TableLineContext.js:183
    onIconMouseDown ve.ui.TableLineContext.js:120
    jQuery 2
ve.ui.TableAction.js:717:32
    style ve.ui.TableAction.js:717
    map self-hosted:175
    insertRowOrCol ve.ui.TableAction.js:717
    insert ve.ui.TableAction.js:131
    executeWithSource ve.ui.Surface.js:737
    execute ve.ui.Command.js:43
    onActionButtonClick ve.ui.TableLineContextItem.js:67
    emit oojs.js:858
    onClick oojs-ui-core.js:2377
    jQuery 9
        dispatch
        handle
    (Async: EventListener.handleEvent)
        add
        on
        each
        each
        on
        on
        on
    setButtonElement oojs-ui-core.js:2317
    OoUiMixinButtonElement oojs-ui-core.js:2260
    OoUiButtonWidget oojs-ui-core.js:3970
    VeUiTableLineContextItem ve.ui.TableLineContextItem.js:23
    VeUiInsertRowOrColumnContextItem ve.ui.TableLineContextItem.js:115
    create oojs.js:1683
    items ve.ui.Context.js:173
    map self-hosted:175
    setupMenuItems ve.ui.Context.js:171
    toggleMenu ve.ui.Context.js:150
    toggleMenu ve.ui.TableLineContext.js:183
    onIconMouseDown ve.ui.TableLineContext.js:120
    jQuery 2
        dispatch
        handle

What should have happened instead?:

A new row inserted in the table

Related Objects

Event Timeline

bd808 created this task.Feb 27 2025, 12:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 27 2025, 12:14 AM
bd808 added a parent task: T382369: 1.44.0-wmf.18 deployment blockers.Feb 27 2025, 12:16 AM
bd808 added a comment.Feb 27 2025, 12:20 AM

I do seem to be able to insert below the second to last row and then move the new row down. Firefox 135.0, MacOS

Maintenance_bot added a project: VisualEditor.Feb 27 2025, 12:29 AM
bd808 added a comment.Feb 27 2025, 12:31 AM

https://www.mediawiki.org/w/index.php?title=Wikimedia_Hackathon_2025/Participants&diff=prev&oldid=7059755 seems to have fixed things so that the table editor works as expected.

bd808 added a comment.Feb 27 2025, 12:46 AM

Possibly a dup of T189543: 'commentMeta' nodes appearing as direct children of 'tableRow' / 'list' nodes, which breaks editing of those tables/lists?

matmarex subscribed.Feb 27 2025, 12:49 AM

Looks like T189826: Meta nodes are moved outside of table cells / list items when they appear as their last children, which breaks editing of those tables/lists.

The Parsoid HTML has the <link> tag at the end of a <td>…</td> tag: https://www.mediawiki.org/w/rest.php/v1/revision/7059754/html

image.png (1×1 px, 247 KB)

In VE debug mode, you can see that the corresponding node is outside of the corresponding table cell: https://www.mediawiki.org/w/index.php?oldid=7059754&veaction=edit&debug=true

image.png (1×1 px, 180 KB)

As a result, VE tries to treat that category node as if it was a table cell, and things go wrong. This exception is thrown when it tries to copy its style to the new row (whether it is a content or header cell), but if it wasn't that, something else would probably break.

• Agusbou2015 subscribed.Feb 27 2025, 10:55 AM
dduvall subscribed.Feb 27 2025, 7:28 PM

Should this block today's train promotion?

dduvall triaged this task as Unbreak Now! priority.EditedFeb 27 2025, 7:34 PM

Just a reminder that all train blockers need to be UBN. If this isn't a blocker, please remove the parent task.

matmarex closed this task as a duplicate of T189826: Meta nodes are moved outside of table cells / list items when they appear as their last children, which breaks editing of those tables/lists.Feb 27 2025, 8:01 PM
matmarex removed a parent task: T382369: 1.44.0-wmf.18 deployment blockers.
matmarex mentioned this in T189826: Meta nodes are moved outside of table cells / list items when they appear as their last children, which breaks editing of those tables/lists.
dduvall added a comment.Feb 27 2025, 8:02 PM

Thank you!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits