Page MenuHomePhabricator

Tests\MobileFrontend\Structure\MobileFrontendBundleSizeTest::testBundleSize with data set "mobile.special.mobileoptions.scripts" (array('mobile.special.mobileoptions.scripts', '2.7KB'))
Closed, ResolvedPublic

Description

Seen on unrelated patch in REL1_42 - https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OATHAuth/+/1123054

https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php81-noselenium/9037/console

00:40:16 1) Tests\MobileFrontend\Structure\MobileFrontendBundleSizeTest::testBundleSize with data set "mobile.special.mobileoptions.scripts" (array('mobile.special.mobileoptions.scripts', '2.7KB'))
00:40:16 mobile.special.mobileoptions.scripts is less than 2764.8
00:40:16 Failed asserting that 3214 is less than 2764.8.
00:40:16 
00:40:16 /workspace/src/tests/phpunit/structure/BundleSizeTestBase.php:87

Value seemingly changed on master in rEMFRb0f0d6c284dd: Update to 1.2.0 of @wikimedia/mediawiki.skins.clientpreferences

Event Timeline

Jdlrobson triaged this task as Medium priority.Feb 27 2025, 5:10 AM
Jdlrobson subscribed.

I think this is likely a side effect of the security fix on T366402 which required building assets in latest Node version and increasing bundlesize. I will take a look tomorrow. Sorry for the disruption.

Change #1123392 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@REL1_42] Fix CI issues on MobileFrontend REL1_42

https://gerrit.wikimedia.org/r/1123392

Change #1123392 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@REL1_42] Fix CI issues on MobileFrontend REL1_42

https://gerrit.wikimedia.org/r/1123392

Jdlrobson-WMF claimed this task.
Jdlrobson-WMF subscribed.

Fixed and your patch went through.