Page MenuHomePhabricator
Create Task
Maniphest T387427

Section selector shows html markup in section title and such sections fails to load
Closed, ResolvedPublic8 Estimated Story PointsBUG REPORT
Actions

Assigned To
ngkountas
Authored By
santhosh
Feb 27 2025, 3:34 AM
Project Tags
Referenced Files
F66484999: image.png
Sep 24 2025, 2:53 PM
F65922338: 2025-08-27_13-04-16.png
Aug 27 2025, 10:24 PM
F65922331: 2025-08-27_13-01-35.png
Aug 27 2025, 10:24 PM
F65922295: 2025-08-27_12-51-52.mp4
Aug 27 2025, 10:24 PM
F65922301: 2025-08-27_12-54-04.mp4
Aug 27 2025, 10:24 PM
F58929992: Screenshot 2025-03-27 at 16.38.31.png
Mar 27 2025, 1:42 PM
F58508877: image.png
Feb 27 2025, 3:34 AM
F58508875: image.png
Feb 27 2025, 3:34 AM
Subscribers
Aklapper
eamedina
GMikesell-WMF
ngkountas
• Nikerabbit
Pginer-WMF
• PWaigi-WMF
View All 9 Subscribers

Description

Section selector shows html markup in section title and such sections fails to load. See the screenshot below.

image.png (828×907 px, 73 KB)
image.png (831×953 px, 57 KB)

Derived Requirements

  1. Ensure that section titles in the section selector are displayed as plain text, without rendering raw HTML markup.
  2. Sections containing HTML markup in their titles must load correctly in the Content Translation workflow.
  3. The section selector must remain fully functional and not break when encountering special characters, HTML tags, or formatting within section titles.
  4. The solution should work consistently across different languages and wikis.
Test Steps

Test Case 1: Verify section selector handles HTML markup in titles

  1. Open Content Translation on Wikipedia.
  2. Select a source article that has section titles containing HTML markup (e.g., <i>, <b>, <span>).
  3. Open the section selector.
  4. ✅❓❌⬜ AC1: Confirm that section titles are displayed as plain text without showing raw HTML tags.
  5. ✅❓❌⬜ AC2: Confirm that selecting such a section loads the section content correctly without errors.

QA Results - TestWiki

ACStatusDetails
1❌T387427#11126740
2✅T387427#11126740

Details

Other Assignee
GMikesell-WMF
Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
• Nikerabbit triaged this task as Medium priority.Feb 27 2025, 8:58 AM
• Nikerabbit moved this task from Backlog to Core workflow on the SectionTranslation board.
• Nikerabbit added a project: LPL Hypothesis.
• PWaigi-WMF moved this task from Backlog to Prioritized on the LPL Hypothesis board.Mar 3 2025, 2:20 PM
SBisson claimed this task.Mar 18 2025, 8:28 PM
SBisson moved this task from Prioritized to In-progress on the LPL Hypothesis board.
• PWaigi-WMF subscribed.EditedMar 27 2025, 1:25 PM

Seems like duplicate tickets: (T307664), (T295095)

SBisson merged tasks: T307664: SX Section selector interface shows markups in section titles, T295095: wrong section name being shown on sx.Mar 27 2025, 1:38 PM
SBisson added subscribers: • Jpita, Pginer-WMF.
• PWaigi-WMF added a comment.Mar 27 2025, 1:42 PM

I've seen a similar issue in the previous step.

Screenshot 2025-03-27 at 16.38.31.png (3,600×1,350 px, 1 MB)

SBisson removed a subscriber: • Jpita.Mar 27 2025, 1:48 PM
SBisson removed SBisson as the assignee of this task.Apr 8 2025, 2:10 PM
SBisson moved this task from In-progress to Prioritized on the LPL Hypothesis board.
SBisson subscribed.
• PWaigi-WMF moved this task from Prioritized to Incoming on the LPL Hypothesis board.Apr 12 2025, 9:49 AM
• PWaigi-WMF moved this task from Incoming to Prioritized on the LPL Hypothesis board.Apr 16 2025, 5:58 PM
• PWaigi-WMF moved this task from Prioritized to Incoming on the LPL Hypothesis board.May 26 2025, 2:37 PM
• Nikerabbit edited projects, added: ContentTranslation; removed: SectionTranslation.Jun 2 2025, 2:21 PM
• Nikerabbit moved this task from Needs Triage to Dashboard on the ContentTranslation board.
SBisson moved this task from Incoming to Prioritized on the LPL Hypothesis board.Jun 27 2025, 7:34 PM
• Nikerabbit added a project: LPL Projects (Translation suggestions for New Editors – FY26 WE 2.1.2).Jul 10 2025, 6:42 AM
gerritbot added a comment.Aug 2 2025, 10:11 AM

Change #1175200 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX: Add utility to sanitize HTML with escaped brackets using mw.message

https://gerrit.wikimedia.org/r/1175200

gerritbot added a project: Patch-For-Review.Aug 2 2025, 10:11 AM
gerritbot added a comment.Aug 5 2025, 11:55 AM

Change #1175880 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] Confirm translation: Use sanitized HTML for prefilled section title

https://gerrit.wikimedia.org/r/1175880

gerritbot added a comment.Aug 5 2025, 12:47 PM

Change #1175892 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] Pick a section: Use v-html to display section titles

https://gerrit.wikimedia.org/r/1175892

ngkountas changed the task status from Open to In Progress.Aug 5 2025, 12:50 PM
ngkountas moved this task from Prioritized to In-progress on the LPL Hypothesis board.
gerritbot added a comment.Aug 6 2025, 4:47 PM

Change #1175892 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Pick a section: Use v-html to display section titles

https://gerrit.wikimedia.org/r/1175892

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.14; 2025-08-12).Aug 6 2025, 5:00 PM
gerritbot added a comment.Aug 6 2025, 10:54 PM

Change #1176321 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] Compare contents: Use sanitized HTML for section titles

https://gerrit.wikimedia.org/r/1176321

gerritbot added a comment.Aug 8 2025, 11:22 PM

Change #1176730 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] Fetch section titles from API instead of extracting from content

https://gerrit.wikimedia.org/r/1176730

gerritbot added a comment.Aug 8 2025, 11:35 PM

Change #1176732 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX dashboard published translation: Use v-html for first missing section

https://gerrit.wikimedia.org/r/1176732

gerritbot added a comment.Aug 8 2025, 11:35 PM

Change #1176733 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX dashboard draft translation: Use v-html for the section title

https://gerrit.wikimedia.org/r/1176733

gerritbot added a comment.Aug 8 2025, 11:51 PM

Change #1175200 abandoned by Nik Gkountas:

[mediawiki/extensions/ContentTranslation@master] CX: Add utility to sanitize HTML with escaped brackets using mw.message

Reason:

In favor of a different approach, implemented here: If5000bacf78e5831d26df953d0108b9a1e428be4

https://gerrit.wikimedia.org/r/1175200

ngkountas claimed this task.Aug 8 2025, 11:56 PM
ngkountas moved this task from In-progress to Needs Code Review on the LPL Hypothesis board.
gerritbot added a comment.Aug 11 2025, 3:45 PM

Change #1175880 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Confirm translation: Validate section title and display it as HTML

https://gerrit.wikimedia.org/r/1175880

gerritbot added a comment.Aug 13 2025, 10:21 AM

Change #1176321 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Compare contents: Use valid section titles from cxserver with v-html

https://gerrit.wikimedia.org/r/1176321

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.15; 2025-08-19); removed: MW-1.45-notes (1.45.0-wmf.14; 2025-08-12).Aug 13 2025, 11:00 AM
gerritbot added a comment.Aug 13 2025, 2:24 PM

Change #1176730 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Fetch section titles from API instead of extracting from content

https://gerrit.wikimedia.org/r/1176730

gerritbot added a comment.Aug 13 2025, 2:24 PM

Change #1176732 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX dashboard published translation: Use v-html for first missing section

https://gerrit.wikimedia.org/r/1176732

gerritbot added a comment.Aug 13 2025, 5:50 PM

Change #1176733 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX dashboard draft translation: Use v-html for the section title

https://gerrit.wikimedia.org/r/1176733

Maintenance_bot removed a project: Patch-For-Review.Aug 13 2025, 6:32 PM
gerritbot added a comment.Aug 18 2025, 11:06 AM

Change #1179651 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 1.0.0+20250818

https://gerrit.wikimedia.org/r/1179651

gerritbot added a project: Patch-For-Review.Aug 18 2025, 11:06 AM
ngkountas moved this task from Needs Code Review to Pending deployment on the LPL Hypothesis board.Aug 18 2025, 12:13 PM
gerritbot added a comment.Aug 18 2025, 1:29 PM

Change #1179651 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 1.0.0+20250818

https://gerrit.wikimedia.org/r/1179651

Maintenance_bot removed a project: Patch-For-Review.Aug 18 2025, 1:32 PM
gerritbot added a comment.Aug 19 2025, 12:42 PM

Change #1180127 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] Filter non-top-level sections during section title assignment

https://gerrit.wikimedia.org/r/1180127

gerritbot added a project: Patch-For-Review.Aug 19 2025, 12:42 PM
gerritbot added a comment.Aug 19 2025, 2:07 PM

Change #1180127 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Filter non-top-level sections during section title assignment

https://gerrit.wikimedia.org/r/1180127

Maintenance_bot removed a project: Patch-For-Review.Aug 19 2025, 2:31 PM
ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.16; 2025-08-26); removed: MW-1.45-notes (1.45.0-wmf.15; 2025-08-19).Aug 19 2025, 3:00 PM
gerritbot added a comment.Aug 21 2025, 8:59 AM

Change #1180824 had a related patch set uploaded (by KartikMistry; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@wmf/1.45.0-wmf.15] Filter non-top-level sections during section title assignment

https://gerrit.wikimedia.org/r/1180824

gerritbot added a project: Patch-For-Review.Aug 21 2025, 8:59 AM
gerritbot added a comment.Aug 21 2025, 10:35 AM

Change #1180836 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 1.0.0+20250821

https://gerrit.wikimedia.org/r/1180836

gerritbot added a comment.Aug 21 2025, 11:09 AM

Change #1180838 had a related patch set uploaded (by KartikMistry; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@wmf/1.45.0-wmf.15] CX3 Build 1.0.0+20250821

https://gerrit.wikimedia.org/r/1180838

gerritbot added a comment.Aug 21 2025, 11:53 AM

Change #1180836 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 1.0.0+20250821

https://gerrit.wikimedia.org/r/1180836

gerritbot added a comment.Aug 21 2025, 1:22 PM

Change #1180838 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@wmf/1.45.0-wmf.15] CX3 Build 1.0.0+20250821

https://gerrit.wikimedia.org/r/1180838

Stashbot added a comment.Aug 21 2025, 1:32 PM

Mentioned in SAL (#wikimedia-operations) [2025-08-21T13:32:39Z] <kartik@deploy1003> Started scap sync-world: Backport for [[gerrit:1180838|CX3 Build 1.0.0+20250821 (T387427)]]

Stashbot added a comment.Aug 21 2025, 1:36 PM

Mentioned in SAL (#wikimedia-operations) [2025-08-21T13:36:42Z] <kartik@deploy1003> kartik: Backport for [[gerrit:1180838|CX3 Build 1.0.0+20250821 (T387427)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

gerritbot added a comment.Aug 21 2025, 1:42 PM

Change #1180824 abandoned by KartikMistry:

[mediawiki/extensions/ContentTranslation@wmf/1.45.0-wmf.15] Filter non-top-level sections during section title assignment

Reason:

Use CX build backport instead.

https://gerrit.wikimedia.org/r/1180824

Stashbot added a comment.Aug 21 2025, 1:52 PM

Mentioned in SAL (#wikimedia-operations) [2025-08-21T13:52:17Z] <kartik@deploy1003> Finished scap sync-world: Backport for [[gerrit:1180838|CX3 Build 1.0.0+20250821 (T387427)]] (duration: 19m 38s)

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.15; 2025-08-19); removed: MW-1.45-notes (1.45.0-wmf.16; 2025-08-26).Aug 21 2025, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 21 2025, 2:31 PM
SBisson moved this task from Pending deployment to Needs QA on the LPL Hypothesis board.Aug 22 2025, 6:29 PM
GMikesell-WMF subscribed.Aug 27 2025, 10:24 PM

@ngkountas It no longer appears on the section screen, but when you go to editing, the HTML markup shows up in the title, as seen in the videos below.

Test Result - TestWiki

Status: ❌ FAIL
Environment: TestWiki
OS: macOS Sequoia 15.6.1
Browser: Chrome 138
Device: MBA
Emulated Device: NA

Test Artifact(s):

https://test.wikipedia.org/w/index.php?title=Special:ContentTranslation&active-list=suggestions&filter-id=previous-edits&filter-type=automatic&from=en&to=ml&page=Humayun%27s%20Tomb&section=%3Ci%3EChar%20Bagh%3C%2Fi%3E#/sx/section-selector
https://test.wikipedia.org/w/index.php?title=Special:ContentTranslation&filter-type=automatic&filter-id=previous-edits&active-list=suggestions&from=es&to=fr&page=Viviane%20Senna#/sx

Test Steps

Test Case 1: Verify section selector handles HTML markup in titles

  1. Open Content Translation on Wikipedia.
  2. Select a source article that has section titles containing HTML markup (e.g., <i>, <b>, <span>).
  3. Open the section selector.
  4. ❌ AC1: Confirm that section titles are displayed as plain text without showing raw HTML tags.
DesktopMobile

❌ Update from T387427#10683088
Is it supposed to have that reference number?

DesktopMobile
2025-08-27_13-01-35.png (1,719×971 px, 446 KB)
2025-08-27_13-04-16.png (797×1,077 px, 191 KB)
  1. ✅ AC2: Confirm that selecting such a section loads the section content correctly without errors.

See AC1

GMikesell-WMF updated the task description. (Show Details)Aug 27 2025, 10:26 PM
GMikesell-WMF updated Other Assignee, added: GMikesell-WMF.
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF moved this task from Needs QA to In-progress on the LPL Hypothesis board.
• Nikerabbit set the point value for this task to 4.Sep 4 2025, 11:23 AM
ngkountas changed the point value for this task from 4 to 8.Sep 4 2025, 12:19 PM
eamedina subscribed.Sep 24 2025, 2:53 PM

It no longer appears on the section screen, but when you go to editing, the HTML markup shows up in the title

Up until actually entering the editor, all text/labels are for display only. But then once inside the editor the expected behavior is: left column is read-only and right column is editable (desktop version). This introduces a new question then, how should we treat titles (with HTML) for the editable part? From my investigation:

  • The patch below [1] demonstrates how we could use OO.ui.HtmlSnippet for the read-only part inside the editor, but my understanding is that for editable fields, OOUI will always escape HTML for safety.
  • In production, section titles displayed with italics use wikitext for that (==''Char Bagh''==), for example, how does that play in as well?
  • Behavior that I'm seeing in the editor is that text formatting controls (italics, bold, etc) are disabled for titles [2].

We should talk about the expected/desired behavior inside the editor

[1] 1191070: Treat section titles with HTML in the editor | https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/1191070

[2]

image.png (1,518×404 px, 68 KB)

ngkountas moved this task from In-progress to Prioritized on the LPL Hypothesis board.Oct 14 2025, 9:05 AM
• Nikerabbit edited projects, added: LPL Projects (Other); removed: LPL Projects (Translation suggestions for New Editors – FY26 WE 2.1.2).Nov 5 2025, 2:05 PM
ngkountas removed ngkountas as the assignee of this task.Nov 7 2025, 2:53 PM
ngkountas subscribed.
eamedina added a comment.Nov 21 2025, 5:05 PM

As discussed with the team, I have created a follow up ticket to treat the editor part (T410761) and will move this to Design Signoff

eamedina moved this task from Prioritized to Design Signoff on the LPL Hypothesis board.Nov 21 2025, 5:06 PM
SGautam_WMF moved this task from Design Signoff to Product Signoff on the LPL Hypothesis board.Dec 8 2025, 7:05 AM
• Nikerabbit closed this task as Resolved.Dec 10 2025, 12:24 PM
• Nikerabbit claimed this task.
• Nikerabbit reassigned this task from • Nikerabbit to ngkountas.Jan 8 2026, 9:08 AM
• Nikerabbit subscribed.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits